From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DF9C432BE for ; Wed, 1 Sep 2021 22:01:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A7B06056B for ; Wed, 1 Sep 2021 22:01:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5A7B06056B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFCDA6E3B2; Wed, 1 Sep 2021 22:01:17 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id C33656E3B2 for ; Wed, 1 Sep 2021 22:01:16 +0000 (UTC) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 98A33340; Thu, 2 Sep 2021 00:01:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1630533675; bh=oBIuv/gN5NyegE3mK/LDP8EEP5EAxS3NGI0JIKQpmEE=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From; b=dtVrH0E6SkIwLsiU8IcybDaJs94nn4MAXDUf9jRMZEG/veXfBlLVFUw+H3DpYQzy2 R4984RKnHKvDnh+PbCMmupf/SBjYW6g7kYLZVrl9VWl1je5N9jsS1KJ1kP0PpT6HLs H0oGE3CmUghBiSYLHyBRiEfWdZT+Y2nrrX7pb8Ys= From: Kieran Bingham Subject: Re: [PATCH] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 To: Geert Uytterhoeven Cc: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Rob Herring , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> Message-ID: <22bf664e-4a28-3ae2-0106-5913a8643625@ideasonboard.com> Date: Wed, 1 Sep 2021 23:01:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Geert, On 23/06/2021 13:53, Geert Uytterhoeven wrote: > Hi Kieran, > > On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham > wrote: >> From: Kieran Bingham >> >> Extend the Renesas DU display bindings to support the r8a779a0 V3U. >> >> Signed-off-by: Kieran Bingham > > Thanks for your patch! > >> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml >> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml >> @@ -39,6 +39,7 @@ properties: >> - renesas,du-r8a77980 # for R-Car V3H compatible DU >> - renesas,du-r8a77990 # for R-Car E3 compatible DU >> - renesas,du-r8a77995 # for R-Car D3 compatible DU >> + - renesas,du-r8a779a0 # for R-Car V3U compatible DU >> >> reg: >> maxItems: 1 >> @@ -774,6 +775,57 @@ allOf: >> - reset-names >> - renesas,vsps >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - renesas,du-r8a779a0 >> + then: >> + properties: >> + clocks: >> + items: >> + - description: Functional clock for DU0 >> + - description: Functional clock for DU1 >> + >> + clock-names: >> + items: >> + - const: du.0 >> + - const: du.1 > > The hardware block has only a single function clock for both channels, > like on R-Car H1. Indeed, but I believe both channels still need to set them, if they can be operated independently, the driver looks up the clock based on the du.%d, and so for DU1, it is simply expressed as the same clock in DT. Is this acceptable? or is there further issues there? > > And what about DU_DOTCLKIN? This thread has already discussed this with Laurent, and I concur - There doesn't appear to be any relevant reference to DU_DOTCLKIN on the DU side. > > Gr{oetje,eeting}s, > > Geert > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 095D4C4320E for ; Wed, 1 Sep 2021 22:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEDA06101B for ; Wed, 1 Sep 2021 22:01:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232798AbhIAWCS (ORCPT ); Wed, 1 Sep 2021 18:02:18 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:52914 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230182AbhIAWCR (ORCPT ); Wed, 1 Sep 2021 18:02:17 -0400 Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 98A33340; Thu, 2 Sep 2021 00:01:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1630533675; bh=oBIuv/gN5NyegE3mK/LDP8EEP5EAxS3NGI0JIKQpmEE=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From; b=dtVrH0E6SkIwLsiU8IcybDaJs94nn4MAXDUf9jRMZEG/veXfBlLVFUw+H3DpYQzy2 R4984RKnHKvDnh+PbCMmupf/SBjYW6g7kYLZVrl9VWl1je5N9jsS1KJ1kP0PpT6HLs H0oGE3CmUghBiSYLHyBRiEfWdZT+Y2nrrX7pb8Ys= From: Kieran Bingham Subject: Re: [PATCH] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 To: Geert Uytterhoeven Cc: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Rob Herring , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20210622231146.3208404-1-kieran.bingham@ideasonboard.com> Message-ID: <22bf664e-4a28-3ae2-0106-5913a8643625@ideasonboard.com> Date: Wed, 1 Sep 2021 23:01:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On 23/06/2021 13:53, Geert Uytterhoeven wrote: > Hi Kieran, > > On Wed, Jun 23, 2021 at 1:11 AM Kieran Bingham > wrote: >> From: Kieran Bingham >> >> Extend the Renesas DU display bindings to support the r8a779a0 V3U. >> >> Signed-off-by: Kieran Bingham > > Thanks for your patch! > >> --- a/Documentation/devicetree/bindings/display/renesas,du.yaml >> +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml >> @@ -39,6 +39,7 @@ properties: >> - renesas,du-r8a77980 # for R-Car V3H compatible DU >> - renesas,du-r8a77990 # for R-Car E3 compatible DU >> - renesas,du-r8a77995 # for R-Car D3 compatible DU >> + - renesas,du-r8a779a0 # for R-Car V3U compatible DU >> >> reg: >> maxItems: 1 >> @@ -774,6 +775,57 @@ allOf: >> - reset-names >> - renesas,vsps >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - renesas,du-r8a779a0 >> + then: >> + properties: >> + clocks: >> + items: >> + - description: Functional clock for DU0 >> + - description: Functional clock for DU1 >> + >> + clock-names: >> + items: >> + - const: du.0 >> + - const: du.1 > > The hardware block has only a single function clock for both channels, > like on R-Car H1. Indeed, but I believe both channels still need to set them, if they can be operated independently, the driver looks up the clock based on the du.%d, and so for DU1, it is simply expressed as the same clock in DT. Is this acceptable? or is there further issues there? > > And what about DU_DOTCLKIN? This thread has already discussed this with Laurent, and I concur - There doesn't appear to be any relevant reference to DU_DOTCLKIN on the DU side. > > Gr{oetje,eeting}s, > > Geert >