From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 1/6] eal: eal stub to add windows support
Date: Fri, 01 Mar 2019 15:19:27 +0000
Message-ID: <22cc9e2b335b7363d873b051eda71f0812184f0d.camel@debian.org>
References: <20190301071847.13376-1-anand.rawat@intel.com>
 <20190301071847.13376-2-anand.rawat@intel.com> <1633455.prhy9BIAj0@xps>
 <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Anand Rawat <anand.rawat@intel.com>, dev@dpdk.org,
 pallavi.kadam@intel.com,  jeffrey.b.shaw@intel.com, ranjit.menon@intel.com
To: Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com
 [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id C36822BB5
 for <dev@dpdk.org>; Fri,  1 Mar 2019 16:19:29 +0100 (CET)
Received: by mail-wm1-f68.google.com with SMTP id z84so12587661wmg.4
 for <dev@dpdk.org>; Fri, 01 Mar 2019 07:19:29 -0800 (PST)
In-Reply-To: <20190301141717.GA325020@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2019-03-01 at 14:17 +0000, Bruce Richardson wrote:
> On Fri, Mar 01, 2019 at 03:03:02PM +0100, Thomas Monjalon wrote:
> > 01/03/2019 08:18, Anand Rawat:
> > >=20
> > [...]
> > > @@ -17,13 +17,19 @@ elif host_machine.system() =3D=3D 'freebsd'
> > > dpdk_conf.set('RTE_EXEC_ENV_BSDAPP', 1) subdir('bsdapp/eal')
> > > =20
> > > +elif host_machine.system() =3D=3D 'windows' +
> > > dpdk_conf.set('RTE_EXEC_ENV_WINDOWS', 1)
> >=20
> > For consistency, it should RTE_EXEC_ENV_WINAPP.
> >=20
> For this one you can partially blame me - early internal review
> suggested
> changing to winapp, but I suggested holding off on the change for
> community
> consensus. Personally, I  would prefer a little inconsistency and
> keep it
> as windows for clarity. In future, I also think we should just rename
> linxuapp to linux, and bsdapp to freebsd!
>=20
> However, for now, if the majority prefer winapp, I'm ok with it.
> [Though I
> can't help reading it as winamp half the time! No llamas involved
> here
> though!]
>=20
> /Bruce

We already have many utility libs and tools in DPDK, surely it's fine
to add userspace-accelerated MP3 playback too!

--=20
Kind regards,
Luca Boccassi