All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Tremblay <etremblay@distech-controls.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
	matwey.kornilov@gmail.com, giulio.benetti@micronovasrl.com,
	lukas@wunner.de, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	christoph.muellner@theobroma-systems.com, heiko@sntech.de,
	heiko.stuebner@theobroma-systems.com
Subject: Re: [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64
Date: Fri, 29 Jan 2021 13:04:04 -0500	[thread overview]
Message-ID: <22d98a58-724c-a563-d55c-7c18b5271ec7@distech-controls.com> (raw)
In-Reply-To: <YBPwlmxNfrxSLK0B@smile.fi.intel.com>

On 2021-01-29 6:25 a.m., Andy Shevchenko wrote:
> On Thu, Jan 28, 2021 at 06:36:29PM -0500, Eric Tremblay wrote:
>> That port does not have an interrupt on TEMT when using
>> the FIFO mode.
> This is wrong.
> 1. You have to guarantee that TEMT is set for all UARTs before this patch
> 2. World is not staying on OF only platforms
>
> NAK

Considering the use of the reversed capability UART_CAP_NOTEMT should I set
the flag directly in uart_config like:

[PORT_16550A_FSL64] = {
		.name		= "16550A_FSL64",
		.fifo_size	= 64,
		.tx_loadsz	= 63,
		.fcr		= UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_10 |
				  UART_FCR7_64BYTE,
		.flags		= UART_CAP_FIFO | UART_CAP_NOTEMT,
	},

>


  parent reply	other threads:[~2021-01-29 18:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 23:36 [PATCH 0/3] Handle UART without interrupt on TEMT using em485 Eric Tremblay
2021-01-28 23:36 ` [PATCH 1/3] serial: 8250: " Eric Tremblay
2021-01-29  7:23   ` Jiri Slaby
2021-02-02  0:15     ` Eric Tremblay
     [not found]   ` <YBPv/EA5LwA6jxId@smile.fi.intel.com>
2021-01-29 16:22     ` Eric Tremblay
2021-01-28 23:36 ` [PATCH 2/3] serial: 8250: add compatible for fsl,16550-FIFO64 Eric Tremblay
2021-01-28 23:36 ` [PATCH 3/3] serial: 8250: remove UART_CAP_TEMT on PORT_16550A_FSL64 Eric Tremblay
     [not found]   ` <YBPwlmxNfrxSLK0B@smile.fi.intel.com>
2021-01-29 18:04     ` Eric Tremblay [this message]
2021-01-29 18:42       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22d98a58-724c-a563-d55c-7c18b5271ec7@distech-controls.com \
    --to=etremblay@distech-controls.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=christoph.muellner@theobroma-systems.com \
    --cc=giulio.benetti@micronovasrl.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko.stuebner@theobroma-systems.com \
    --cc=heiko@sntech.de \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=matwey.kornilov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.