From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbdAPSbq (ORCPT ); Mon, 16 Jan 2017 13:31:46 -0500 Received: from mout.web.de ([212.227.15.14]:53027 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdAPSbn (ORCPT ); Mon, 16 Jan 2017 13:31:43 -0500 Subject: Re: SELinux: Checking source code positions for the setting of error codes To: Eric Paris , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris References: <1484580399.19104.6.camel@redhat.com> Cc: James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: <22f22cfd-8843-5cfd-6207-f61c80e52b1f@users.sourceforge.net> Date: Mon, 16 Jan 2017 19:31:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484580399.19104.6.camel@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:FPon06lVp/byXV6/PDoFsmFlBWIB4upGqvtZeDcx2C5DVZa4bW2 a5kE0urVF6DCwEGOeyL43hfL6+ktGXOmz/OZ6irckAVQq5H3uuyGe67VmV906bZHvicw1dn JwR603HNADCCnM9xdEJpuEME9Za5h80JHXG1873FUZSolivltsrfrj4NLbq3CA7C7btx1EE WmkmxLXHyGeDVCsLPsiyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:TQjiajQYgTQ=:5p8SdMRyNsRQrhHqj5CS3l SuA0gLeQwxYkRDsX4wCJ5ZsK+qHdBdiwvp/t1UaC4mP5gAl2voFDjZjiPMmwyy5jj4NPnnFwk DnPTREK12+xLiDkliIPKnZw8x9Ec/HRF7rUUbYT67twALXoj/zIocsB7hB2zCy3EK0JT9ofKq pK9iaGQ26Pe/DQZ+Qn6rvvFe9fPtp5sTBYiSFKOrnpaU7BihxAdS5Brz6hL0lqm8a9jbUV8Wg 7cqzuvN1hjARxntob1uYwxnCDRBG95+kTFymf6TP7dDqHaZ65QiqBCnPKY0cBx0Hs2P8k30PT jn26kEVj759Pr4WIkNfgFcqkGcUL1nbx2l815Ln+fPw+rNm0Q1GZOxbNZN2joq2l8txLG8Cc6 +eLiLr9FdnNp9uCieA6b68A9T4bmPtspYXMdx3tYFL6T6KI+BJRHVYkvr4+Pi+laIEpvIfixY vEDk/1idFEDo4OKtgEUOlrex62Fqtw8YQdKprl/GpOO6vcWgA8kPKPpqzuiPnoib4nqCE2ogs jB4zdNmW7+BmIfz7V3bpcFchh3yFK1sWVEzyM1Vsoa78QcArbWTWJEkybYYi5tE5OeUsD+GNk c14CFffcTgkMfHhY/qccCIgdrM07PvP3uIVflXvAPxkudImpLzPyqeXIT5rIv1aSKJ3H0dJtI Ma+7MmljzzsAndvw9s0V0Uq1X/7mSYwiTsxDMNKzeJHtT4/fXcJWq7f/y95SFxM1GxUTSun2n r2UTtP/Mv9DeTrZffbmlRh04fB9jR+yq7xemH43e15AUNKjoQNPIhgj9Z0Cf+Sk+rQuWT2m6U l8o/T7i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I have a personal style preference for > > rc = -ENOMEM; > val = kalloc(); > if (!val) > goto err; > > vs > > val = kalloc(); > if (!val) { > rc = -ENOMEM; > goto err; > } > > because it saves 1 line Thanks for your feedback. > and I think the compiler does the right/same thing. * Did you check any corresponding code generation results in more detail? * Can misplaced variable assignments result in unwanted run time consequences because of the previous approach for a control flow specification? * How do you think about to achieve that error codes will only be set after a specific software failure was detected? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 16 Jan 2017 18:31:02 +0000 Subject: Re: SELinux: Checking source code positions for the setting of error codes Message-Id: <22f22cfd-8843-5cfd-6207-f61c80e52b1f@users.sourceforge.net> List-Id: References: <1484580399.19104.6.camel@redhat.com> In-Reply-To: <1484580399.19104.6.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Eric Paris , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris Cc: James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org > I have a personal style preference for > > rc = -ENOMEM; > val = kalloc(); > if (!val) > goto err; > > vs > > val = kalloc(); > if (!val) { > rc = -ENOMEM; > goto err; > } > > because it saves 1 line Thanks for your feedback. > and I think the compiler does the right/same thing. * Did you check any corresponding code generation results in more detail? * Can misplaced variable assignments result in unwanted run time consequences because of the previous approach for a control flow specification? * How do you think about to achieve that error codes will only be set after a specific software failure was detected? Regards, Markus