All of lore.kernel.org
 help / color / mirror / Atom feed
From: kgene@kernel.org
To: 'Tejun Heo' <tj@kernel.org>, 'Sachin Kamat' <sachin.kamat@linaro.org>
Cc: linux-ide@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	patches@linaro.org
Subject: RE: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
Date: Sat, 04 Jan 2014 11:25:05 +0900	[thread overview]
Message-ID: <22fa01cf08f4$2e496c80$8adc4580$@kernel.org> (raw)
In-Reply-To: <20131231113428.GA3985@htj.dyndns.org>

Tejun Heo wrote:
> 
> On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote:
> > plat/regs-ata.h is used only by Samsung PATA driver.
> > Move this file to the drivers folder to remove platform
> > dependency required for multiplatform support.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> 
> Applied to libata/for-3.14.
> 
> As this is only used by pata_samsung_cf.c, can you please follow up
> with a patch to roll pata_samsung_cf.h into .c?  There's no point in
> creating separate header files for stuff which isn't shared among
> multiple files.
> 
Oops, I read this just now ;-)

Tejun, if you've applied this in your tree already, I'm OK so please kindly
ignore my previous reply.

Sachin, when you move the definitions into the .c file per Tejun's
suggestion, please cleanup useless definitions.

Thanks and happy new year.
- Kukjin


  parent reply	other threads:[~2014-01-04  2:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-31  5:29 [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata Sachin Kamat
2013-12-31  6:32 ` Jingoo Han
2013-12-31 11:34 ` Tejun Heo
2014-01-02  0:49   ` Jingoo Han
2014-01-02  0:49     ` Jingoo Han
2014-01-04  2:25   ` kgene [this message]
2014-01-04  2:00 ` kgene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='22fa01cf08f4$2e496c80$8adc4580$@kernel.org' \
    --to=kgene@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=sachin.kamat@linaro.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.