From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754508AbeDTIHq (ORCPT ); Fri, 20 Apr 2018 04:07:46 -0400 Received: from esa6.microchip.iphmx.com ([216.71.154.253]:53431 "EHLO esa6.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754387AbeDTIHk (ORCPT ); Fri, 20 Apr 2018 04:07:40 -0400 X-IronPort-AV: E=Sophos;i="5.49,469,1520924400"; d="scan'208";a="10756483" Subject: Re: [PATCH 61/61] ASoC: atmel: simplify getting .drvdata To: Wolfram Sang , CC: , , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Alexandre Belloni , , References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-62-wsa+renesas@sang-engineering.com> From: Nicolas Ferre Organization: microchip Message-ID: <23044c16-efbf-7920-2a25-338ad46376eb@microchip.com> Date: Fri, 20 Apr 2018 10:06:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180419140641.27926-62-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2018 at 16:06, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Nicolas Ferre > --- > > Build tested only. buildbot is happy. Please apply individually. > > sound/soc/atmel/atmel_ssc_dai.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index a1e2c5682dcd..4a0275a6505d 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -1002,8 +1002,7 @@ static const struct snd_soc_component_driver atmel_ssc_component = { > > static int asoc_ssc_init(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > int ret; > > ret = snd_soc_register_component(dev, &atmel_ssc_component, > @@ -1033,8 +1032,7 @@ static int asoc_ssc_init(struct device *dev) > > static void asoc_ssc_exit(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > > if (ssc->pdata->use_dma) > atmel_pcm_dma_platform_unregister(dev); > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Date: Fri, 20 Apr 2018 08:06:46 +0000 Subject: Re: [PATCH 61/61] ASoC: atmel: simplify getting .drvdata Message-Id: <23044c16-efbf-7920-2a25-338ad46376eb@microchip.com> List-Id: References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-62-wsa+renesas@sang-engineering.com> In-Reply-To: <20180419140641.27926-62-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: Alexandre Belloni , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , linux-renesas-soc@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org On 19/04/2018 at 16:06, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Nicolas Ferre > --- > > Build tested only. buildbot is happy. Please apply individually. > > sound/soc/atmel/atmel_ssc_dai.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index a1e2c5682dcd..4a0275a6505d 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -1002,8 +1002,7 @@ static const struct snd_soc_component_driver atmel_ssc_component = { > > static int asoc_ssc_init(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > int ret; > > ret = snd_soc_register_component(dev, &atmel_ssc_component, > @@ -1033,8 +1032,7 @@ static int asoc_ssc_init(struct device *dev) > > static void asoc_ssc_exit(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > > if (ssc->pdata->use_dma) > atmel_pcm_dma_platform_unregister(dev); > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH 61/61] ASoC: atmel: simplify getting .drvdata Date: Fri, 20 Apr 2018 10:06:46 +0200 Message-ID: <23044c16-efbf-7920-2a25-338ad46376eb@microchip.com> References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-62-wsa+renesas@sang-engineering.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from esa6.microchip.iphmx.com (esa6.microchip.iphmx.com [216.71.154.253]) by alsa0.perex.cz (Postfix) with ESMTP id A55DA266CA1 for ; Fri, 20 Apr 2018 10:07:41 +0200 (CEST) In-Reply-To: <20180419140641.27926-62-wsa+renesas@sang-engineering.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: Alexandre Belloni , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , linux-renesas-soc@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 19/04/2018 at 16:06, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Nicolas Ferre > --- > > Build tested only. buildbot is happy. Please apply individually. > > sound/soc/atmel/atmel_ssc_dai.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index a1e2c5682dcd..4a0275a6505d 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -1002,8 +1002,7 @@ static const struct snd_soc_component_driver atmel_ssc_component = { > > static int asoc_ssc_init(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > int ret; > > ret = snd_soc_register_component(dev, &atmel_ssc_component, > @@ -1033,8 +1032,7 @@ static int asoc_ssc_init(struct device *dev) > > static void asoc_ssc_exit(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > > if (ssc->pdata->use_dma) > atmel_pcm_dma_platform_unregister(dev); > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@microchip.com (Nicolas Ferre) Date: Fri, 20 Apr 2018 10:06:46 +0200 Subject: [PATCH 61/61] ASoC: atmel: simplify getting .drvdata In-Reply-To: <20180419140641.27926-62-wsa+renesas@sang-engineering.com> References: <20180419140641.27926-1-wsa+renesas@sang-engineering.com> <20180419140641.27926-62-wsa+renesas@sang-engineering.com> Message-ID: <23044c16-efbf-7920-2a25-338ad46376eb@microchip.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 19/04/2018 at 16:06, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang Acked-by: Nicolas Ferre > --- > > Build tested only. buildbot is happy. Please apply individually. > > sound/soc/atmel/atmel_ssc_dai.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index a1e2c5682dcd..4a0275a6505d 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -1002,8 +1002,7 @@ static const struct snd_soc_component_driver atmel_ssc_component = { > > static int asoc_ssc_init(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > int ret; > > ret = snd_soc_register_component(dev, &atmel_ssc_component, > @@ -1033,8 +1032,7 @@ static int asoc_ssc_init(struct device *dev) > > static void asoc_ssc_exit(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct ssc_device *ssc = platform_get_drvdata(pdev); > + struct ssc_device *ssc = dev_get_drvdata(dev); > > if (ssc->pdata->use_dma) > atmel_pcm_dma_platform_unregister(dev); > -- Nicolas Ferre