From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 1/7] app/procinfo: prepare for new debug
	functions
Date: Thu, 10 Jan 2019 10:09:00 +0100
Message-ID: <23092145.fqvuDreClZ@xps>
References: <20181213050842.64587-1-vipin.varghese@intel.com>
 <4383677.neL5jlz7Vu@xps>
 <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE771@BGSMSX101.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Pattan, Reshma" <reshma.pattan@intel.com>,
 "Mcnamara, John" <john.mcnamara@intel.com>, "Patel,
 Amol" <amol.patel@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, "Singh,
 Jasvinder" <jasvinder.singh@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E67391B5B5
 for <dev@dpdk.org>; Thu, 10 Jan 2019 10:09:03 +0100 (CET)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2EE771@BGSMSX101.gar.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/01/2019 09:53, Varghese, Vipin:
> Hi Thomas,
> 
> snipped
> > 
> > 10/01/2019 04:08, Varghese, Vipin:
> > > snipped
> > > >
> > > > Hi Vipin,
> > > >
> > > > The code split in this v8 looks really better, except this patch
> > > > which makes no sense alone.
> > > Hi Thomas, I need this base patch as first one. These include the helper
> > MACRO and include which pans out for next 7 patches.
> > >
> > > > I feel you can move these changes in next patches, where appropriate, isn't
> > it?
> > > Patches v2 to v7 uses common features from v1.
> > 
> > At least, you should introduce the includes when needed.
> As mentioned earlier these are used in v2 to v7.

So?
They must be introduced first time they are used.
Vipin, please be cooperative.

> > If you need this patch for introducing some macros, then rename it and
> > explain the macros in the message.
> The MACRO introduced in this patch are 'MAX_STRING_LEN, STATS_BDR_FMT and STATS_BDR_STR'. As per code contribution guideline I may have missed out the stipulation requesting for explaining the same.
> 
> > 
> > 
> > > > 07/01/2019 16:38, Vipin Varghese:
> > > > > Update code base and meson build file to accommodate changes for
> > > > > the new functionality.
> > > > >
> > > > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > > > > Acked-by: Reshma  Pattan <reshma.pattan@intel.com>
> > > > > ---
> snipped
>