From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAywH-0003CM-C2 for qemu-devel@nongnu.org; Tue, 24 Apr 2018 10:29:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAywD-0004th-Fe for qemu-devel@nongnu.org; Tue, 24 Apr 2018 10:29:01 -0400 Received: from smtp03.citrix.com ([162.221.156.55]:53282) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fAywD-0004tB-60 for qemu-devel@nongnu.org; Tue, 24 Apr 2018 10:28:57 -0400 From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-ID: <23263.16162.507919.766810@mariner.uk.xensource.com> Date: Tue, 24 Apr 2018 15:28:50 +0100 In-Reply-To: <20180423150553.GC1980@perard> References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-4-git-send-email-ian.jackson@eu.citrix.com> <20180423150553.GC1980@perard> Subject: Re: [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: qemu-devel@nongnu.org, Ross Lagerwall , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org Anthony PERARD writes ("Re: [PATCH 03/16] xen: link against xentoolcore"): > On Thu, Apr 19, 2018 at 05:45:06PM +0100, Ian Jackson wrote: > > xen_pc="xencontrol xenstore xenguest xenforeignmemory xengnttab" > > - xen_pc="$xen_pc xenevtchn xendevicemodel" > > + xen_pc="$xen_pc xenevtchn xendevicemodel xentoolcore" > > I think we want to check if "xentoolcore" pkg_config exist before trying > to use it. Otherwith, that is not going to work with Xen older than > 4.10. Yes. Thanks for spotting this. My tests were all with builds from in the Xen tree and I hadn't spotted that that is handled as a special case. > Instead, we could do this: > if $pkg_config --exists xentoolcore; then > xen_pc+=" xentoolcore" > fi I will test that. Ian. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH 03/16] xen: link against xentoolcore Date: Tue, 24 Apr 2018 15:28:50 +0100 Message-ID: <23263.16162.507919.766810@mariner.uk.xensource.com> References: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com> <1524156319-11465-4-git-send-email-ian.jackson@eu.citrix.com> <20180423150553.GC1980@perard> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fAywC-0003YO-TH for xen-devel@lists.xenproject.org; Tue, 24 Apr 2018 14:28:56 +0000 In-Reply-To: <20180423150553.GC1980@perard> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Anthony PERARD Cc: Juergen Gross , Ross Lagerwall , Stefano Stabellini , qemu-devel@nongnu.org, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org QW50aG9ueSBQRVJBUkQgd3JpdGVzICgiUmU6IFtQQVRDSCAwMy8xNl0geGVuOiBsaW5rIGFnYWlu c3QgeGVudG9vbGNvcmUiKToKPiBPbiBUaHUsIEFwciAxOSwgMjAxOCBhdCAwNTo0NTowNlBNICsw MTAwLCBJYW4gSmFja3NvbiB3cm90ZToKPiA+ICAgICAgeGVuX3BjPSJ4ZW5jb250cm9sIHhlbnN0 b3JlIHhlbmd1ZXN0IHhlbmZvcmVpZ25tZW1vcnkgeGVuZ250dGFiIgo+ID4gLSAgICB4ZW5fcGM9 IiR4ZW5fcGMgeGVuZXZ0Y2huIHhlbmRldmljZW1vZGVsIgo+ID4gKyAgICB4ZW5fcGM9IiR4ZW5f cGMgeGVuZXZ0Y2huIHhlbmRldmljZW1vZGVsIHhlbnRvb2xjb3JlIgo+IAo+IEkgdGhpbmsgd2Ug d2FudCB0byBjaGVjayBpZiAieGVudG9vbGNvcmUiIHBrZ19jb25maWcgZXhpc3QgYmVmb3JlIHRy eWluZwo+IHRvIHVzZSBpdC4gT3RoZXJ3aXRoLCB0aGF0IGlzIG5vdCBnb2luZyB0byB3b3JrIHdp dGggWGVuIG9sZGVyIHRoYW4KPiA0LjEwLgoKWWVzLiAgVGhhbmtzIGZvciBzcG90dGluZyB0aGlz LiAgTXkgdGVzdHMgd2VyZSBhbGwgd2l0aCBidWlsZHMgZnJvbSBpbgp0aGUgWGVuIHRyZWUgYW5k IEkgaGFkbid0IHNwb3R0ZWQgdGhhdCB0aGF0IGlzIGhhbmRsZWQgYXMgYSBzcGVjaWFsCmNhc2Uu Cgo+IEluc3RlYWQsIHdlIGNvdWxkIGRvIHRoaXM6Cj4gaWYgJHBrZ19jb25maWcgLS1leGlzdHMg eGVudG9vbGNvcmU7IHRoZW4KPiAgIHhlbl9wYys9IiB4ZW50b29sY29yZSIKPiBmaQoKSSB3aWxs IHRlc3QgdGhhdC4KCklhbi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4t ZGV2ZWw=