From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FE5C77B72 for ; Fri, 14 Apr 2023 11:14:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230379AbjDNLOd (ORCPT ); Fri, 14 Apr 2023 07:14:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229596AbjDNLOc (ORCPT ); Fri, 14 Apr 2023 07:14:32 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A457D94 for ; Fri, 14 Apr 2023 04:14:31 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id x4so3000272lfr.8 for ; Fri, 14 Apr 2023 04:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681470869; x=1684062869; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CCP7uzKaaXleul1h5NRBOZWggdFvVQLh2PRTfUPevlE=; b=Gw3JIq4TwS0OyaLLlVhQvleKAT9sqOlR4KMCDgysvcwqABawxcrMqBBPsDvQs1EsV3 uRUJagqlukaa450ApAzeU/FHNh9j8unNCdRy1A8cos+8+xQkZQsvgs0zDcFnIUoYh0MK L/WOUBDH8yWGQ07lwd5H7TTKB/FLjbbOpXIQ9Ueu4L41t7Tzj5UDMXVFLXE0NryeCGF3 P83Dqx0N5ukMFL0VnA2E9lebMqaHYxJCtRCkdKZF0ooEy6otekV+Vtnw+kO7dEnCW4Bl CFyhzNsWvVogWqXdOQZZiHrPcDblxVLanih+UL3Lrn4RQe72uijpZPBQjI+vQN47TLau /ERg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681470869; x=1684062869; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CCP7uzKaaXleul1h5NRBOZWggdFvVQLh2PRTfUPevlE=; b=Hqm5jmGLrI31j5fFhmohOxlDLPvkhEUTVR82pLe3hZ8DqkuyoKGMXY8do0vkre4qkZ yPrzGlSBYqpWLOXX2j1m8ECDZ8ozyIqHlEWg3fl74A0F8V0+9gwEtaEBlGMCwaE/KlDC C6hImlZ+QIQyPLcmU3u8ZFq7lcSDLW/5Fx9S0SO7X+3h1gLHNa+uxmQPlEneAV/twerB RxzsKoM0+nq3iVYWwR7oFTLWyZlUyJnH6MkVSpISaKNQZ2/yepVUWXMNMeY8su8fpvFK 3Ya7xHcGClNk6G9uRNtkFIC09LPjRCxoeB+1ALjWF8XRB0yiE02pOIiDjo+UX1QJZPXq zPOw== X-Gm-Message-State: AAQBX9c95uezQLJ8W4j36R7MoQf/Kd/Eo0OvSnkWXHgLuyfumpZ+NSO5 IyuZpnD/DEu+QddS4OUt03OeqMlL/eM5ESGkNSA= X-Google-Smtp-Source: AKy350ajyGff4BJxFlWFmId+REsisaKxDZG769Bylihlkj2zyBBIT3FFRpKGAq2lR2JQOi9b9OddGA== X-Received: by 2002:ac2:442c:0:b0:4e0:ff8e:bbfe with SMTP id w12-20020ac2442c000000b004e0ff8ebbfemr1673450lfl.12.1681470869249; Fri, 14 Apr 2023 04:14:29 -0700 (PDT) Received: from [192.168.1.101] (abyl123.neoplus.adsl.tpnet.pl. [83.9.31.123]) by smtp.gmail.com with ESMTPSA id b14-20020ac2562e000000b004b57bbaef87sm741584lff.224.2023.04.14.04.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Apr 2023 04:14:28 -0700 (PDT) Message-ID: <232e1687-7ad3-3cf9-1f0f-811e7d87b740@linaro.org> Date: Fri, 14 Apr 2023 13:14:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 2/2] clk: qcom: Introduce SM8350 VIDEOCC Content-Language: en-US To: Stephen Boyd , Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Michael Turquette , Philipp Zabel , Rob Herring , Taniya Das Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230413-topic-lahaina_vidcc-v1-0-134f9b22a5b3@linaro.org> <20230413-topic-lahaina_vidcc-v1-2-134f9b22a5b3@linaro.org> <2f955dc3105570df0acc2695739183ed.sboyd@kernel.org> From: Konrad Dybcio In-Reply-To: <2f955dc3105570df0acc2695739183ed.sboyd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 13.04.2023 21:04, Stephen Boyd wrote: > Quoting Konrad Dybcio (2023-04-13 11:44:59) >> diff --git a/drivers/clk/qcom/videocc-sm8350.c b/drivers/clk/qcom/videocc-sm8350.c >> new file mode 100644 >> index 000000000000..186a5bd9e184 >> --- /dev/null >> +++ b/drivers/clk/qcom/videocc-sm8350.c >> @@ -0,0 +1,575 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2019-2020, The Linux Foundation. All rights reserved. >> + * Copyright (c) 2023, Linaro Limited >> + */ >> + [...] >> +enum { >> + P_BI_TCXO, >> + P_BI_TCXO_AO, >> + P_SLEEP_CLK, >> + P_VIDEO_PLL0_OUT_MAIN, >> + P_VIDEO_PLL1_OUT_MAIN, >> +}; >> + >> +static struct pll_vco lucid_5lpe_vco[] = { > > const > >> + { 249600000, 1750000000, 0 }, >> +}; >> + [...] >> +static struct clk_alpha_pll video_pll0 = { >> + .offset = 0x42c, >> + .vco_table = lucid_5lpe_vco, >> + .num_vco = ARRAY_SIZE(lucid_5lpe_vco), >> + .regs = clk_alpha_pll_regs[CLK_ALPHA_PLL_TYPE_LUCID], >> + .clkr = { >> + .hw.init = &(struct clk_init_data){ > > const Ack to both [...] >> + >> +static int video_cc_sm8350_probe(struct platform_device *pdev) >> +{ >> + struct regmap *regmap; >> + int ret; >> + >> + pm_runtime_enable(&pdev->dev); >> + >> + ret = devm_add_action_or_reset(&pdev->dev, video_cc_sm8350_pm_runtime_disable, &pdev->dev); > > devm_pm_runtime_enable()? Right. Konrad > >> + if (ret) >> + return ret; >> +