From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] eal: fix use-after-free issue on thread creation Date: Wed, 02 May 2018 17:26:18 +0200 Message-ID: <2330312.QrEeuOKnyk@xps> References: <1525255198-20906-1-git-send-email-jianfeng.tan@intel.com> <1525269134-103270-1-git-send-email-jianfeng.tan@intel.com> <20180502145622.5lka4i2hqehizij3@neon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier Matz , anatoly.burakov@intel.com To: Jianfeng Tan Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 744FD23C for ; Wed, 2 May 2018 17:26:21 +0200 (CEST) In-Reply-To: <20180502145622.5lka4i2hqehizij3@neon> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/05/2018 16:56, Olivier Matz: > On Wed, May 02, 2018 at 01:52:14PM +0000, Jianfeng Tan wrote: > > After below commit, we encounter some strange issue: > > 1) Dead lock as described here: > > http://dpdk.org/ml/archives/dev/2018-April/099806.html > > 2) SIGSEGV issue when starting a testpmd in VM. > > > > Considering below commit changes to use dynamic memory instead of > > stack for memory barrier, we doubt it's caused by use-after-free. > > > > Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier") > > > > Reported-by: Maxime Coquelin > > Reported-by: Lei Yao > > Suggested-by: Stephen Hemminger > > Signed-off-by: Jianfeng Tan > > Suggested-by: Olivier Matz > > Reviewed-by: Olivier Matz > > Thank you for fixing my stuff :) Applied, thanks