From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC6A3C6379F for ; Tue, 17 Jan 2023 08:22:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236093AbjAQIWq (ORCPT ); Tue, 17 Jan 2023 03:22:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236060AbjAQIWW (ORCPT ); Tue, 17 Jan 2023 03:22:22 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEE3121953 for ; Tue, 17 Jan 2023 00:21:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673943697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=97oI/IL5vpyW9d0mA0H44YuBpOV22dJNfei8BHRb/0U=; b=Ur7m9GJVyBQyWAbfHEmAg6gSXnrXRAaSTLAEILx5ycYB8j0W6kYlFNWWbfilAW0UuQNgRQ V6RkMX8A5lyFppN44p7RK7JLGoilwgi64lTqVWSN2YZ7xv/twJeYpM8+gjIKOrpQk8Q82E mD0SysXA838KeTOk0vX1UN28CxSum8s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-50-1PNR3G-BOvGdsrjjOi_D5g-1; Tue, 17 Jan 2023 03:21:33 -0500 X-MC-Unique: 1PNR3G-BOvGdsrjjOi_D5g-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C5F580234E; Tue, 17 Jan 2023 08:21:33 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28E37492B10; Tue, 17 Jan 2023 08:21:32 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391053934.2311931.17229969100836070492.stgit@warthog.procyon.org.uk> To: Christoph Hellwig Cc: dhowells@redhat.com, Al Viro , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 08/34] mm: Provide a helper to drop a pin/ref on a page MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2330570.1673943691.1@warthog.procyon.org.uk> Date: Tue, 17 Jan 2023 08:21:31 +0000 Message-ID: <2330571.1673943691@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Christoph Hellwig wrote: > On Mon, Jan 16, 2023 at 11:08:59PM +0000, David Howells wrote: > > Provide a helper in the get_user_pages code to drop a pin or a ref on a > > page based on being given FOLL_GET or FOLL_PIN in its flags argument or do > > nothing if neither is set. > > Please don't add new page based helpers. Yes, I know, but all of the callers still use pages, not folios. David