From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 1/7] lib/librte_ether: modify the structures for fdir new modes Date: Fri, 23 Oct 2015 09:29:54 +0200 Message-ID: <2331686.veA1YA3sRZ@xps13> References: <1443161125-1035-1-git-send-email-wenzhuo.lu@intel.com> <20151022125718.GB20740@bricha3-MOBL3> <6A0DE07E22DDAD4C9103DF62FEBC0909020A1EE3@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Lu, Wenzhuo" Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 1E133C458 for ; Fri, 23 Oct 2015 09:31:00 +0200 (CEST) Received: by wicll6 with SMTP id ll6so19019142wic.0 for ; Fri, 23 Oct 2015 00:31:00 -0700 (PDT) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909020A1EE3@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-10-23 01:22, Lu, Wenzhuo: > From: Richardson, Bruce > > > union rte_eth_fdir_flow { > > > - struct rte_eth_l2_flow l2_flow; > > > - struct rte_eth_udpv4_flow udp4_flow; > > > - struct rte_eth_tcpv4_flow tcp4_flow; > > > - struct rte_eth_sctpv4_flow sctp4_flow; > > > - struct rte_eth_ipv4_flow ip4_flow; > > > - struct rte_eth_udpv6_flow udp6_flow; > > > - struct rte_eth_tcpv6_flow tcp6_flow; > > > - struct rte_eth_sctpv6_flow sctp6_flow; > > > - struct rte_eth_ipv6_flow ipv6_flow; > > > + struct rte_eth_l2_flow l2_flow; > > > + struct rte_eth_udpv4_flow udp4_flow; > > > + struct rte_eth_tcpv4_flow tcp4_flow; > > > + struct rte_eth_sctpv4_flow sctp4_flow; > > > + struct rte_eth_ipv4_flow ip4_flow; > > > + struct rte_eth_udpv6_flow udp6_flow; > > > + struct rte_eth_tcpv6_flow tcp6_flow; > > > + struct rte_eth_sctpv6_flow sctp6_flow; > > > + struct rte_eth_ipv6_flow ipv6_flow; > > > + struct rte_eth_mac_vlan_flow mac_vlan_flow; > > > + struct rte_eth_tunnel_flow tunnel_flow; > > > > Can you please minimize the whitespace changes here. It looks in the diff > > like you are replacing the entire set of entries, but on closer inspection it > > looks like you are just adding in two extra lines. > Using vi or other editing tools, we can see all this fields are aligned. I think it's > worth to keep it. Bruce means you should avoid changing lines only for alignment. It's not a big deal if mac_vlan_flow is not perfectly aligned. When cosmetic rework is really needed, it's better to do it in a separate patch.