From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. R. Okajima" Subject: Re: [RFC PATCH v3 1/2] tmpfs: manage the inode-number by IDR, signed int inum Date: Tue, 03 Jun 2014 23:36:32 +0900 Message-ID: <23318.1401806192@jrobl> References: <20140522151431.GA25517@lst.de> <1401639537-6449-1-git-send-email-hooanon05g@gmail.com> <1401639537-6449-2-git-send-email-hooanon05g@gmail.com> <20140603090400.GB29219@quack.suse.cz> Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com, viro@zeniv.linux.org.uk, Eric Dumazet , Hugh Dickins , Christoph Hellwig , Andreas Dilger To: Jan Kara Return-path: Received: from mail04-md.ns.itscom.net ([175.177.155.114]:47836 "EHLO mail04-md.ns.itscom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751489AbaFCOgg (ORCPT ); Tue, 3 Jun 2014 10:36:36 -0400 In-Reply-To: <20140603090400.GB29219@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Jan Kara: > What I'm missing with this patch is some quantification of costs this > change has - i.e., it's surely going to cost us some performance. Can you > measure how much? I think measuring creation and deletion of lots of empty > files from 1, 2, 4, 8, .. NR_CPU processes (each process in a separate dir > to avoid contention on i_mutex) in tmpfs would make sense. Good point. I will try. > One correctness nit below as well. Thank you very much. J. R. Okajima