From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECE74C48BC2 for ; Sun, 27 Jun 2021 21:13:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 905EF61C17 for ; Sun, 27 Jun 2021 21:13:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 905EF61C17 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgraf.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxc5l-0004uE-KW for qemu-devel@archiver.kernel.org; Sun, 27 Jun 2021 17:13:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxc5B-00043e-TJ; Sun, 27 Jun 2021 17:12:49 -0400 Received: from mail.csgraf.de ([85.25.223.15]:33014 helo=zulu616.server4you.de) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxc5A-0005TC-7o; Sun, 27 Jun 2021 17:12:49 -0400 Received: from MacBook-Air.alex.local (dynamic-077-002-101-004.77.2.pool.telefonica.de [77.2.101.4]) by csgraf.de (Postfix) with ESMTPSA id B454C60801CD; Sun, 27 Jun 2021 23:12:45 +0200 (CEST) Subject: Re: [PATCH v8 18/19] arm: Enable Windows 10 trusted SMCCC boot call To: Peter Maydell References: <20210519202253.76782-1-agraf@csgraf.de> <20210519202253.76782-19-agraf@csgraf.de> From: Alexander Graf Message-ID: <23319027-1a44-d190-f70e-ed8a12cb37d9@csgraf.de> Date: Sun, 27 Jun 2021 23:12:45 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=85.25.223.15; envelope-from=agraf@csgraf.de; helo=zulu616.server4you.de X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.765, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Richard Henderson , QEMU Developers , Cameron Esfahani , Roman Bolshakov , qemu-arm , Frank Yang , Paolo Bonzini , Peter Collingbourne Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15.06.21 13:02, Peter Maydell wrote: > On Wed, 19 May 2021 at 21:23, Alexander Graf wrote: >> Windows 10 calls an SMCCC call via SMC unconditionally on boot. It lives >> in the trusted application call number space, but its purpose is unknown. >> >> In our current SMC implementation, we inject a UDEF for unknown SMC calls, >> including this one. However, Windows breaks on boot when we do this. Instead, >> let's return an error code. >> >> With this and -M virt,virtualization=on I can successfully boot the current >> Windows 10 Insider Preview in TCG. > > Same comments apply here and for patch 19. > > Either we can: > * find a spec for whatever this SMC ABI is and implement it > consistently across TCG, KVM and HVF > * find whether we're misimplementing whatever the SMCCC spec says > should happen for unknown SMC calls, and fix that bug > > But we're not adding random hacky workarounds for specific guest OSes. Let's move the conversation to 19/19 then. My take on this is that TCG is misinterpreting the SMCCC spec. Alex