From: David Howells <dhowells@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: dhowells@redhat.com, linux-xfs <linux-xfs@vger.kernel.org>,
Andreas Dilger <adilger@dilger.ca>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Eric Sandeen <sandeen@sandeen.net>,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfstests: Add first statx test
Date: Thu, 30 Mar 2017 20:31:58 +0100 [thread overview]
Message-ID: <23331.1490902318@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAOQ4uxiEzYvbAOdsJLOMKESUEVJuC57PPbYHvo-HtDZEiihb3A@mail.gmail.com>
Amir Goldstein <amir73il@gmail.com> wrote:
> > (2) Optionally compares the timestamps to see that they're sensibly
> > ordered with respect to the saved clock time[**] and each other.
>
> I suggest that instead of comparing to absolute timestamp value
> compare to a timestamp of the cmp file.
> This will also solve you the problem of gettimeofday() vs. kernel_time
> and will also open up the possibility of adding more interesting tests
> later on (e.g. make sure that mtime of file A >= atime of file B).
The whole point was to compare to a preceding time to make sure the timestamp
didn't go backwards - exactly as it can do:-/. Comparing to a reference file
doesn't prove that unless you've checked the reference file...
Making use of more of a reference file's timestamps could be useful for other
checks, though.
> > +420 other
>
> Since your test takes a few seconds, you should add it to auto, quick groups
> I don't know what this 'other' group is about.
I don't know either. Ask the 'new' script.
David
next prev parent reply other threads:[~2017-03-30 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-30 16:32 [PATCH] xfstests: Add first statx test David Howells
2017-03-30 18:36 ` Amir Goldstein
2017-03-30 18:45 ` Amir Goldstein
2017-03-31 9:14 ` David Howells
2017-03-30 19:31 ` David Howells [this message]
2017-03-31 10:19 ` Eryu Guan
2017-03-31 10:46 ` David Howells
2017-03-31 11:23 ` Eryu Guan
2017-03-31 12:05 ` David Howells
2017-03-31 12:13 ` Eryu Guan
2017-03-31 13:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23331.1490902318@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.