From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E753BC636CC for ; Mon, 13 Feb 2023 12:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbjBMMcs (ORCPT ); Mon, 13 Feb 2023 07:32:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229651AbjBMMcr (ORCPT ); Mon, 13 Feb 2023 07:32:47 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30A0676BD for ; Mon, 13 Feb 2023 04:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676291517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBZ75M4Yenbhu3faYe+Enj0ytlfjFVpVLTtBOwzZfDs=; b=F+CzapJB0MxfxqzNje4uo3y34CqOholLE3cPVchJOGchGR6b3djV2WkIGsFyKBir1e3mlk YIXKLrlSBm/uRdQSdsQsQHzkP6SPyeqcPTlKCDl/zH1FGgKfNIgzRSKyWtntbJPMXN2cHR xjRys24pS3DnRgZLRmvXCPZHlnJRwUk= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-604-33_k5AcVMVm_gLSzufCPvg-1; Mon, 13 Feb 2023 07:31:54 -0500 X-MC-Unique: 33_k5AcVMVm_gLSzufCPvg-1 Received: by mail-ej1-f69.google.com with SMTP id he34-20020a1709073da200b00887ced84328so7504517ejc.10 for ; Mon, 13 Feb 2023 04:31:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zBZ75M4Yenbhu3faYe+Enj0ytlfjFVpVLTtBOwzZfDs=; b=4gzk4u7JzkJ0A3tcyLsHg6xMVvOZBROhR4xuz/DDEqCnabj6msgEhYNMyM6LM/JWLz Lmgk/EVaASF9vst1v9MI3GFZ60lPWx18q9XdJFbcoQg1u2JhJ5itReYWDFOGe04kvxju Wqvz49xqR3B96rB2xC2oFPeA9fJhOYPjdc9hyLGPijG5R5ZqmakXMj0EzOTFvMSL81IU NDStXFZpw4Xt3iOVm+dXMKEyK9YB8MPqIKoe+Xh6NZizQRqZhZcdu3BtZydU/CLSZln8 +6BR9yrF2HRskR8jDOkdxnmvGFU6wRA/sEdzZ+LFD7zH/BzdrY2JggD4vc1wMEbsQgn4 w1jw== X-Gm-Message-State: AO0yUKUMouXRI+ioZdCgylHpbVTkCfrtaPgDa0eMBrikZ/0ePt1SGSCB J3QGVHUr2dq6wnpdlNrkq0WGYWufK2hX/tpn3RUBmbp8W2hA7DJVEzPz/syIqYQh/7IRWeuxufR 7tFPAAPBvi/YLQqoTWrUVlg== X-Received: by 2002:a17:906:4b0f:b0:886:ec6e:4c1 with SMTP id y15-20020a1709064b0f00b00886ec6e04c1mr23614042eju.59.1676291513085; Mon, 13 Feb 2023 04:31:53 -0800 (PST) X-Google-Smtp-Source: AK7set9p5DtT123vpTJkVDqIwud9hwK6Y1HV0n1Q3xwdJBhiSNzZJanBsXflTd+NNYTbVa0PedCLRA== X-Received: by 2002:a17:906:4b0f:b0:886:ec6e:4c1 with SMTP id y15-20020a1709064b0f00b00886ec6e04c1mr23614032eju.59.1676291512889; Mon, 13 Feb 2023 04:31:52 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id g25-20020a170906349900b0088519b92074sm6728969ejb.128.2023.02.13.04.31.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 04:31:52 -0800 (PST) Message-ID: <233344ca-5df1-abd9-6fb6-c04634f1b401@redhat.com> Date: Mon, 13 Feb 2023 13:31:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: RFI: Tablet mode support on HP Pro x360 435 G9 w/ AMD Ryzen 7 5825U Content-Language: en-US To: Carsten Hatger , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, Jorge Lopez Cc: mario.limonciello@amd.com, Shyam-sundar.S-k@amd.com References: From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Carsten, On 2/13/23 11:43, Carsten Hatger wrote: > Dear all, > > I'd like to have tablet mode support on my system, probably by means > an linux input device such as implemented in the intel platform > specific driver drivers/platform/x86/intel/vbtn.c [0] > > In the end I hope GNOME eventually to rotate the systems display and > to show some virtual keyboard (upon users request), cf. for [3] > > It appears there has already been a patch proposed by the chromium > team to support device PNP0C60 [1] but not merged to [5]. > > Since the system of interest is a HP Probook, there is already a > driver providing virtual buttons,namely hp-wmi [6]. However, the > driver loads probes and loads successfully but doesn't provide any > additional functionality plus some non critical errors on incorrect > ACPI method calls. > > I've noticed AMD has started to provide platform specific driver(s) > such as pmf [2]. To my knowledge there is no support for CEZANNE/green > sardine based systems (yet). > > What would be recommended practice and subsystem/folder to provide > such capability by means of a (platform specific) driver? At least the > CID PNP0C60 seems to be held by Microsoft [4] and thus be common to > both amd and intel platforms [4]. However, HID INT33D6 is held by > Intel and HID AMDI0081 by AMD. Yet I'm not quite sure if > iio-sensor-proxy [7] needs to be involved, too. The first thing to do here is to figure out which (ACPI) device is the right device to get the SW_TABLET_MODE events from on this device. Maybe Jorge (added to the Cc) can help with this ? Regards, Hans > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/intel/vbtn.c?h=v6.2-rc8 > [1] https://lore.kernel.org/lkml/1472628817-3145-1-git-send-email-wnhuang@google.com/ > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/amd/pmf?h=v6.2-rc8 > [3] https://gitlab.gnome.org/GNOME/mutter/-/issues/1760 > [4] https://learn.microsoft.com/en-us/windows-hardware/drivers/gpiobtn/button-implementation > [5] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/acpi/button.c?h=v6.2-rc8 > [6] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/platform/x86/hp/hp-wmi.c?h=v6.2-rc8 > [7] https://gitlab.freedesktop.org/hadess/iio-sensor-proxy/ >