From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36646C43460 for ; Tue, 6 Apr 2021 08:50:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0BAC61241 for ; Tue, 6 Apr 2021 08:50:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0BAC61241 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.105706.202173 (Exim 4.92) (envelope-from ) id 1lThPr-0008Jq-2G; Tue, 06 Apr 2021 08:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 105706.202173; Tue, 06 Apr 2021 08:50:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThPq-0008Jj-VP; Tue, 06 Apr 2021 08:50:30 +0000 Received: by outflank-mailman (input) for mailman id 105706; Tue, 06 Apr 2021 08:50:30 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lThPq-0008Je-CB for xen-devel@lists.xenproject.org; Tue, 06 Apr 2021 08:50:30 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e3d3f93f-2b6e-4e6c-a03b-ae529ff7086c; Tue, 06 Apr 2021 08:50:29 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C48E1AE06; Tue, 6 Apr 2021 08:50:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3d3f93f-2b6e-4e6c-a03b-ae529ff7086c X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617699028; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5u7mnATsOHEwtJcO87Og7ZVqkhZiBkCd9r/JcsIFqzw=; b=bbGRrpgfrWtcCoeepinsT0AQkm/Siwr6fgDqubRVJErNzhkwlV7OXM0SPYQPlwFfF5xbOj 2Nrztxp//upBl0e/SYOoViKWAebj5k8KuAq/JvCOqFzh2y86NSVI30jiHDH0kyDPEz2gPb kXOSAviWRvTZJjbcKKsEVB/QAvtEL9Q= To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu From: Jan Beulich Subject: [PATCH] rangeset: no need to use snprintf() Message-ID: <2338703b-3613-41c6-8ae6-387ba2869408@suse.com> Date: Tue, 6 Apr 2021 10:50:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit As of the conversion to safe_strcpy() years ago there has been no need anymore to use snprintf() to prevent storing a not-nul-terminated string. Signed-off-by: Jan Beulich --- a/xen/common/rangeset.c +++ b/xen/common/rangeset.c @@ -436,14 +436,7 @@ struct rangeset *rangeset_new( BUG_ON(flags & ~RANGESETF_prettyprint_hex); r->flags = flags; - if ( name != NULL ) - { - safe_strcpy(r->name, name); - } - else - { - snprintf(r->name, sizeof(r->name), "(no name)"); - } + safe_strcpy(r->name, name ?: "(no name)"); if ( (r->domain = d) != NULL ) {