From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Daniel P . Berrangé" <berrange@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 04/10] ui/gtk: remove unused code
Date: Tue, 12 May 2020 13:46:19 +0200 [thread overview]
Message-ID: <233896d9-de89-fa07-6709-96894f263945@redhat.com> (raw)
In-Reply-To: <20200510184304.9267-4-vr_qemu@t-online.de>
On 5/10/20 8:42 PM, Volker Rümelin wrote:
> This code was last used before commit 2ec78706d1 "ui: convert
> GTK and SDL1 frontends to keycodemapdb".
>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> ui/gtk.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 5de2a75691..c70bfc2be4 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -112,15 +112,6 @@
> # define VTE_CHECK_VERSION(a, b, c) 0
> #endif
>
> -/* Some older mingw versions lack this constant or have
> - * it conditionally defined */
> -#ifdef _WIN32
> -# ifndef MAPVK_VK_TO_VSC
> -# define MAPVK_VK_TO_VSC 0
> -# endif
> -#endif
> -
> -
> #define HOTKEY_MODIFIERS (GDK_CONTROL_MASK | GDK_MOD1_MASK)
>
> static const guint16 *keycode_map;
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-05-12 11:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 18:42 Patches for ui/gtk and ui/sdl Volker Rümelin
2020-05-10 18:42 ` [PATCH 01/10] ui/win32-kbd-hook: handle AltGr in a hook procedure Volker Rümelin
2020-05-12 11:21 ` Gerd Hoffmann
2020-05-10 18:42 ` [PATCH 02/10] ui/gtk: fix handling of AltGr key on Windows Volker Rümelin
2020-05-12 11:23 ` Gerd Hoffmann
2020-05-10 18:42 ` [PATCH 03/10] ui/gkt: release all keys on grab-broken-event Volker Rümelin
2020-05-12 11:28 ` Gerd Hoffmann
2020-05-10 18:42 ` [PATCH 04/10] ui/gtk: remove unused code Volker Rümelin
2020-05-12 11:46 ` Philippe Mathieu-Daudé [this message]
2020-05-10 18:42 ` [PATCH 05/10] ui/gtk: remove unused variable ignore_keys Volker Rümelin
2020-05-12 11:50 ` Philippe Mathieu-Daudé
2020-05-10 18:43 ` [PATCH 06/10] ui/sdl2: fix handling of AltGr key on Windows Volker Rümelin
2020-05-10 18:43 ` [PATCH 07/10] ui/sdl2: start in full screen with grab enabled Volker Rümelin
2020-05-10 18:43 ` [PATCH 08/10] ui/sdl2-input: use trace-events to debug key events Volker Rümelin
2020-05-12 11:51 ` Philippe Mathieu-Daudé
2020-05-10 18:43 ` [PATCH 09/10] ui/gtk: don't pass on win keys without keyboard grab Volker Rümelin
2020-05-12 11:30 ` Gerd Hoffmann
2020-05-10 18:43 ` [PATCH 10/10] ui/gtk: use native keyboard scancodes on Windows Volker Rümelin
2020-05-12 11:31 ` Daniel P. Berrangé
2020-05-14 20:46 ` Volker Rümelin
2020-05-11 7:56 ` Patches for ui/gtk and ui/sdl Howard Spoelstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=233896d9-de89-fa07-6709-96894f263945@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.