From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbdEUIZS (ORCPT ); Sun, 21 May 2017 04:25:18 -0400 Received: from mout.web.de ([212.227.17.12]:63390 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751532AbdEUIZQ (ORCPT ); Sun, 21 May 2017 04:25:16 -0400 Subject: [PATCH 1/3] zswap: Delete an error message for a failed memory allocation in zswap_pool_create() From: SF Markus Elfring To: linux-mm@kvack.org, Dan Streetman , Seth Jennings Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> Message-ID: <2345aabc-ae98-1d31-afba-40a02c5baf3d@users.sourceforge.net> Date: Sun, 21 May 2017 10:25:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:BojGPNKleNgWTBTSVDNEpU1Zi+KxVU8516lxMwIITZReRmr6yGq 3uL8vFL91LuikS/y2g6bzEsxx0Qn563mVvvNglGHjLCjGydX8xxM7Um+IAo8LyTpTYGNbxZ FImf92sECukHEYHGlrZBkB44hyXjirnKy0uoss5B8DamtbtJSFDtPcZ4Fyrr1ODgVURBACd 8Ptm70sYPMun3uHbkQEHQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/qAqtj1UxGc=:VHUhHQbGhKcg+5nKGeRYy9 n53O/wY1xG4C6J79fDJdyJpSMHrYHjFvnQRAmmSrPZe/tyU+190FCFhKOV07bfw9qVPCtGTiz bkwkE56e6PghjLNktLLRIfHp3SVbCzn1EclnWW9w3RrvtyXal/RaT31wt2SmtiZrNV1YajB3m r0Thr07/997OaI0BPw/jqoXjtR/DQPqlAjCkChCA1DRAm+lwkGXxg7J+HisPSCGP9/LytVRPK V1uOwjbynAWTt7i3YGquPt20cZnbX3cbC41dncNhPiylGfADMgIXJLasrl43N4LTdRZYTEqeo W5Ack8SvcZS1G+Qi7kJQFNqlx6PWrUzIhP7mCrGH7o4uOlxvFX/gxf5BbUff3CNnUUDxV03fN AljQh8eASdJIGPauyCQYDoby66yaLExXlOyE3YPh8A/S/YIClETtP8jpRGJz3SA9NPtT+eExK CA/3rvQTg639FfUo8xOVNguFlsSlkjH3WLlkd8zVaepENLEErOqb7cvJd4QUJPDU2r4nxGx0H FCYgvRXnr9/rvA03teWWasKJgmN0p4FqgKO+XohHWzzOmhADE1XYuUsthjayGSDqEclwecZG5 1kjufskfTsUGHFIfO/B7S0n8ifML/CHRw83pJfWSB0QNaLWzHvYKPRFpAhIbNX+ApItQHrZUv XW6EXWV/j1Uo2nrM0G919VdWSi9aTM7dQ+EUVYEsJZ7DyHbf5dW1Gb2ghU6bhKThRIwWY1CGg NzQWaSma+QzfaXmuD3wAcwJsfw7OQIpSDC384xz5ZZH1t9yRzEwmKP18Ab0zNLooWaTUlq0CS q+Bp2MU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 20 May 2017 22:33:21 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- mm/zswap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index eedc27894b10..18d8e87119a6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -518,7 +518,5 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) - if (!pool) { - pr_err("pool alloc failed\n"); + if (!pool) return NULL; - } /* unique name for each pool specifically required by zsmalloc */ snprintf(name, 38, "zswap%x", atomic_inc_return(&zswap_pools_count)); -- 2.13.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 21 May 2017 08:25:03 +0000 Subject: [PATCH 1/3] zswap: Delete an error message for a failed memory allocation in zswap_pool_create() Message-Id: <2345aabc-ae98-1d31-afba-40a02c5baf3d@users.sourceforge.net> List-Id: References: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> In-Reply-To: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-mm@kvack.org, Dan Streetman , Seth Jennings Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: Markus Elfring Date: Sat, 20 May 2017 22:33:21 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- mm/zswap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index eedc27894b10..18d8e87119a6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -518,7 +518,5 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) - if (!pool) { - pr_err("pool alloc failed\n"); + if (!pool) return NULL; - } /* unique name for each pool specifically required by zsmalloc */ snprintf(name, 38, "zswap%x", atomic_inc_return(&zswap_pools_count)); -- 2.13.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 08AF2280850 for ; Sun, 21 May 2017 04:25:09 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id 44so10960699wry.5 for ; Sun, 21 May 2017 01:25:08 -0700 (PDT) Received: from mout.web.de (mout.web.de. [212.227.17.12]) by mx.google.com with ESMTPS id w133si8948906wmd.124.2017.05.21.01.25.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2017 01:25:07 -0700 (PDT) Subject: [PATCH 1/3] zswap: Delete an error message for a failed memory allocation in zswap_pool_create() From: SF Markus Elfring References: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> Message-ID: <2345aabc-ae98-1d31-afba-40a02c5baf3d@users.sourceforge.net> Date: Sun, 21 May 2017 10:25:03 +0200 MIME-Version: 1.0 In-Reply-To: <05101843-91f6-3243-18ea-acac8e8ef6af@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: linux-mm@kvack.org, Dan Streetman , Seth Jennings Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: Markus Elfring Date: Sat, 20 May 2017 22:33:21 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- mm/zswap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index eedc27894b10..18d8e87119a6 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -518,7 +518,5 @@ static struct zswap_pool *zswap_pool_create(char *type, char *compressor) - if (!pool) { - pr_err("pool alloc failed\n"); + if (!pool) return NULL; - } /* unique name for each pool specifically required by zsmalloc */ snprintf(name, 38, "zswap%x", atomic_inc_return(&zswap_pools_count)); -- 2.13.0 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org