Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API

From: Thomas Monjalon <thomas@monjalon.net>
To: Jiawei Wang <jiaweiw@nvidia.com>
Cc: matan@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com,
	shahafs@nvidia.com, ferruh.yigit@intel.com,
	Wisam Jaddo <wisamm@nvidia.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>,
	Jasvinder Singh <jasvinder.singh@intel.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Ray Kinsella <mdr@ashroe.eu>,
	dev@dpdk.org, rasland@nvidia.com, roniba@nvidia.com,
	asafp@nvidia.com, Li Zhang <lizh@nvidia.com>,
	Haifei Luo <haifeil@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API
Date: Wed, 21 Apr 2021 21:43:45 +0200	[thread overview]
Message-ID: <23466981.2A24ZmSzZz@thomas> (raw)
In-Reply-To: <1618927490-229267-2-git-send-email-jiaweiw@nvidia.com>

20/04/2021 16:04, Jiawei Wang:
> --- a/doc/guides/rel_notes/release_21_05.rst
> +++ b/doc/guides/rel_notes/release_21_05.rst
> @@ -244,6 +244,27 @@ New Features
>    * Added support for crypto adapter forward mode in octeontx2 event and crypto
>      device driver.
>  
> +  * deleted the port meter policer action command .
> +    ``set port meter policer action (port_id) (mtr_id) (action_mask) ...``
> +  * Added command to create meter policy.
> +    ``add port meter policy (port_id) (policy_id) g_actions {action} end y_actions {action} end r_actions {action} end``
> +  * Added command to delete meter policy.
> +    ``del port meter policy (port_id) (policy_id)``
> +
> +* **Updated meter API.**
> +
> +  * ethdev: Deleted meter policer API to support policy API.
> +    ``rte_mtr_policer_actions_update()``
> +  * ethdev: Added meter API to support pre-defined policy, rte_flow action list per color.
> +    ``rte_mtr_meter_policy_add()``, ``rte_mtr_meter_policy_delete()`` and
> +    ``rte_mtr_create_with_policy()``
> +  * ethdev: Removed rte_mtr_policer_action from rte_mtr_params structures.
> +  * ethdev: Added rte_mtr_meter_policy_params structures to support policy API.
> +  * ethdev: Added meter_policy_id into rte_mtr_params structures.
> +  * ethdev: Removed policer_action_recolor_supported and policer_action_drop_supported from rte_mtr_capabilities structures.
> +  * ethdev: Added meter_policy_n_max into rte_mtr_capabilities structures.
> +  * ethdev: Added RTE_FLOW_ACTION_TYPE_METER_COLOR in enum rte_flow_action_type.
> +  * ethdev: Added RTE_MTR_ERROR_TYPE_METER_POLICY_ID and RTE_MTR_ERROR_TYPE_METER_POLICY_ID into rte_mtr_error_type.

What is this garbage?
Wrong place, wrong format, wrong everything.

I would like to see a bit more attention to details,
especially in a rush to close the -rc1.