From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v5 03/15] libxl_qmp: Implement fd callback and read data Date: Mon, 15 Oct 2018 15:04:59 +0100 Message-ID: <23492.40587.959437.283342@mariner.uk.xensource.com> References: <20180907151104.32306-1-anthony.perard@citrix.com> <20180907151104.32306-4-anthony.perard@citrix.com> <23486.7932.781238.747508@mariner.uk.xensource.com> <20181011140604.GH1331@perard.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gC3UX-0002DR-9p for xen-devel@lists.xenproject.org; Mon, 15 Oct 2018 14:05:05 +0000 In-Reply-To: <20181011140604.GH1331@perard.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu List-Id: xen-devel@lists.xenproject.org QW50aG9ueSBQRVJBUkQgd3JpdGVzICgiUmU6IFtQQVRDSCB2NSAwMy8xNV0gbGlieGxfcW1wOiBJ bXBsZW1lbnQgZmQgY2FsbGJhY2sgYW5kIHJlYWQgZGF0YSIpOgo+IE9uIFdlZCwgT2N0IDEwLCAy MDE4IGF0IDA0OjQ3OjA4UE0gKzAxMDAsIElhbiBKYWNrc29uIHdyb3RlOgo+ID4gTGluZXMgdG9v IGxvbmcgYWdhaW4uICAoSSB3aWxsIHN0b3AgY29tcGxhaW5pbmcgYWJvdXQgdGhpcyBub3cgYnV0 IGNhbgo+ID4geW91IHBsZWFlIGZpeCBpdCB0aHJvdWdob3V0PykKPiAKPiBCdXQgdGhlIGNvbW1l bnQgaXMgbGVzcyB0aGFuIDcwY2hyIGxvbmcsIGFuZCB0aGUgbmV4dCBsaW5lIGZvbGxvdyB0aGUK PiBjb2Rpbmcgc3R5bGUsIHdoaWNoIGlzICJMaW5lcyBhcmUgbGltaXRlZCB0byA3NS04MCBjaGFy YWN0ZXJzLiIsIGFuZAo+IEknbSBwcmV0dHkgc3VyZSB0aGF0IDc3IGlzIGxlc3MgdGhhdCA3NS04 MCEKCkl0J3MgbGVzcyB0aGFuIDgwIGJ1dCBub3QgbGVzcyB0aGFuIDc1LiAgSSBoYXZlIHNlbnQg YSBwYXRjaCB0byBjaGFuZ2UKdGhpcyBpbiBDT0RJTkdfU1RZTEUuICBXZSBjYW4gYXJndWUgYWJv dXQgdGhpcyBpbiB0aGF0IG90aGVyIHRocmVhZC4KKEluIHByYWN0aWNhbCB0ZXJtcyB0aGVzZSBs aW5lcyBkbyByZXN1bHQgaW4gd3JhcCBkYW1hZ2Ugb24gbXkKc2NyZWVuLCB3aGljaCBtYWtlcyBp dCBzaWduaWZpY2FudGx5IGhhcmRlciB0byByZWFkLCBzbyBJJ20gbm90IGp1c3QKcXVpYmJsaW5n IGZvciBubyByZWFzb24uKQoKPiA+IE5vLCB5b3UgbmVlZCB0byBnbyByb3VuZCBhZ2Fpbi4gIEkn bSBhZnJhaWQgdGhlIHdob2xlIG9mIHRoaXMgZnVuY3Rpb24KPiA+IG5lZWRzIHRvIGJlIGluIGEg bG9vcC4gIFRoaXMgaXMgYmVjYXVzZSB5b3UgYXJlIG5vdCBndWFyYW50ZWVkIHRoYXQKPiA+IHlv dSB3aWxsIGdldCBtb3JlIHRoYW4gb25lIGNhbGwgdG8geW91ciByZWFkYWJsZSBjYWxsYmFjayBw ZXIKPiA+IHRyYW5zaXRpb24gZnJvbSBub3QtcmVhZGFibGUgdG8gcmVhZGFibGUuCj4gCj4gSSd2 ZSBkaWQgaXQgd2l0aG91dCBhIGxvb3AgYmVjYXVzZSBQT0xMSU4gbWVhbnMgImRhdGEgbWF5IGJl IHJlYWQKPiB3aXRob3V0IGJsb2NraW5nIiwgYW5kIEkgY2FuJ3QgZmluZCBhbnl0aGluZyBzcGVh a2luZyBhYm91dCBhIHJlbGF0aW9uCj4gd2l0aCB0cmFuc2l0aW9uIGZyb20gb25lIHN0YXRlIHRv IHRoZSBvdGhlci4KCllvdSdyZSByaWdodCB0aGF0IHRoaXMgaXMgbm90IHByb3Blcmx5IGRvY3Vt ZW50ZWQuICBZb3UnbGwgc2VlIHRoYXQgSQpoYXZlIHNlbnQgYSBwYXRjaCB0byBmaXggdGhhdC4K CkluIHByYWN0aWNlLCBpZiB0aGUgYXBwbGljYXRpb24gaGFzIGl0cyBvd24gZXZlbnQgbG9vcCB3 aGljaCB1c2VzCmVwb2xsIGFuZCBFUE9MTEVUIHRoZW4gaW5kZWVkIHlvdSdsbCBvbmx5IGdldCB0 aGUgY2FsbGJhY2sgb25jZSBwZXIKdHJhbnNpdGlvbiBmcm9tIHVucmVhZHkgdG8gcmVhZHkuICBT b21lIGV2ZW50LWxpa2UgZGVzY3JpcHRvcgpyZWFkaW5lc3MgcmVwb3J0aW5nIG1lY2hhbmlzbXMg c3VwcG9ydCBvbmx5IHRob3NlIHNlbWFudGljcy4KCj4gPiA+ICsgICAgICAgIGFzc2VydChlcnJu byk7Cj4gPiA+ICsgICAgICAgIGlmIChlcnJubyA9PSBFV09VTERCTE9DSykKPiA+ID4gKyAgICAg ICAgICAgIHJldHVybiAwOwo+ID4gCj4gPiBBbmQgYWdhaW4uCj4gCj4gU3VyZWx5IGhlcmUgSSBu ZWVkIHRvIHJldHVybiBvbiBFV09VTERCTE9DSy4gVGhlIGZkIGlzIG9idmlvdXNseSBpbgo+IG5v bi1yZWFkYWJsZSBzdGF0ZSwgc28gdGhlcmUgaXMgZ29pbmcgdG8gYmUgYSB0cmFuc2l0aW9uLgoK RXJyLCBzb3JyeSwgeWVzLgoKPiA+ID4gKyAgICBpZiAociA9PSAwKSB7Cj4gPiA+ICsgICAgICAg IExPR0QoRVJST1IsIGV2LT5kb21pZCwgIk5vIGRhdGEgcmVhZCBvbiBRTVAgc29ja2V0Iik7Cj4g PiAKPiA+IFlvdSBtZWFuICJ1bmV4cGVjdGVkIEVPRiIgbm90ICJubyBkYXRhIHJlYWQiLiAgTm9y bWFsbHkgdGhpcyB3b3VsZAo+ID4gbWVhbiB0aGF0IHFlbXUgZGllZCBvciBjcmFzaGVkLgo+ID4g Cj4gPiA+ICsgICAgICAgIHJldHVybiAwOwo+ID4gCj4gPiBFcnIsIGFuZCB0aGVuIHRoaXMgbmVl ZHMgdG8gYmUgaGFuZGxlZCBhcyBhbiBlcnJvciwgbm90IHNpbXBseQo+ID4gaWdub3JlZC4gIElm IGl0IGhhcHBlbnMsIGl0IHdpbGwga2VlcCBoYXBwZW5pbmcuCj4gCj4gSSB0aGluayBJJ20gYmVl biBsYXp5IGFuZCBoYXZlIGp1c3QgbGV0IHRoaXMgZXJyb3IgYmVlbiBoYW5kbGUgaW4gdGhlCj4g bmV4dCBldmVudCB3aGVyZSBQT0xMSFVQIHNob3VsZCBiZSBzZXQuIEkgY2FuIHRyeSB0byBoYW5k bGUgdGhpcyBlcnJvcgo+IGJldHRlciBoZXJlLgoKSSB0aGluayB5b3UgbWlnaHQgbm90IGdldCBQ T0xMSFVQLiAgRm9yIGV4YW1wbGUgaWYgcWVtdSBkaWQKc2h1dGRvd24oLFNIVVRfV1IpOyAgVGhh bmtzLgoKPiA+IEhybS4gIEkgcmVhbGlzZSB0aGlzIGlzIGdvaW5nIHRvIGJlIGFubm95aW5nLCBi dXQgSSB0aGluayBJIHNob3VsZAo+ID4gcHJvYmFibHkgc3RvcCBub3cgYmVjYXVzZSBvZiB0aGUg bGFjayBvZiB4eHgncyBtZWFucyBpdCdzIGhhcmQgZm9yIG1lCj4gPiB0byByZXZpZXcuCi4uLgo+ IFRoZXJlIGlzIG9uZSBwYXRjaCB0aGF0IGNhbiBiZSByZXZpZXdlZCBzZXBhcmF0bHksIGFuZCB0 aGVuIHllcywgeW91Cj4gbmVlZCB1cCB0byAnbGlieGxfcW1wOiBSZXNwb25kIHRvIFFNUCBncmVl dGluZycuIFRoYXQgZ2l2ZSB1czoKPiAKPiBwaWNrICAgICAgbGlieGxfcW1wOiBTZXBhcmF0ZSBR TVAgbWVzc2FnZSBnZW5lcmF0aW9uIGZyb20gcW1wX3NlbmRfcHJlcGFyZQo+IHBpY2sgICAgICBs aWJ4bF9xbXA6IENvbm5lY3QgdG8gUU1QIHNvY2tldAo+IHNxdWFzaCAgICBsaWJ4bF9xbXA6IElt cGxlbWVudCBmZCBjYWxsYmFjayBhbmQgcmVhZCBkYXRhCj4gc3F1YXNoICAgIGxpYnhsX3FtcDog UGFyc2UgSlNPTiBpbnB1dCBmcm9tIFFNUAo+IHNxdWFzaCAgICBsaWJ4bF9xbXA6IFByZXBhcmUg dGhlIGNvbW1hbmQgdG8gYmUgc2VudAo+IHNxdWFzaCAgICBsaWJ4bF9xbXA6IEhhbmRsZSB3cml0 ZSB0byBRTVAgc29ja2V0Cj4gc3F1YXNoICAgIGxpYnhsX3FtcDogSGFuZGxlIG1lc3NhZ2VzIGZy b20gUUVNVQo+IHNxdWFzaCAgICBsaWJ4bF9xbXA6IFJlc3BvbmQgdG8gUU1QIGdyZWV0aW5nCj4g Cj4gVGhhdCBnaXZlIHVzIGEgcGF0Y2ggd2l0aCBvbmx5IDUwMCBpbnNlcnRpb25zLgoKSSB3aWxs IGRvIHRoYXQgYW5kIHBhdGNoYm9tYiBteXNlbGYgd2l0aCB0aGUgcmVzdWx0aW5nIGVtYWlsIGFu ZCB0aGVuCnJlcGx5IGFzIGlmIHlvdSBoYWQgc2VudCBpdCB0byBtZS4KClRoYW5rcywKSWFuLgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA==