From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v5 11/15] libxl_dm: Pre-open QMP socket for QEMU Date: Tue, 16 Oct 2018 15:11:03 +0100 Message-ID: <23493.61815.315512.256184@mariner.uk.xensource.com> References: <20180907151104.32306-1-anthony.perard@citrix.com> <20180907151104.32306-12-anthony.perard@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gCQL5-0001C4-T2 for xen-devel@lists.xenproject.org; Tue, 16 Oct 2018 14:28:51 +0000 In-Reply-To: <20180907151104.32306-12-anthony.perard@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu List-Id: xen-devel@lists.xenproject.org QW50aG9ueSBQRVJBUkQgd3JpdGVzICgiW1BBVENIIHY1IDExLzE1XSBsaWJ4bF9kbTogUHJlLW9w ZW4gUU1QIHNvY2tldCBmb3IgUUVNVSIpOgo+IFdoZW4gc3RhcnRpbmcgUUVNVSB3aXRoIGRtX3Jl c3RyaWN0PTEsIHByZS1vcGVuIHRoZSBRTVAgc29ja2V0IGJlZm9yZQo+IGV4ZWMgUUVNVS4gVGhh dCBzb2NrZXQgd2lsbCBiZSB1c2VmdWxsIHRvIGZpbmRvdXQgaWYgUUVNVSBpcyByZWFkeSwgYW5k Cj4gcHJlLW9wZW5pbmcgaXQgbWVhbnMgdGhhdCBsaWJ4bCBjYW4gY29ubmVjdCB0byBpdCB3aXRo b3V0IHdhaXRpbmcgZm9yCj4gUUVNVSB0byBjcmVhdGUgaXQuCgpUaGFua3MgZm9yIHRoaXMuICBJ IGhhdmUgb25seSB0aW55IGNvbW1lbnRzIGFib3V0IHRoaXMuICAoSSBjaGVja2VkIHRoZQplcnJv ciBoYW5kbGluZyBwYXR0ZXJucyBhbmQgdGhleSBzZWVtZWQgY29udmVudGlvbmFsIGFuZCBjb3Jy ZWN0LikKCkZBT0QsIGFuZCBJIHRoaW5rIHRoaXMgaXMgbm90IGVudGlyZWx5IGNsZWFyIGZyb20g eW91ciBjb21taXQgbWVzc2FnZToKCkFJVUkgdGhlIG92ZXJhbGwgZWZmZWN0IG9mIHRoaXMgcGF0 Y2ggaXMgbm90IHRvIGVuYWJsZSBhbnkgbmV3CmZ1bmN0aW9uYWxpdHkgYW5kIG5vdCB0byBmaXgg YW55IGJ1Zy4gIEl0IGp1c3QgbW92ZXMgdGhlIHFlbXUgc29ja2V0CmNyZWF0aW9uIGZyb20gcWVt dSB0byBsaWJ4bCwgYnV0IG5vdGhpbmcgaW4gbGlieGwgcmVsaWVzIG9uIHRoaXMgeWV0LgoKQW0g SSByaWdodCA/ICBJZiBzbyBwbGVhc2UgcHV0IHRoYXQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlLgoK PiArc3RhdGljIGludCBsaWJ4bF9fcHJlX29wZW5fcW1wX3NvY2tldChsaWJ4bF9fZ2MgKmdjLCBp bnQgZG9taWQsIGludCAqZmRfcikKLi4uCj4gKyAgICBpZiAoYmluZChmZCwgKHN0cnVjdCBzb2Nr YWRkciopICZ1biwgc2l6ZW9mKHVuKSkgPCAwKSB7Cj4gKyAgICAgICAgTE9HRUQoRVJST1IsIGRv bWlkLCAiYmluZCgnJXMnKSBmYWlsZWQiLCBwYXRoKTsKPiArICAgICAgICByYyA9IEVSUk9SX0ZB SUw7Cj4gKyAgICAgICAgZ290byBvdXQ7Cj4gKyAgICB9CgpGcm9tIGxpYnhsL0NPRElOR19TVFlM RToKCiAgICAqIEZ1bmN0aW9uIGNhbGxzIHdoaWNoIG1pZ2h0IGZhaWwgKGllIG1vc3QgZnVuY3Rp b24gY2FsbHMpIGFyZQogICAgICBoYW5kbGVkIGJ5IHB1dHRpbmcgdGhlIHJldHVybi9zdGF0dXMg dmFsdWUgaW50byBhIHZhcmlhYmxlLCBhbmQKICAgICAgdGhlbiBjaGVja2luZyBpdCBpbiBhIHNl cGFyYXRlIHN0YXRlbWVudDoKICAgICAgICAgICAgICBjaGFyICpkb21wYXRoID0gbGlieGxfX3hz X2dldF9kb21wYXRoKGdjLCBibC0+ZG9taWQpOwogICAgICAgICAgICAgIGlmICghZG9tcGF0aCkg eyByYyA9IEVSUk9SX0ZBSUw7IGdvdG8gb3V0OyB9CgpUaGlzIG5lZWRzIGNoYW5naW5nIHRocm91 Z2hvdXQgdGhlIHNlcmllcywgSSdtIGFmcmFpZC4KCj4gIHN0YXRpYyBpbnQgbGlieGxfX2J1aWxk X2RldmljZV9tb2RlbF9hcmdzX25ldyhsaWJ4bF9fZ2MgKmdjLAo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqZG0sIGludCBndWVzdF9kb21pZCwK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGxpYnhsX2Rv bWFpbl9jb25maWcgKmd1ZXN0X2NvbmZpZywKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNoYXIgKioqYXJncywgY2hhciAqKiplbnZzLAo+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgbGlieGxfX2RvbWFpbl9idWlsZF9zdGF0 ZSAqc3RhdGUsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnQg KmRtX3N0YXRlX2ZkKQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aW50ICpkbV9zdGF0ZV9mZCwgaW50ICpkbV9tb25pdG9yX2ZkKQouLi4KPiAtICAgICAgICAgICAg ICAgICAgICAgR0NTUFJJTlRGKCJzb2NrZXQsaWQ9bGlieGwtY21kLCIKPiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJwYXRoPSVzLHNlcnZlcixub3dhaXQiLAo+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbGlieGxfX3FlbXVfcW1wX3BhdGgoZ2MsIGd1ZXN0X2RvbWlk KSkpOwo+ICsgICAgLyogSWYgd2UgaGF2ZSB0byB1c2UgZG1fcmVzdHJpY3QsIFFFTVUgbmVlZCB0 byBiZSBuZXcgZW5vdWdoIGFuZCB3aWxsIGhhdmUKCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBuZWVkcwoKPiArICAgICAqIHRoZSBuZXcgaW50ZXJmYWNlIHdo ZXJlIHdlIGNhbiBwcmUtb3BlbiB0aGUgUU1QIHNvY2tldC4gKi8KPiArICAgIGlmIChsaWJ4bF9k ZWZib29sX3ZhbChiX2luZm8tPmRtX3Jlc3RyaWN0KSkKPiArICAgIHsKCk1pc3BsYWNlZCBicmFj ZSwgc2hvdWxkIGJlIGVuZCBvZiB0aGUgcHJldmlvdXMgbGluZS4KCj4gQEAgLTE3MzksMTAgKzE3 OTYsMTEgQEAgc3RhdGljIGludCBsaWJ4bF9fYnVpbGRfZGV2aWNlX21vZGVsX2FyZ3MobGlieGxf X2djICpnYywKPiAgICAgIGNhc2UgTElCWExfREVWSUNFX01PREVMX1ZFUlNJT05fUUVNVV9YRU46 Cj4gICAgICAgICAgYXNzZXJ0KGRtX3N0YXRlX2ZkICE9IE5VTEwpOwo+ICAgICAgICAgIGFzc2Vy dCgqZG1fc3RhdGVfZmQgPCAwKTsKPiArICAgICAgICBhc3NlcnQoZG1fbW9uaXRvcl9mZCAhPSBO VUxMKTsKCkpvbGx5IGdvb2QuICBCdXQgSSB3b3VsZCBiZSB0ZW1wdGVkIHRvIG1vdmUgb3IgY29w eSB0aGlzIGFzc2VydCB0bwpsaWJ4bF9fcHJlX29wZW5fcW1wX3NvY2tldC4gIFdoYXQgZG8geW91 IHRoaW5rID8KCj4gICAgICByZXQgPSBsaWJ4bF9fYnVpbGRfZGV2aWNlX21vZGVsX2FyZ3MoZ2Ms ICJzdHViZG9tLWRtIiwgZ3Vlc3RfZG9taWQsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ3Vlc3RfY29uZmlnLCAmYXJncywgTlVMTCwKPiAtICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkX3N0YXRlLCBOVUxMKTsKPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkX3N0YXRlLCBOVUxMLCBOVUxMKTsKCkRp ZCB5b3UgY29uc2lkZXIgYWRkaW5nIGRtX21vbml0b3JfZmQgdG8gZF9zdGF0ZSA/CgpJYW4uCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwg bWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3Rz LnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs