From: Leonard Crestez <leonard.crestez@nxp.com>
To: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Duan <fugang.duan@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator
Date: Wed, 3 Oct 2018 11:49:32 +0000 [thread overview]
Message-ID: <234ccbfccc26701bd0b9fd9cf2ffb5ad2414adec.camel@nxp.com> (raw)
In-Reply-To: <CACRpkdajdjLUEwv8ABSBuy4dVMXqrUfxVDmu55aEiRAK877urQ@mail.gmail.com>
On Tue, 2018-10-02 at 21:56 +0200, Linus Walleij wrote:
> On Tue, Oct 2, 2018 at 8:37 PM Leonard Crestez <
> leonard.crestez@nxp.com> wrote:
>
> > This issue was exposed by commit efdfeb079cc3 ("regulator: fixed:
> > Convert to use GPIO descriptor only") which causes the "gpios"
> > property
> > to also be parsed. Before that commit the "gpios" property had no
> > effect and PHY reset was only handled in the bootloader.
>
> Wow that was a very interesting one.
> Turning over these stones sometimes expose the weirdest
> things.
>
> This is one of the reasons why we need formal validation of
> DTS files: things look OK to the human eye and get merged
> but they are just syntactically wrong.
>
> I guess I could hack to make "gpios" be ignored by the
> regulator GPIO quirks in gpiolib, but I take it you probably
> prefer to fix up the real issue like this.
Maybe you could document in fixed-regulator bindings that it now
supports the standard "gpios" property as well? There still seems to be
a restriction that the list must contain a single element.
Anyway, what my patch fixes is a board-specific issue which exists even
outside your patch: the enet phy regulator never worked as expected.
--
Regards,
Leonard
next prev parent reply other threads:[~2018-10-03 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 18:37 [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator Leonard Crestez
2018-10-02 19:56 ` Linus Walleij
2018-10-03 11:49 ` Leonard Crestez [this message]
2018-10-04 9:02 ` Linus Walleij
2018-10-03 2:25 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=234ccbfccc26701bd0b9fd9cf2ffb5ad2414adec.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.