From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: berrange@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
pbonzini@redhat.com, stefanha@redhat.com,
"Cleber Rosa" <crosa@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Kamil Rytarowski" <kamil@netbsd.org>
Subject: Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair
Date: Mon, 18 Sep 2017 10:17:21 -0500 [thread overview]
Message-ID: <234e0e32-0f16-c621-6062-a2ee140efdf6@redhat.com> (raw)
In-Reply-To: <20170918024402.3265-5-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
On 09/17/2017 09:43 PM, Fam Zheng wrote:
> This will be used by setup test user ssh.
Shouldn't the commit message have more details about WHY we are checking
in a private key? The conversation last time included useful gems such as:
Some guests require the key to exist prior to provisioning the guest,
and reusing a pre-built key avoids consuming entropy every time the
testsuite is run. Because the private key is well-known, care must be
taken to use the key ONLY in situations that cannot be compromised by
external network clients.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/keys/id_rsa | 27 +++++++++++++++++++++++++++
> tests/keys/id_rsa.pub | 1 +
> 2 files changed, 28 insertions(+)
> create mode 100644 tests/keys/id_rsa
> create mode 100644 tests/keys/id_rsa.pub
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-09-18 15:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 2:43 [Qemu-devel] [PATCH v8 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 01/13] gitignore: Ignore vm test images Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 02/13] qemu.py: Add "wait()" method Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 03/13] scripts: Add archive-source.sh Fam Zheng
2017-09-18 9:26 ` Alex Bennée
2017-09-18 15:14 ` Eric Blake
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair Fam Zheng
2017-09-18 15:17 ` Eric Blake [this message]
2017-09-19 2:10 ` Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 05/13] tests: Add vm test lib Fam Zheng
2017-09-18 10:14 ` Alex Bennée
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 06/13] tests: Add ubuntu.i386 image Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 07/13] tests: Add FreeBSD image Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 08/13] tests: Add NetBSD image Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 09/13] tests: Add OpenBSD image Fam Zheng
2017-09-18 2:43 ` [Qemu-devel] [PATCH v8 10/13] Makefile: Add rules to run vm tests Fam Zheng
2017-09-18 11:42 ` Alex Bennée
2017-09-18 2:44 ` [Qemu-devel] [PATCH v8 11/13] MAINTAINERS: Add tests/vm entry Fam Zheng
2017-09-18 2:44 ` [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests Fam Zheng
2017-09-18 9:43 ` Alex Bennée
2017-09-18 12:03 ` Fam Zheng
2017-09-18 15:20 ` Eric Blake
2017-09-18 2:44 ` [Qemu-devel] [PATCH v8 13/13] docker: Use archive-source.py Fam Zheng
2017-09-18 9:29 ` Alex Bennée
2017-09-18 3:09 ` [Qemu-devel] [PATCH v8 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux) no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=234e0e32-0f16-c621-6062-a2ee140efdf6@redhat.com \
--to=eblake@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=kamil@netbsd.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.