From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Girdwood, Liam" <lrg@ti.com>,
"Lopez Cruz, Misael" <misael.lopez@ti.com>
Subject: Re: [PATCH v3 2/3] ASoC: soc-dapm: API to attach DAPM_SUPPLY to be used for dai
Date: Tue, 06 Sep 2011 13:21:56 +0300 [thread overview]
Message-ID: <2352586.fDPvRLFK0h@barack> (raw)
In-Reply-To: <20110903063119.GB6556@sirena.org.uk>
On Saturday 03 September 2011 07:31:19 Mark Brown wrote:
> > The sequence I'm looking for is:
> > 1. pcm_trigger: stop DMA
> > 2. DAPM sequence starts
> > 3. DAC is turned off on the codec side
> > 4. OMAP4 McPDM can be stopped - stop it
> > 5. DAPM finishes up
> > 6. codec can be turned off
>
> Actually I think this is fine with my suggestion so long as you make the
> CODEC SYSCLK visible to DAPM and have the machine driver turn it off at
> some later point in the shutdown process (eg, in shutdown()). That way
> the data paths will still be torn down by DAPM immediately but SYSCLK
> will still be generated.
I need to think about this.
Not sure how it will affect our system, if we do not have pmdown_time in the
future, when we add full ABE support.
As a side note: I have found an issue with my earlier proposal (DAPM_SUPPLY
attached to the codec's DAC/ADC): I can end up turning off the host side McPDM
during audio activity (by muting the outputs/inputs runtime). It has the side
effect of not recovering :o (also DMA stops, since the dai is stopped)
I'll get back to you on this soon (probably with a patch).
--
Péter
next prev parent reply other threads:[~2011-09-06 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 13:33 [PATCH v3 0/3] ASoC: omap-mcpdm: New McPDM driver Peter Ujfalusi
2011-08-26 13:33 ` [PATCH v3 1/3] ASoC: DAPM: Add private data pointer for DAPM widget Peter Ujfalusi
2011-08-26 13:33 ` [PATCH v3 2/3] ASoC: soc-dapm: API to attach DAPM_SUPPLY to be used for dai Peter Ujfalusi
2011-08-26 19:05 ` Mark Brown
2011-08-29 8:22 ` Péter Ujfalusi
2011-08-29 9:16 ` Mark Brown
2011-08-29 11:41 ` Péter Ujfalusi
2011-09-03 6:31 ` Mark Brown
2011-09-06 10:21 ` Péter Ujfalusi [this message]
2011-09-06 15:09 ` Mark Brown
2011-08-26 13:33 ` [PATCH v3 3/3] ASoC: omap-mcpdm: Replace legacy driver Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2352586.fDPvRLFK0h@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.