From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1 0/9] mempool: prepare to add bucket driver Date: Tue, 20 Mar 2018 12:04:54 +0100 Message-ID: <2352592.k8uHYFHRCe@xps> References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> <20180319170322.webhsihrpdcfns4y@platinum> <5f02489c-9bd8-3265-4b55-9feb88d22cb5@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Olivier Matz , dev@dpdk.org, Santosh Shukla , Jerin Jacob , Hemant Agrawal , Shreyansh Jain To: Andrew Rybchenko Return-path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 046B15F18 for ; Tue, 20 Mar 2018 12:05:09 +0100 (CET) In-Reply-To: <5f02489c-9bd8-3265-4b55-9feb88d22cb5@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/03/2018 11:09, Andrew Rybchenko: > On 03/19/2018 08:03 PM, Olivier Matz wrote: > >> I've kept rte_mempool_populate_iova_tab() intact since it seems to > >> be not directly related XMEM API functions. > > The function rte_mempool_populate_iova_tab() (actually, it was > > rte_mempool_populate_phys_tab()) was introduced to support XMEM > > API. In my opinion, it can also be deprecated. > > CC Thomas > > Definitely OK for me. It is not listed in deprecation notice included in > 18.02, > but I think it is OK to deprecate it in 18.05 (since we're not removing, > but just deprecating it). Yes it is OK to deprecate this function in addition to other mempool ones already listed as planned to be deprecated.