From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998AbdBHPNB (ORCPT ); Wed, 8 Feb 2017 10:13:01 -0500 Received: from webbox1416.server-home.net ([77.236.96.61]:60967 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbdBHPM6 (ORCPT ); Wed, 8 Feb 2017 10:12:58 -0500 From: Alexander Stein To: Mathias Nyman Cc: Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Wang, Yu" , "Li, Guanglei" , "Wu, Hao" Subject: Re: [PATCH v2 1/1] xhci: add USB2 test mode support Date: Wed, 08 Feb 2017 16:10:22 +0100 Message-ID: <2354219.ccAkvreDgs@ws-stein> User-Agent: KMail/4.14.10 (Linux/4.9.5-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <589B2889.3050708@linux.intel.com> References: <20170208134444.18369-1-alexander.stein@systec-electronic.com> <589B2889.3050708@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 08 February 2017 16:17:45, Mathias Nyman wrote: > On 08.02.2017 15:44, Alexander Stein wrote: > > This patch adds support for USB2 test mode (Test_J, Test_K, > > Test_SE0_NAK and Test_Packet) per XHCI spec 4.19.6. > > > > USB2 test mode is a required hardware feature for system integrators > > validating their hardware according to USB spec, regarding signal > > strength and stuff. It is purely a hardware test feature. > > > > Usually you need an oscilloscope and have to enable those test modes on > > the hardware. This will send some specific test patterns on D+/D-. There > > is no report available (in Linux itself) as it is purely externally > > visible. Regular USB usage is not possible at that time. > > Anyone (well access to e.g. /dev/bus/usb/001/001 provided) can use it by > > sending appropriate USB_PORT_FEAT_TEST requests to the hub. > > The same feature for ehci based hosts is already available at > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drive > > rs/usb/host/ehci-hub.c#n1267 > > > > Signed-off-by: "Wang, Yu" > > Signed-off-by: "Li, Guanglei" > > Signed-off-by: "Wu, Hao" > > Signed-off-by: Alexander Stein > > --- > > I think there's a reworked series of this feature already posted at: > > http://marc.info/?l=linux-usb&m=148050258916147&w=2 > > But this change log is now better > I was thinking about adding that to 4.12 Interesting, I was not aware of that. This patchset seems better and cleaner than my patch. It even powers off all USB3 _and_ USB2 ports. In my patch only USB3 ports are powered off. Also TEST_FORCE_EN seems to be supported. Feel free to take that series and use my commit message as appropriate. Best regards, Alexader -- Dipl.-Inf. Alexander Stein SYS TEC electronic GmbH alexander.stein@systec-electronic.com Legal and Commercial Address: Am Windrad 2 08468 Heinsdorfergrund Germany Office: +49 (0) 3765 38600-0 Fax: +49 (0) 3765 38600-4100 Managing Directors: Director Technology/CEO: Dipl.-Phys. Siegmar Schmidt; Director Commercial Affairs/COO: Dipl. Ing. (FH) Armin von Collrepp Commercial Registry: Amtsgericht Chemnitz, HRB 28082; USt.-Id Nr. DE150534010