From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <ian.jackson@citrix.com>
Subject: Re: [PATCH 8/9] libxl: Kill QEMU by uid when possible
Date: Wed, 28 Nov 2018 16:56:24 +0000
Message-ID: <23550.51384.89698.110737@mariner.uk.xensource.com>
References: <20181123171502.29519-1-george.dunlap@citrix.com>
 <20181123171502.29519-8-george.dunlap@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6])
 by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from
 <srs0=bc+k=oh=citrix.com=prvs=863aa12bc=ian.jackson@srs-us1.protection.inumbo.net>)
 id 1gS397-0002gk-Ti
 for xen-devel@lists.xenproject.org; Wed, 28 Nov 2018 16:57:05 +0000
In-Reply-To: <20181123171502.29519-8-george.dunlap@citrix.com>
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: George Dunlap <george.dunlap@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

R2VvcmdlIER1bmxhcCB3cml0ZXMgKCJbUEFUQ0ggOC85XSBsaWJ4bDogS2lsbCBRRU1VIGJ5IHVp
ZCB3aGVuIHBvc3NpYmxlIik6Cj4gVGhlIHByaXZjbWQgZmQgdGhhdCBhIGRtX3Jlc3RyaWN0J2Vk
IFFFTVUgaGFzIGdpdmVzIGl0IHBlcm1pc3Npb24gdG8KPiBvbmUgc3BlY2lmaWMgZG9tYWluIElE
LiAgVGhpcyBkb21haW4gSUQgd2lsbCBwcm9iYWJseSBldmVudHVhbGx5IGJlCj4gdXNlZCBhZ2Fp
bi4gIEl0IGlzIHRoZXJlZm9yZSBuZWNlc3NhcnkgdG8gbWFrZSBhYnNvbHV0ZWx5IHN1cmUgdGhh
dCBhCj4gcm9ndWUgUUVNVSBwcm9jZXNzIGNhbm5vdCBoYW5nIGFyb3VuZCBhZnRlciBpdHMgZG9t
YWluIGhhcyBleGl0ZWQuCgpUaGFua3MuICBUaGlzIGxvb2tzIHJvdWdobHkgcmlnaHQgYnV0IEkg
aGF2ZSBzb21lIGNvZGluZyBzdHlsZQpxdWliYmxlcywgYW5kIEkgYW0gbm90IGNvbnZpbmNlZCB0
aGUgZXJyb3IgaGFuZGxpbmcgaXMgcmlnaHQuCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAKPiBAQCAtMjM4Miw2ICsyMzg5LDE1IEBAIHZvaWQgbGlieGxfX3NwYXduX2xvY2FsX2Rt
KGxpYnhsX19lZ2MgKmVnYywgbGlieGxfX2RtX3NwYXduX3N0YXRlICpkbXNzKQo+ICAKPiAgICAg
IGNvbnN0IGNoYXIgKmRvbV9wYXRoID0gbGlieGxfX3hzX2dldF9kb21wYXRoKGdjLCBkb21pZCk7
Cj4gIAo+ICsgICAgLyogCj4gKyAgICAgKiBJZiB3ZSdyZSBzdGF0aW5nIHRoZSBkbSB3aXRoIGEg
bm9uLXJvb3QgVUlELCBzYXZlIHRoZSBVSUQgc28KClR5cG8gZm9yIGBzdGFydGluZycuCgo+ICsg
ICAgICogdGhhdCB3ZSBjYW4gcmVsaWFibHkga2lsbCBpdCBhbmQgYW55IHN1YnByb2Nlc3Nlcwo+
ICsgICAgICovCi4uLgo+ICtzdGF0aWMgdm9pZCBraWxsX2RldmljZV9tb2RlbF91aWRfY2IobGli
eGxfX2VnYyAqZWdjLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGli
eGxfX2V2X2NoaWxkICpkZXN0cm95ZXIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICBwaWRfdCBwaWQsIGludCBzdGF0dXMpOwo+ICsKPiAgdm9pZCBsaWJ4bF9fZGVzdHJv
eV9kZXZpY2VfbW9kZWwobGlieGxfX2VnYyAqZWdjLAo+ICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBsaWJ4bF9fZGVzdHJveV9kZXZpY2Vtb2RlbF9zdGF0ZSAqZGRtcykKPiAgewo+
IEBAIC0yNjU4LDE1ICsyNjc4LDEwMyBAQCB2b2lkIGxpYnhsX19kZXN0cm95X2RldmljZV9tb2Rl
bChsaWJ4bF9fZWdjICplZ2MsCj4gICAgICBpbnQgcmM7Cj4gICAgICBpbnQgZG9taWQgPSBkZG1z
LT5kb21pZDsKPiAgICAgIGNoYXIgKnBhdGggPSBERVZJQ0VfTU9ERUxfWFNfUEFUSChnYywgTElC
WExfVE9PTFNUQUNLX0RPTUlELCBkb21pZCwgIiIpOwo+ICsgICAgY29uc3QgY2hhciAqIGRtX3Vp
ZF9zdHI7Cj4gKyAgICB1aWRfdCBkbV91aWQ7Cj4gKyAgICBpbnQgcmVhcGVyX3BpZDsKPiArICAg
IGludCByZXQ7Cj4gICAgICAKPiAgICAgIGlmICgheHNfcm0oQ1RYLT54c2gsIFhCVF9OVUxMLCBw
YXRoKSkKPiAgICAgICAgICBMT0dEKEVSUk9SLCBkb21pZCwgInhzX3JtIGZhaWxlZCBmb3IgJXMi
LCBwYXRoKTsKPiAgICAgIAo+IC0gICAgLyogV2Ugc2hvdWxkIHRyeSB0byBkZXN0cm95IHRoZSBk
ZXZpY2UgbW9kZWwgYW55d2F5LiAqLwo+IC0gICAgcmMgPSBraWxsX2RldmljZV9tb2RlbChnYywK
PiAtICAgICAgICAgICAgICBHQ1NQUklOVEYoIi9sb2NhbC9kb21haW4vJWQvaW1hZ2UvZGV2aWNl
LW1vZGVsLXBpZCIsIGRvbWlkKSk7Cj4gKyAgICAvKiAKPiArICAgICAqIFdlIHNob3VsZCB0cnkg
dG8gZGVzdHJveSB0aGUgZGV2aWNlIG1vZGVsIGFueXdheS4gIENoZWNrIHRvIHNlZQo+ICsgICAg
ICogaWYgd2UgY2FuIGtpbGwgYnkgVUlECj4gKyAgICAgKi8KPiArICAgIHJldCA9IGxpYnhsX194
c19yZWFkX2NoZWNrZWQoZ2MsIFhCVF9OVUxMLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIEdDU1BSSU5URigiL2xvY2FsL2RvbWFpbi8lZC9pbWFnZS9kZXZpY2UtbW9kZWwtdWlk
IiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRvbWlkKSwK
PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmRtX3VpZF9zdHIpOwoKSSBrbm93
IHRoaXMgZnVuY3Rpb24gaXMgYmFkIGluIGl0cyB1c2Ugb2YgYHJjJyBmb3Igc3lzY2FsbCByZXR1
cm4gYnV0CnBsZWFzZSBkb24ndCBtYWtlIGl0IHdvcnNlIGJ5IGludHJvZHVjaW5nIGByZXQnIGZv
ciB3aGF0IHNob3VsZCBiZQpgcmMnLiAgV291bGQgeW91IG1pbmQgYWRkaW5nIGEgcHJlLXBhdGNo
IHRvIGNoYW5nZSBgcmMnIHRvIGByJyBhbmQKdGhlbiB5b3UgY2FuIHVzZSBgcmMnID8KCj4gKyAg
ICBpZiAocmV0IHx8ICFkbV91aWRfc3RyKSB7CgpTaG91bGRuJ3Qgd2UgZmFpbCBpZiBsaWJ4bF9f
eHNfcmVhZF9jaGVja2VkIGZhaWxzID8KT3RoZXJ3aXNlIHdlIHJpc2sgbGVhdmluZyBmcmFnbWVu
dHMgb2YgZG9tYWluIGJlaGluZCBldmVuIGlmIHdlIGZhaWwuCihQb3NzaWJseSB3ZSBzaG91bGQg
Y2Fycnkgb24sIGJ1dCBhY2N1bXVsYXRlIGVycm9ycyBpbiByYy4pCgo+ICsgICAgICAgIC8qIE5v
IHVpZCBpbiB4ZW5zdG9yZTsganVzdCBraWxsIHRoZSBwaWQgd2UgaGF2ZSAqLwo+ICsgICAgICAg
IExPR0QoREVCVUcsIGRvbWlkLCAiRGlkbid0IGZpbmQgZG0gVUlEOyBkZXN0cm95aW5nIGJ5IHBp
ZCIpOwo+ICsgICAgICAgIAo+ICsgICAgICAgIHJjID0ga2lsbF9kZXZpY2VfbW9kZWwoZ2MsCj4g
KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHQ1NQUklOVEYoIi9sb2NhbC9kb21haW4v
JWQvaW1hZ2UvZGV2aWNlLW1vZGVsLXBpZCIsIGRvbWlkKSk7Cj4gKyAgICAKPiArICAgICAgICBs
aWJ4bF9fcW1wX2NsZWFudXAoZ2MsIGRvbWlkKTsKPiArCj4gKyAgICAgICAgZGRtcy0+Y2FsbGJh
Y2soZWdjLCBkZG1zLCByYyk7Cj4gKyAgICAgICAgcmV0dXJuOwoKQ2FuIHlvdSBwbGVhc2UgYnJl
YWsgb3V0IHRoaXMgbGl0dGxlIGV4aXQgY29kZSBmcmFnbWVudAoKICArICAgICAgICBsaWJ4bF9f
cW1wX2NsZWFudXAoZ2MsIGRvbWlkKTsKICArICAgICAgICBkZG1zLT5jYWxsYmFjayhlZ2MsIGRk
bXMsIHJjKTsKCmludG8gYSBzdWItZnVuY3Rpb24gPyAgSXQgb2NjdXJzIHR3aWNlIGFuZCBpdCBp
cyBlYXNpZXIgdG8gcmVhc29uCmFib3V0IHRoaW5ncyBpZiB0aGUgb3BlcmF0aW9uIGhhcyBhIHNp
bmdsZSBleGl0IHBhdGguCgo+ICsgICAgLyogUUVNVSBoYXMgaXRzIG93biB1aWQ7IGtpbGwgYWxs
IHByb2Nlc3NlcyB3aXRoIHRoYXQgVUlEICovCj4gKyAgICBMT0dEKERFQlVHLCBkb21pZCwgIkZv
dW5kIERNIHVpZCAlcywgZGVzdHJveWluZyBieSB1aWQiLCBkbV91aWRfc3RyKTsKPiArICAgIAo+
ICsgICAgZG1fdWlkID0gYXRvaShkbV91aWRfc3RyKTsKCkkgYW0gdGVtcHRlZCB0byBzdWdnZXN0
IGEgbW9yZSByb2J1c3QgdXNlIG9mIHN0cnRvdWwgaGVyZSBidXQgc2luY2UKdGhpcyBjYW1lIGZy
b20gb3VyIG93biB4ZW5zdG9yZSBub2RlLCBmaW5lLgoKPiArICAgIHJlYXBlcl9waWQgPSBsaWJ4
bF9fZXZfY2hpbGRfZm9yayhnYywgJmRkbXMtPmRlc3Ryb3llciwKPiArICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBraWxsX2RldmljZV9tb2RlbF91aWRfY2IpOwo+ICsgICAg
aWYgKHJlYXBlcl9waWQgPCAwKQo+ICsgICAgICAgIGRkbXMtPmNhbGxiYWNrKGVnYywgZGRtcywg
RVJST1JfRkFJTCk7Cj4gKyAgICB9Cj4gKwoKQW5kLCB2b2lsYSEgIERpZG4ndCB5b3UgbWVhbiB0
byBjYWxsIGxpYnhsX19xbXBfY2xlYW51cCA/ICBZb3UncmUKbWlzc2luZyB0aGUgZXhpdCBwYXRo
LiAgQW5kIG1heWJlIHRoZSBjYWxsIHRvIGl0IHNob3VsZCBiZSBhbiBgb3V0JwpibG9jayBpbiB0
aGlzIGZ1bmN0aW9uLgoKQWxzbywgYW1hemluZ2x5LCB5b3UgZG9uJ3QgcmV0dXJuIG9yIGFueXRo
aW5nIGhlcmUuICBUaGlzIGlzIG9ubHkgbm90CmEgYnVnIGJlY2F1c2UgdGhlIHJlc3QgaXMgYWxs
IHRoZSBjaGlsZCBwcm9jZXNzLgoKPiArICAgIGlmICghcmVhcGVyX3BpZCkgeyAvKiBjaGlsZCAq
Lwo+ICsgICAgICAgIGNvbnN0IGNoYXIgKiBjYWxsOwo+ICsKPiArICAgICAgICAvKiAKPiArICAg
ICAgICAgKiBGSVhNRTogdGhlIHNlY29uZCB1aWQgbmVlZHMgdG8gYmUgZGlzdGluY3QgdG8gYXZv
aWQgYmVpbmcKPiArICAgICAgICAgKiBraWxsZWQgYnkgYSBwb3RlbnRpYWwgcm9ndWUgcHJvY2Vz
cwo+ICsgICAgICAgICAqLwoKVGhpcyBpcyBhIGJpdCBvZiBhIGZ1bm55IHdheSBvZiBpbnRyb2R1
Y2luZyB0aGlzIGJ1dCBmaW5lLgoKPiArICAgICAgICByZXQgPSBzZXRyZXN1aWQoZG1fdWlkLCBk
bV91aWQsIDApOwo+ICsgICAgICAgIGlmIChyZXQpIHsKPiArICAgICAgICAgICAgY2FsbCA9ICJz
ZXRyZXN1aWQiOwo+ICsgICAgICAgICAgICBnb3RvIGJhZGNoaWxkOwo+ICsgICAgICAgIH0KPiAr
Cj4gKyAgICAgICAgLyogQW5kIGtpbGwgZXZlcnlvbmUgYnV0IG1lICovCj4gKyAgICAgICAgcmV0
ID0ga2lsbCgtMSwgOSk7Cj4gKyAgICAgICAgaWYgKHJldCkgewo+ICsgICAgICAgICAgICBjYWxs
ID0gImtpbGwiOwo+ICsgICAgICAgICAgICBnb3RvIGJhZGNoaWxkOwo+ICsgICAgICAgIH0KPiAr
ICAgICAgICBfZXhpdCgwKTsKPiArICAgICAgICAKPiArICAgIGJhZGNoaWxkOgo+ICsgICAgICAg
IGlmIChlcnJubyA+IDAgICYmIGVycm5vIDwgMTI2KSB7Cj4gKyAgICAgICAgICAgIF9leGl0KGVy
cm5vKTsKPiArICAgICAgICB9IGVsc2Ugewo+ICsgICAgICAgICAgICBMT0dFRChFUlJPUiwgZG9t
aWQsCj4gKyAgICAgICAgICAgICAgICAgICJDYWxsICVzIGZhaWxlZCAod2l0aCBkaWZmaWN1bHQg
ZXJybm8gdmFsdWUgJWQpIiwKPiArICAgICAgICAgICAgICAgICAgY2FsbCwgZXJybm8pOwo+ICsg
ICAgICAgICAgICBfZXhpdCgtMSk7Cj4gKyAgICAgICAgfQo+ICsgICAgfQoKSSBkb24ndCBtdWNo
IGxpa2UgdGhlc2UgZ290b3MgZWl0aGVyLiAgTWF5YmUgYSBzdWJmdW5jdGlvbiBpcyBjYWxsZWQK
Zm9yLgoKRnVydGhlcm1vcmUsIG9uY2UgYWdhaW4gcGxlYXNlIHNlZSBDT0RJTkdfU1RZTEUgcmUg
Y29udmVudGlvbmFsCnZhcmlhYmxlIG5hbWVzIGByJyBhbmQgYHJjJ8K3Cgo+ICtvdXQ6Cj4gKyAg
ICBsaWJ4bF9fcW1wX2NsZWFudXAoZ2MsIGRkbXMtPmRvbWlkKTsKCj4gICAgICBkZG1zLT5jYWxs
YmFjayhlZ2MsIGRkbXMsIHJjKTsKCkhlcmUncyB0aGF0IGZpbmlzaCBmcmFnbWVudCBhZ2Fpbi4K
Cj4gaW5kZXggODk5YTg2ZTg0Yi4uNTllYWMwNjYyYSAxMDA2NDQKPiAtLS0gYS90b29scy9saWJ4
bC9saWJ4bF9pbnRlcm5hbC5oCj4gKysrIGIvdG9vbHMvbGlieGwvbGlieGxfaW50ZXJuYWwuaAo+
IEBAIC0xMTM1LDcgKzExMzUsNyBAQCB0eXBlZGVmIHN0cnVjdCB7Cj4gICAgICBjb25zdCBjaGFy
ICogc2hpbV9jbWRsaW5lOwo+ICAgICAgY29uc3QgY2hhciAqIHB2X2NtZGxpbmU7Cj4gIAo+IC0g
ICAgY2hhciAqIGRtX3J1bmFzOwo+ICsgICAgY2hhciAqIGRtX3J1bmFzLCAgKmRtX3VpZDsKCkl0
IHdvdWxkIGJlIG5pY2UgdG8gZHJvcCB0aGUgc3B1cmlvdXMgc3BhY2UgYmVmb3JlIGRtX3J1bmFz
IHdoaWxlIHlvdQphcmUgaGVyZSwgYW5kIHRoZW4gcHJlc3VtYWJseSB0aGUgZG91YmxlIHNwYWNl
IGJlZm9yZSAqZG1fdWlkIHdvdWxkCm5vdCBiZSBuZWVkZWQuCgpUaGFua3MsCklhbi4KCl9fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWls
aW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVu
cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby94ZW4tZGV2ZWw=