From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4] service: fix parameter type
Date: Thu, 28 Mar 2019 21:10:14 +0100
Message-ID: <2355503.thBRjjl5CD@xps>
References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com>
 <1553754543-40534-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, harry.van.haaren@intel.com, ferruh.yigit@intel.com
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1BBCA2C24
 for <dev@dpdk.org>; Thu, 28 Mar 2019 21:10:17 +0100 (CET)
In-Reply-To: <1553754543-40534-1-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

28/03/2019 07:29, Nikhil Rao:
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
> 
> Fixes: 4d55194d76a4 ("service: add attribute get function")
> 
> Reviewed-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>

Rebased for master and applied, thanks.