From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DC98C43334 for ; Thu, 16 Jun 2022 11:10:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E831684328; Thu, 16 Jun 2022 13:09:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="rhat9Vbu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2C71584328; Thu, 16 Jun 2022 13:09:56 +0200 (CEST) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D510383AB5 for ; Thu, 16 Jun 2022 13:09:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 25GB9kv3095777; Thu, 16 Jun 2022 06:09:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1655377786; bh=drm3Gvt4N6n2cIotLkpMkrX+xlkCoZKpcDrVb94Sles=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=rhat9VbuvTTk5nfbFcGDZpjRHRo9kG5tt7xjcnqMYNNyjTEu+W25d7XcTDn+tp0Cl s4CtFGaHhotStJVEsn/zG1OWhSTc4TiAGPJCeuW6BWNZDDTIXnSJL3TmHk4b1ihDtS TMwWM1GAlpL9yyOhz2lSaTwF5zaJATdLZ/XqIR98= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 25GB9kub047299 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Jun 2022 06:09:46 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 16 Jun 2022 06:09:45 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 16 Jun 2022 06:09:45 -0500 Received: from [172.24.157.182] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 25GB9gFl114178; Thu, 16 Jun 2022 06:09:43 -0500 Message-ID: <2356abb9-f541-5102-dab4-e9b4c0047e3b@ti.com> Date: Thu, 16 Jun 2022 16:39:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH RFC v3 08/11] ti: j721e: Exclude makefile tispl.bin target for J721E Content-Language: en-US To: Roger Quadros , , , , CC: , References: <20220615064804.29553-1-n-francis@ti.com> <20220615064804.29553-9-n-francis@ti.com> <25614b05-be32-9e8f-e576-8fe6210c5973@kernel.org> From: Neha Malcom Francis In-Reply-To: <25614b05-be32-9e8f-e576-8fe6210c5973@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Roger, On 15/06/22 19:14, Roger Quadros wrote: > Hi Neha, > > On 15/06/2022 09:48, Neha Malcom Francis wrote: >> tispl.bin is to be packaged (with ATF, OPTEE, DM and A72 SPL) using >> binman. The tispl.bin target from the makefile is no longer needed for >> J721E. >> >> Signed-off-by: Neha Malcom Francis >> --- >> arch/arm/mach-k3/config.mk | 5 +++++ >> scripts/Makefile.spl | 2 ++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/arch/arm/mach-k3/config.mk b/arch/arm/mach-k3/config.mk >> index d706d17788..dd5e42d9df 100644 >> --- a/arch/arm/mach-k3/config.mk >> +++ b/arch/arm/mach-k3/config.mk >> @@ -74,6 +74,7 @@ ifeq ($(CONFIG_SOC_K3_J721E),) >> export DM := /dev/null >> endif >> >> +ifndef CONFIG_TARGET_J721E_A72_EVM > > How about using #ifndef CONFIG_BINMAN instead? Any platform enabling that > doesn't want to use the old way. > > You are still breaking HS functionality with this series correct? > That will have to be fixed. > > One proposal was discussed here > https://lore.kernel.org/all/76474ded-a782-f491-eac6-ece3c5f4a7da@gmail.com/ > > We should be able to produce tispl.bin_HS and u-boot.img_HS via binman. > > You have already covered most of the x509 stuff image in ti-x509-cert etype. > Please refer to below script [1] to know what is required to get _HS images. > > [1] https://git.ti.com/cgit/security-development-tools/core-secdev-k3/tree/scripts/secure-binary-image.sh > Yes, this patch was intended for GP only but like Andrew said, will have to do HS as well. I'll build on this patch for HS devices. >> ifeq ($(CONFIG_TI_SECURE_DEVICE),y) >> SPL_ITS := u-boot-spl-k3_HS.its >> $(SPL_ITS): export IS_HS=1 >> @@ -98,9 +99,11 @@ cmd_k3_mkits = \ >> $(SPL_ITS): FORCE >> $(call cmd,k3_mkits) >> endif >> +endif >> >> else >> >> +ifndef CONFIG_TARGET_J721E_A72_EVM >> ifeq ($(CONFIG_TI_SECURE_DEVICE),y) >> INPUTS-y += u-boot.img_HS >> else >> @@ -108,4 +111,6 @@ INPUTS-y += u-boot.img >> endif >> endif >> >> +endif >> + > > You will have to enclose below line in #ifndef CONFIG_BINMAN as well. > Will make the changes. >> include $(srctree)/arch/arm/mach-k3/config_secure.mk >> diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl >> index f047d4e094..6104cb8587 100644 >> --- a/scripts/Makefile.spl >> +++ b/scripts/Makefile.spl >> @@ -591,6 +591,8 @@ $(obj)/$(SPL_BIN).multidtb.fit.lzo: $(obj)/$(SPL_BIN).multidtb.fit >> @lzop -f9 $< > $@ >> >> ifdef CONFIG_ARCH_K3 >> +ifndef CONFIG_TARGET_J721E_A72_EVM > > Is this still being called in-spite of the changes to config.mk? > Please use CONFIG_BINMAN instead of CONFIG_TARGET_J721E_A72_EVM I will make the changes. > >> tispl.bin: $(obj)/u-boot-spl-nodtb.bin $(SHRUNK_ARCH_DTB) $(SPL_ITS) FORCE >> $(call if_changed,mkfitimage) >> endif >> +endif > > cheers, > -roger -- Thanking You Neha Malcom Francis