From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] mk: fix make defconfig on FreeBSD Date: Mon, 23 Apr 2018 01:36:08 +0200 Message-ID: <2360559.u8KFuLjH65@xps> References: <20180410150804.8774-1-david.hunt@intel.com> <20180410154440.9723-1-david.hunt@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, anatoly.burakov@intel.com To: David Hunt Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 829D21DBB for ; Mon, 23 Apr 2018 01:36:10 +0200 (CEST) In-Reply-To: <20180410154440.9723-1-david.hunt@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/04/2018 17:44, David Hunt: > On FreeBSD, make defconfig generates the config as "defconfig_x86_64-bsdapp-", > which does not resolve to any known config file. > > This fix starts by introducing a 'compiler' variable which is set by executing > "${CC} --version" and pulling out the name of the compiler. [...] > +compiler:=$(filter clang gcc icc cc,$(shell ${CC} --version)) You should not invoke a shell command outside of a rule. Please try to move it inside the defconfig context. Reason for this query? 1/ avoid polluting the rest of the makefile 2/ it breaks doc compilation Why it breaks doc? Because it breaks "make -R showversion" which is called in doc/guides/conf.py. Tip: CC is not always defined :)