From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart Subject: Re: [PATCH] media: Convert to using %pOF instead of full_name Date: Wed, 19 Jul 2017 16:13:05 +0300 Message-ID: <2365474.Q2cOWx8lkM@avalon> In-Reply-To: <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> References: <20170718214339.7774-33-robh@kernel.org> <564a6768-3b23-6dc7-ecb5-cb4f4359b633@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" To: Sylwester Nawrocki Cc: Rob Herring , linux-media@vger.kernel.org, Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Kyungmin Park , Andrzej Hajda , "Lad, Prabhakar" , Songjun Wu , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Matthias Brugger , Niklas =?ISO-8859-1?Q?S=F6derlund?= , Guennadi Liakhovetski , Hyun Kwon , Michal Simek , =?ISO-8859-1?Q?S=F6ren?= Brinkmann , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-re nesas-soc@vger.kernel.org List-ID: Hi Sylwester, On Wednesday 19 Jul 2017 11:41:37 Sylwester Nawrocki wrote: > On 07/18/2017 11:43 PM, Rob Herring wrote: > > Now that we have a custom printf format specifier, convert users of > > full_name to use %pOF instead. This is preparation to remove storing > > of the full path string for each node. > > > > Signed-off-by: Rob Herring > > > > --- > > > > drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +- > > drivers/media/i2c/s5k5baf.c | 7 ++-- > > drivers/media/platform/am437x/am437x-vpfe.c | 4 +- > > drivers/media/platform/atmel/atmel-isc.c | 4 +- > > drivers/media/platform/davinci/vpif_capture.c | 16 ++++---- > > drivers/media/platform/exynos4-is/fimc-is.c | 8 ++-- > > drivers/media/platform/exynos4-is/fimc-lite.c | 3 +- > > drivers/media/platform/exynos4-is/media-dev.c | 8 ++-- > > drivers/media/platform/exynos4-is/mipi-csis.c | 4 +- > > drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +-- > > drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- > > drivers/media/platform/omap3isp/isp.c | 8 ++-- > > drivers/media/platform/pxa_camera.c | 2 +- > > drivers/media/platform/rcar-vin/rcar-core.c | 4 +- > > drivers/media/platform/soc_camera/soc_camera.c | 6 +-- > > drivers/media/platform/xilinx/xilinx-vipp.c | 52 ++++++++++---------- > > drivers/media/v4l2-core/v4l2-async.c | 4 +- > > drivers/media/v4l2-core/v4l2-clk.c | 3 +- > > include/media/v4l2-clk.h | 4 +- > > 19 files changed, 71 insertions(+), 83 deletions(-) > > > > diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c > > b/drivers/media/platform/xilinx/xilinx-vipp.c index > > ac4704388920..9233ad0b1b6b 100644 > > --- a/drivers/media/platform/xilinx/xilinx-vipp.c > > +++ b/drivers/media/platform/xilinx/xilinx-vipp.c > > @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct > > xvip_composite_device *xdev, > > remote = ent->entity; > > if (link.remote_port >= remote->num_pads) { > > - dev_err(xdev->dev, "invalid port number %u on %s\n", > > - link.remote_port, > > - to_of_node(link.remote_node)->full_name); > > + dev_err(xdev->dev, "invalid port number %u on %pOF\n", > > + link.remote_port, link.remote_node); > > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ? Good catch, I had missed that one. > > v4l2_fwnode_put_link(&link); > > ret = -EINVAL; > > break; [snip] -- Regards, Laurent Pinchart