From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 11/32] net/dpaa2: add dpaa2 vfio support
Date: Wed, 07 Dec 2016 09:38:10 +0100
Message-ID: <2366721.OpDVYN8WCp@xps13>
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
 <4516168.6vIN5TbTdY@xps13> <b0db98e6-793a-b2d5-02bb-3d0a9fc5f30e@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, shreyansh.jain@nxp.com
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f173.google.com (mail-wj0-f173.google.com
 [209.85.210.173]) by dpdk.org (Postfix) with ESMTP id A5E3832A5
 for <dev@dpdk.org>; Wed,  7 Dec 2016 09:38:12 +0100 (CET)
Received: by mail-wj0-f173.google.com with SMTP id tg4so97948362wjb.1
 for <dev@dpdk.org>; Wed, 07 Dec 2016 00:38:12 -0800 (PST)
In-Reply-To: <b0db98e6-793a-b2d5-02bb-3d0a9fc5f30e@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-12-07 12:30, Hemant Agrawal:
> On 12/7/2016 2:34 AM, Thomas Monjalon wrote:
> > 2016-12-04 23:47, Hemant Agrawal:
> >> Add support for using VFIO for dpaa2 based fsl-mc bus.
> >
> > Why do we need so much special code for interfacing VFIO on fsl-mc?
> > Can you reuse some code from EAL VFIO?
> >
> 
> fsl-mc VFIO scans the objects.  So, it is slightly different.
> 
> Even though I have tried to minimize changes and re-use the code from 
> EAL VFIO. It is still refactoring work, which we will take up little later.

Do you mean you could re-use some EAL code but do not want to do it now?
It sounds like something heard too many times earlier (from others).
The experience tells we must not wait to do things right.