From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 254E0C433EF for ; Thu, 9 Jun 2022 09:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239312AbiFIJ4c convert rfc822-to-8bit (ORCPT ); Thu, 9 Jun 2022 05:56:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230164AbiFIJ4a (ORCPT ); Thu, 9 Jun 2022 05:56:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1B6539F24B for ; Thu, 9 Jun 2022 02:56:29 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzEtl-0006P2-4j; Thu, 09 Jun 2022 11:56:17 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzEtk-007M6H-ST; Thu, 09 Jun 2022 11:56:15 +0200 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nzEti-0003tx-Q8; Thu, 09 Jun 2022 11:56:14 +0200 Message-ID: <236b39507da31d80a948fe308f515587e96c28de.camel@pengutronix.de> Subject: Re: [PATCH] s390: disable -Warray-bounds From: Philipp Zabel To: Linus Torvalds , Kees Cook , Shawn Guo , Sascha Hauer , Fabio Estevam , David Howells Cc: Sven Schnelle , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Linux Kernel Mailing List Date: Thu, 09 Jun 2022 11:56:14 +0200 In-Reply-To: References: <20220422134308.1613610-1-svens@linux.ibm.com> <202204221052.85D0C427@keescook> <202206081404.F98F5FC53E@keescook> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On Mi, 2022-06-08 at 16:59 -0700, Linus Torvalds wrote: > On Wed, Jun 8, 2022 at 2:33 PM Kees Cook wrote: > > > > I and others have been working through a bunch of them, though yes, > > they're not all fixed yet. I've been trying to track it here[1], but > > many of those fixes are only in -next. > > Hmm. Even with that disabled, I get a few warnings I *really* would > want to get rid of. > > The one in ipuv3-crtc.c seems valid about "address used as boolean is > always true". > > The 'dangling-pointer' warning does seem interesting, but not when the > compiler does as bad a job as gcc seems to do. > > See the attached patch for > >  (a) make the s390 "use -Wno-array-bounds for gcc-12" be generic > >  (b) fix the ipuv3-crtc.c one. IMX people? Thank you, this fix clearly matches the original intention. Acked-by: Philipp Zabel The mistake had no adverse effect since the following condition doesn't actually dereference the NULL pointer, but given the compiler warning this Fixes: eb8c88808c83 ("drm/imx: add deferred plane disabling") regards Philipp