[Cluster-devel] [PATCH 1/3] gfs2: Add a next-resource-group pointer to resource groups

[Bob Peterson <rpeterso@redhat.com>]

Hi,

----- Original Message -----
| Add a new rg_skip field to struct gfs2_rgrp, replacing __pad. The
| -	str->__pad = cpu_to_be32(0);
| +	if (next != NULL && next->rd_addr > rgd->rd_addr)
| +		str->rg_skip = cpu_to_be32(next->rd_addr - rgd->rd_addr);

Without having looked at the original:

Shouldn't we still initialize it to 0 or put in an else clause?
I'm concerned that we might end up with an uninitialized random value
at the last rgrp (which may not be a big concern until gfs2_grow or
fsck time).

Bob Peterson
Red Hat File Systems