From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933996AbcIFNQU (ORCPT ); Tue, 6 Sep 2016 09:16:20 -0400 Received: from mail.eperm.de ([89.247.134.16]:37392 "EHLO mail.eperm.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932538AbcIFNQS (ORCPT ); Tue, 6 Sep 2016 09:16:18 -0400 From: Stephan Mueller To: David Howells Cc: Artem Savkov , Kirill Marinushkin , paul.gortmaker@windriver.com, james.l.morris@oracle.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng. Date: Tue, 06 Sep 2016 15:16:11 +0200 Message-ID: <2374976.3ZKPojcGMB@tauon.atsec.com> User-Agent: KMail/5.2.3 (Linux/4.6.7-300.fc24.x86_64; KDE/5.25.0; x86_64; ; ) In-Reply-To: <32083.1473167516@warthog.procyon.org.uk> References: <20160906130618.GA9055@shodan.usersys.redhat.com> <25084.1473166729@warthog.procyon.org.uk> <32083.1473167516@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 6. September 2016, 14:11:56 CEST schrieb David Howells: Hi David, > Artem Savkov wrote: > > > > - select CRYPTO > > > > + depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y) > > > > > > Should those be "==" not "="? > > > > Accodring to Documentation/kbuild/kconfig-language.txt (line 173) it is > > "=" and I can only see "=" being used in existing Kconfigs. > > Okay. The other thing is that I have been given a conflicting patch (see > below). Is your fix preferable? The listed patch only selects the ANSI X9.31 DRNG and thus conflicts with FIPS mode and the current default stdrng which is the DRBG. Ciao Stephan