From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH RFC 1/3] i2c: bcm2835: Avoid possible NULL ptr dereference Date: Tue, 21 Feb 2017 17:31:03 +0100 Message-ID: <23773cd4-a9a4-5323-4cc2-71d1d617b232@i2se.com> References: <1487280047-29608-1-git-send-email-stefan.wahren@i2se.com> <1487280047-29608-2-git-send-email-stefan.wahren@i2se.com> <20170220182214.izi46a7lbzck7q4r@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20170220182214.izi46a7lbzck7q4r@ninjato> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg Kroah-Hartman Cc: Eric Anholt , Peter Robinson , Martin Sperl , Wolfram Sang , Catalin Marinas , Will Deacon , Rob Herring , Frank Rowand , Florian Fainelli , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Greg, hi Wolfram, Am 20.02.2017 um 19:22 schrieb Wolfram Sang: > On Thu, Feb 16, 2017 at 09:20:45PM +0000, Stefan Wahren wrote: >> Since commit e2474541032d ("bcm2835: Fix hang for writing messages >> larger than 16 bytes") the interrupt handler is prone to a possible >> NULL pointer dereference. This could happen if an interrupt fires >> before curr_msg is set by bcm2835_i2c_xfer_msg() and randomly occurs >> on the RPi 3. Even this is an unexpected behavior the driver must >> handle that with an error instead of a crash. >> >> CC: Noralf Trønnes >> CC: Martin Sperl >> Reported-by: Peter Robinson >> Fixes: e2474541032d ("bcm2835: Fix hang for writing messages larger than 16 bytes") >> Signed-off-by: Stefan Wahren > Applied to for-next, thanks (will be in 4.11)! > since this patch is too late for 4.10, should i resent with CC to stable in order to get it into the next 4.10 release? Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html