From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 1/5] resolve: Exit methods if resolve is NULL
Date: Tue, 22 Sep 2020 09:34:39 -0500 [thread overview]
Message-ID: <237c1ec9-7f85-59b4-19db-d4f1f36a731d@gmail.com> (raw)
In-Reply-To: <CAOq732LEKzjdC7gDhn13n9rVQ5m9KksjHwonafV1HAVeESmKWw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]
Hi Andrew,
On 9/22/20 9:28 AM, Andrew Zaborowski wrote:
> Hi Denis,
>
> On Tue, 22 Sep 2020 at 16:19, Denis Kenzior <denkenz@gmail.com> wrote:
>> On 9/21/20 11:18 PM, Andrew Zaborowski wrote:
>>> I'm still using netconfig from P2P, I guess we shouldn't require
>>> General.EnableNetworkConfiguration to be set for P2P. P2P doesn't
>>> (usually) have DNS so this should still work but maybe the checks
>>> should be in netconfig.c after all, not sure.
>>
>> I don't think it makes sense to have this asymmetry. Why is P2P special
>> compared to normal station client?
>
> We also don't have any configuration for P2P netconfig because the
> spec mandates the use of DHCP. There's also no legacy to worry about,
> so I don't see the point of making DHCP optional for P2P.
That isn't exactly the point I was trying to make. P2P would always use DHCP or
network config KDEs, no disagreement there. But from a user / system
configuration perspective I don't think this asymmetry is something that one
would expect or would want.
So if the user has not enabled EnableNetworkConfiguration setting then
systemd-networkd (for example) expects to perform DHCP for all WiFi interfaces.
How would you tell systemd-networkd not to configure P2P devices? They're just
WiFi as far as it is concerned.
Regards,
-Denis
next prev parent reply other threads:[~2020-09-22 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 19:04 [PATCH 1/5] resolve: Exit methods if resolve is NULL Andrew Zaborowski
2020-09-21 19:04 ` [PATCH 2/5] p2p: Free peer->wfd in p2p_peer_free Andrew Zaborowski
2020-09-22 3:14 ` Denis Kenzior
2020-09-21 19:04 ` [PATCH 3/5] p2p: Free parsed frame data in p2p_go_negotiation_confirm_cb Andrew Zaborowski
2020-09-21 19:04 ` [PATCH 4/5] p2p: Free response frame payloads Andrew Zaborowski
2020-09-21 19:04 ` [PATCH 5/5] ap: Use frame-xchg when sending frames Andrew Zaborowski
2020-09-22 3:13 ` [PATCH 1/5] resolve: Exit methods if resolve is NULL Denis Kenzior
2020-09-22 4:18 ` Andrew Zaborowski
2020-09-22 14:11 ` Denis Kenzior
2020-09-22 14:28 ` Andrew Zaborowski
2020-09-22 14:34 ` Denis Kenzior [this message]
2020-09-22 21:34 ` Andrew Zaborowski
2020-09-23 1:48 ` Denis Kenzior
-- strict thread matches above, loose matches on Subject: below --
2020-09-21 13:52 Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237c1ec9-7f85-59b4-19db-d4f1f36a731d@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.