From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:46951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMCv9-0003Xz-Ss for qemu-devel@nongnu.org; Thu, 02 May 2019 10:42:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMCv8-0001UR-9b for qemu-devel@nongnu.org; Thu, 02 May 2019 10:42:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39738) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMCv7-0001Qd-Uc for qemu-devel@nongnu.org; Thu, 02 May 2019 10:42:46 -0400 References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-12-git-send-email-imammedo@redhat.com> <0676f7d1-5d75-8ff8-a75b-a9ce01a65741@redhat.com> <20190502162749.3379a69f@Igors-MacBook-Pro> From: Laszlo Ersek Message-ID: <237c3841-8127-fad7-f706-529083686235@redhat.com> Date: Thu, 2 May 2019 16:42:33 +0200 MIME-Version: 1.0 In-Reply-To: <20190502162749.3379a69f@Igors-MacBook-Pro> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Andrew Jones , Ben Warren , "Michael S. Tsirkin" , Shameer Kolothum , Shannon Zhao , Gonglei , Wei Yang , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= On 05/02/19 16:27, Igor Mammedov wrote: > On Fri, 26 Apr 2019 19:11:50 +0200 > Laszlo Ersek wrote: >=20 >> On 04/25/19 07:34, Igor Mammedov wrote: >>> adds simple arm/virt test case that starts guest with >>> bios-tables-test.aarch64.iso.qcow2 boot image which >>> initializes UefiTestSupport* structure in RAM once >>> guest is booted. >>> >>> * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper >>> >>> Signed-off-by: Igor Mammedov >>> Reviewed-by: Laszlo Ersek >>> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >>> --- >>> v3: >>> * use firmware blobs directly from pc-bios directory >>> * use bios-tables-test.aarch64.iso.qcow2 as test boot image >>> * drop leftover qtest-uefi-images-aarch64 iMakefile rule from >>> previos version (Laszlo) >>> * add Makefile rule to include bios-tables-test into >>> check-qtest-aarch64 target >>> v2: >>> * specify in test_data where board's RAM starts and RAM size >>> --- >>> tests/Makefile.include | 1 + >>> tests/bios-tables-test.c | 17 +++++++++++++++++ >>> 2 files changed, 18 insertions(+) >>> >>> diff --git a/tests/Makefile.include b/tests/Makefile.include >>> index e2432d5..983c8b1 100644 >>> --- a/tests/Makefile.include >>> +++ b/tests/Makefile.include >>> @@ -267,6 +267,7 @@ check-qtest-arm-y +=3D tests/hexloader-test$(EXES= UF) >>> check-qtest-aarch64-y =3D tests/numa-test$(EXESUF) >>> check-qtest-aarch64-y +=3D tests/boot-serial-test$(EXESUF) >>> check-qtest-aarch64-y +=3D tests/migration-test$(EXESUF) >>> +check-qtest-aarch64-y +=3D tests/bios-tables-test$(EXESUF) >>> =20 >>> check-qtest-microblazeel-y +=3D $(check-qtest-microblaze-y) >>> =20 >>> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c >>> index 1be55a1..f117461 100644 >>> --- a/tests/bios-tables-test.c >>> +++ b/tests/bios-tables-test.c >>> @@ -812,6 +812,21 @@ static void test_acpi_piix4_tcg_dimm_pxm(void) >>> test_acpi_tcg_dimm_pxm(MACHINE_PC); >>> } >>> =20 >>> +static void test_acpi_virt_tcg(void) >>> +{ >>> + test_data data =3D { >>> + .machine =3D "virt", >>> + .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", >>> + .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", >>> + .cd =3D "tests/data/uefi-boot-images/bios-tables-test.aarch6= 4.iso.qcow2", >>> + .ram_start =3D 0x40000000ULL, >>> + .scan_len =3D 128ULL * 1024 * 1024, >>> + }; >>> + >>> + test_acpi_one("-cpu cortex-a57 ", &data); >>> + free_test_data(&data); >>> +} >>> + >>> int main(int argc, char *argv[]) >>> { >>> const char *arch =3D qtest_get_arch(); >>> @@ -840,6 +855,8 @@ int main(int argc, char *argv[]) >>> qtest_add_func("acpi/q35/numamem", test_acpi_q35_tcg_numamem= ); >>> qtest_add_func("acpi/piix4/dimmpxm", test_acpi_piix4_tcg_dim= m_pxm); >>> qtest_add_func("acpi/q35/dimmpxm", test_acpi_q35_tcg_dimm_px= m); >>> + } else if (strcmp(arch, "aarch64") =3D=3D 0) { >>> + qtest_add_func("acpi/virt", test_acpi_virt_tcg); >>> } >>> ret =3D g_test_run(); >>> boot_sector_cleanup(disk); >>> >> >> Looks good, my R-b stands. >> >> (Please let me know if you want me to look at other patches in the >> series... struggling again with email bankruptcy...) >> >> Thanks! >> Laszlo >> >=20 > on respin there will be a new patch added >=20 > [PATCH v4 11/15] tests: acpi: allow to override default accelerator >=20 > and change to this patch will be forcing TCG accelerator: >=20 > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 6cb8b16..385e1ab 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -817,7 +817,6 @@ static void test_acpi_virt_tcg(void) > { > test_data data =3D { > .machine =3D "virt", > + .accel =3D "tcg", > .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", > .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", > .cd =3D "tests/data/uefi-boot-images/bios-tables-test.aarch64.= iso.qcow2", >=20 You can keep my R-b with that update. Thanks! Laszlo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34155C43219 for ; Thu, 2 May 2019 14:49:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05E7020656 for ; Thu, 2 May 2019 14:49:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05E7020656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:52407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMD1H-0002MD-AS for qemu-devel@archiver.kernel.org; Thu, 02 May 2019 10:49:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMCv9-0003Xz-Ss for qemu-devel@nongnu.org; Thu, 02 May 2019 10:42:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMCv8-0001UR-9b for qemu-devel@nongnu.org; Thu, 02 May 2019 10:42:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39738) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMCv7-0001Qd-Uc for qemu-devel@nongnu.org; Thu, 02 May 2019 10:42:46 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7303789C3F; Thu, 2 May 2019 14:42:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-207.rdu2.redhat.com [10.10.120.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E1B7100200A; Thu, 2 May 2019 14:42:37 +0000 (UTC) To: Igor Mammedov References: <1556170489-131927-1-git-send-email-imammedo@redhat.com> <1556170489-131927-12-git-send-email-imammedo@redhat.com> <0676f7d1-5d75-8ff8-a75b-a9ce01a65741@redhat.com> <20190502162749.3379a69f@Igors-MacBook-Pro> From: Laszlo Ersek Message-ID: <237c3841-8127-fad7-f706-529083686235@redhat.com> Date: Thu, 2 May 2019 16:42:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190502162749.3379a69f@Igors-MacBook-Pro> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 02 May 2019 14:42:44 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 11/13] tests: acpi: add simple arm/virt testcase X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jones , Ben Warren , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shameer Kolothum , Shannon Zhao , Gonglei , Wei Yang , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190502144233.aBLY6M3YJBUu2jFqn8NnEkTzemi3iLHHjFDLJ9cOlak@z> On 05/02/19 16:27, Igor Mammedov wrote: > On Fri, 26 Apr 2019 19:11:50 +0200 > Laszlo Ersek wrote: >=20 >> On 04/25/19 07:34, Igor Mammedov wrote: >>> adds simple arm/virt test case that starts guest with >>> bios-tables-test.aarch64.iso.qcow2 boot image which >>> initializes UefiTestSupport* structure in RAM once >>> guest is booted. >>> >>> * see commit: tests: acpi: add acpi_find_rsdp_address_uefi() helper >>> >>> Signed-off-by: Igor Mammedov >>> Reviewed-by: Laszlo Ersek >>> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >>> --- >>> v3: >>> * use firmware blobs directly from pc-bios directory >>> * use bios-tables-test.aarch64.iso.qcow2 as test boot image >>> * drop leftover qtest-uefi-images-aarch64 iMakefile rule from >>> previos version (Laszlo) >>> * add Makefile rule to include bios-tables-test into >>> check-qtest-aarch64 target >>> v2: >>> * specify in test_data where board's RAM starts and RAM size >>> --- >>> tests/Makefile.include | 1 + >>> tests/bios-tables-test.c | 17 +++++++++++++++++ >>> 2 files changed, 18 insertions(+) >>> >>> diff --git a/tests/Makefile.include b/tests/Makefile.include >>> index e2432d5..983c8b1 100644 >>> --- a/tests/Makefile.include >>> +++ b/tests/Makefile.include >>> @@ -267,6 +267,7 @@ check-qtest-arm-y +=3D tests/hexloader-test$(EXES= UF) >>> check-qtest-aarch64-y =3D tests/numa-test$(EXESUF) >>> check-qtest-aarch64-y +=3D tests/boot-serial-test$(EXESUF) >>> check-qtest-aarch64-y +=3D tests/migration-test$(EXESUF) >>> +check-qtest-aarch64-y +=3D tests/bios-tables-test$(EXESUF) >>> =20 >>> check-qtest-microblazeel-y +=3D $(check-qtest-microblaze-y) >>> =20 >>> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c >>> index 1be55a1..f117461 100644 >>> --- a/tests/bios-tables-test.c >>> +++ b/tests/bios-tables-test.c >>> @@ -812,6 +812,21 @@ static void test_acpi_piix4_tcg_dimm_pxm(void) >>> test_acpi_tcg_dimm_pxm(MACHINE_PC); >>> } >>> =20 >>> +static void test_acpi_virt_tcg(void) >>> +{ >>> + test_data data =3D { >>> + .machine =3D "virt", >>> + .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", >>> + .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", >>> + .cd =3D "tests/data/uefi-boot-images/bios-tables-test.aarch6= 4.iso.qcow2", >>> + .ram_start =3D 0x40000000ULL, >>> + .scan_len =3D 128ULL * 1024 * 1024, >>> + }; >>> + >>> + test_acpi_one("-cpu cortex-a57 ", &data); >>> + free_test_data(&data); >>> +} >>> + >>> int main(int argc, char *argv[]) >>> { >>> const char *arch =3D qtest_get_arch(); >>> @@ -840,6 +855,8 @@ int main(int argc, char *argv[]) >>> qtest_add_func("acpi/q35/numamem", test_acpi_q35_tcg_numamem= ); >>> qtest_add_func("acpi/piix4/dimmpxm", test_acpi_piix4_tcg_dim= m_pxm); >>> qtest_add_func("acpi/q35/dimmpxm", test_acpi_q35_tcg_dimm_px= m); >>> + } else if (strcmp(arch, "aarch64") =3D=3D 0) { >>> + qtest_add_func("acpi/virt", test_acpi_virt_tcg); >>> } >>> ret =3D g_test_run(); >>> boot_sector_cleanup(disk); >>> >> >> Looks good, my R-b stands. >> >> (Please let me know if you want me to look at other patches in the >> series... struggling again with email bankruptcy...) >> >> Thanks! >> Laszlo >> >=20 > on respin there will be a new patch added >=20 > [PATCH v4 11/15] tests: acpi: allow to override default accelerator >=20 > and change to this patch will be forcing TCG accelerator: >=20 > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 6cb8b16..385e1ab 100644 > --- a/tests/bios-tables-test.c > +++ b/tests/bios-tables-test.c > @@ -817,7 +817,6 @@ static void test_acpi_virt_tcg(void) > { > test_data data =3D { > .machine =3D "virt", > + .accel =3D "tcg", > .uefi_fl1 =3D "pc-bios/edk2-aarch64-code.fd", > .uefi_fl2 =3D "pc-bios/edk2-arm-vars.fd", > .cd =3D "tests/data/uefi-boot-images/bios-tables-test.aarch64.= iso.qcow2", >=20 You can keep my R-b with that update. Thanks! Laszlo