From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:59474 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbeECIoa (ORCPT ); Thu, 3 May 2018 04:44:30 -0400 From: Kieran Bingham To: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: Kieran Bingham Subject: [PATCH v3 02/11] media: vsp1: Remove packed attributes from aligned structures Date: Thu, 3 May 2018 09:44:13 +0100 Message-Id: <238453e87f66208399a9e3626489df08bf265282.1525336865.git-series.kieran.bingham+renesas@ideasonboard.com> In-Reply-To: References: In-Reply-To: References: Sender: linux-media-owner@vger.kernel.org List-ID: The use of the packed attribute can cause a performance penalty for all accesses to the struct members, as the compiler will assume that the structure has the potential to have an unaligned base. These structures are all correctly aligned and contain no holes, thus the attribute is redundant and negatively impacts performance, so we remove the attributes entirely. Signed-off-by: Kieran Bingham --- v2 - Remove attributes entirely drivers/media/platform/vsp1/vsp1_dl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c index ce6cb210adcd..b6288ead24ae 100644 --- a/drivers/media/platform/vsp1/vsp1_dl.c +++ b/drivers/media/platform/vsp1/vsp1_dl.c @@ -25,19 +25,19 @@ struct vsp1_dl_header_list { u32 num_bytes; u32 addr; -} __attribute__((__packed__)); +}; struct vsp1_dl_header { u32 num_lists; struct vsp1_dl_header_list lists[8]; u32 next_header; u32 flags; -} __attribute__((__packed__)); +}; struct vsp1_dl_entry { u32 addr; u32 data; -} __attribute__((__packed__)); +}; /** * struct vsp1_dl_body - Display list body -- git-series 0.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kieran Bingham Subject: [PATCH v3 02/11] media: vsp1: Remove packed attributes from aligned structures Date: Thu, 3 May 2018 09:44:13 +0100 Message-ID: <238453e87f66208399a9e3626489df08bf265282.1525336865.git-series.kieran.bingham+renesas@ideasonboard.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 165846E457 for ; Thu, 3 May 2018 08:44:30 +0000 (UTC) In-Reply-To: In-Reply-To: References: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Cc: Kieran Bingham List-Id: dri-devel@lists.freedesktop.org VGhlIHVzZSBvZiB0aGUgcGFja2VkIGF0dHJpYnV0ZSBjYW4gY2F1c2UgYSBwZXJmb3JtYW5jZSBw ZW5hbHR5IGZvcgphbGwgYWNjZXNzZXMgdG8gdGhlIHN0cnVjdCBtZW1iZXJzLCBhcyB0aGUgY29t cGlsZXIgd2lsbCBhc3N1bWUgdGhhdCB0aGUKc3RydWN0dXJlIGhhcyB0aGUgcG90ZW50aWFsIHRv IGhhdmUgYW4gdW5hbGlnbmVkIGJhc2UuCgpUaGVzZSBzdHJ1Y3R1cmVzIGFyZSBhbGwgY29ycmVj dGx5IGFsaWduZWQgYW5kIGNvbnRhaW4gbm8gaG9sZXMsIHRodXMKdGhlIGF0dHJpYnV0ZSBpcyBy ZWR1bmRhbnQgYW5kIG5lZ2F0aXZlbHkgaW1wYWN0cyBwZXJmb3JtYW5jZSwgc28gd2UKcmVtb3Zl IHRoZSBhdHRyaWJ1dGVzIGVudGlyZWx5LgoKU2lnbmVkLW9mZi1ieTogS2llcmFuIEJpbmdoYW0g PGtpZXJhbi5iaW5naGFtK3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KLS0tCnYyCiAtIFJlbW92 ZSBhdHRyaWJ1dGVzIGVudGlyZWx5CgogZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFf ZGwuYyB8IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2Rs LmMgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5jCmluZGV4IGNlNmNiMjEw YWRjZC4uYjYyODhlYWQyNGFlIDEwMDY0NAotLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3Zz cDEvdnNwMV9kbC5jCisrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RsLmMK QEAgLTI1LDE5ICsyNSwxOSBAQAogc3RydWN0IHZzcDFfZGxfaGVhZGVyX2xpc3QgewogCXUzMiBu dW1fYnl0ZXM7CiAJdTMyIGFkZHI7Ci19IF9fYXR0cmlidXRlX18oKF9fcGFja2VkX18pKTsKK307 CiAKIHN0cnVjdCB2c3AxX2RsX2hlYWRlciB7CiAJdTMyIG51bV9saXN0czsKIAlzdHJ1Y3QgdnNw MV9kbF9oZWFkZXJfbGlzdCBsaXN0c1s4XTsKIAl1MzIgbmV4dF9oZWFkZXI7CiAJdTMyIGZsYWdz OwotfSBfX2F0dHJpYnV0ZV9fKChfX3BhY2tlZF9fKSk7Cit9OwogCiBzdHJ1Y3QgdnNwMV9kbF9l bnRyeSB7CiAJdTMyIGFkZHI7CiAJdTMyIGRhdGE7Ci19IF9fYXR0cmlidXRlX18oKF9fcGFja2Vk X18pKTsKK307CiAKIC8qKgogICogc3RydWN0IHZzcDFfZGxfYm9keSAtIERpc3BsYXkgbGlzdCBi b2R5Ci0tIApnaXQtc2VyaWVzIDAuOS4xCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=