From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?ISO-8859-1?Q?Roh=E1r?= Date: Sun, 18 Dec 2011 20:37:12 +0100 Subject: [U-Boot] [PATCH 13/16] New config variable CONFIG_PREMONITOR In-Reply-To: <201112181405.19222.vapier@gentoo.org> References: <2772527.Czs1Sl5aoH@pali-elitebook> <1324141398-14859-13-git-send-email-pali.rohar@gmail.com> <201112181405.19222.vapier@gentoo.org> Message-ID: <2389292.KCBdeJmam0@pali-elitebook> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday 18 December 2011 14:05:17 Mike Frysinger wrote: > On Saturday 17 December 2011 12:03:15 Pali Roh?r wrote: > > --- a/common/env_common.c > > +++ b/common/env_common.c > > > > +#ifdef CONFIG_PREMONITOR > > + "premonitor=" CONFIG_PREMONITOR "\0" > > +#endif > > > > --- a/common/main.c > > +++ b/common/main.c > > > > +#ifdef CONFIG_PREMONITOR > > + if ((s = getenv ("premonitor")) != NULL) { > > i don't these should be the same define. one is to control the default env > var value only. i would just drop the check in main.c. > > > +# ifndef CONFIG_SYS_HUSH_PARSER > > + run_command (s, 0); > > no space before the "(" > -mike So do you think that I should delete changes in env_common.c and add to main.c only this code? +#ifdef CONFIG_PREMONITOR + run_command2(CONFIG_PREMONITOR, 0); +#endif -- Pali Roh?r pali.rohar at gmail.com -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: This is a digitally signed message part. URL: