Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

[Martinx - ジェームズ]

Hey guys,

I'm seeing that there are something wrong with "standard make install",
look:

---
cd dpdk-2.2.0-rc3

make T=x86_64-native-linuxapp-gcc config

sed -ri -e 's,(RTE_MACHINE=).*,\1"default",' \
                -e 's,(RTE_APP_TEST=).*,\1n,' \
                -e 's,(LIBRTE_VHOST=).*,\1y,' \
                -e 's,(CONFIG_RTE_EAL_IGB_UIO=).*,\1n,' \
                -e 's,(CONFIG_RTE_LIBRTE_KNI=).*,\1n,' \
                -e 's,(CONFIG_RTE_BUILD_COMBINE_LIBS=).*,\1y,' \
                -e 's,(CONFIG_RTE_LIBNAME=).*,\1"dpdk",' \
                -e 's,(CONFIG_RTE_LIBRTE_PMD_XENVIRT=).*,\1y,' \
                -e 's,(RTE_BUILD_SHARED_LIB=).*,\1y,' \
                build/.config

make

# Now, the problem:

mkdir /tmp/dpdk-fakeroot

DESTDIR=/tmp/dpdk-fakeroot fakeroot make install

make[1]: Nothing to be done for 'pre_install'.
================== Installing /tmp/dpdk-fakeroot/usr/local/
cp: cannot stat
‘/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}’: No
such file or directory
/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/
rte.sdkinstall.mk:137: recipe for target 'install-sdk' failed
make[3]: *** [install-sdk] Error 1
/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/rte.sdkroot.mk:101:
recipe for target 'install-sdk' failed
make[2]: *** [install-sdk] Error 2
/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/
rte.sdkinstall.mk:107: recipe for target 'install' failed
make[1]: *** [install] Error 2
/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/rte.sdkroot.mk:98:
recipe for target 'install' failed
make: *** [install] Error 2
---

Am I missing something?


Oh, BTW, have you guys fixed the DPDK build with Xen on 32-bit? It
is broken, reported here:

http://dpdk.org/ml/archives/dev/2015-December/029261.html


Thanks!
Thiago

Re: Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

[Piotr Bartosiewicz]

> cp: cannot stat
> ‘/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}’: No
> such file or directory
> /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/
> rte.sdkinstall.mk:137: recipe for target 'install-sdk' failed
>

I have the same problem and it has nothing to do with XenVirt or 32-bit 
build.
As a workaround you can change mk/rte.sdkinstall.mk as follows:

-       $(Q)cp -a               $(RTE_SDK)/{mk,scripts} $(DESTDIR)$(sdkdir)
+       $(Q)cp -a               $(RTE_SDK)/mk $(DESTDIR)$(sdkdir)
+       $(Q)cp -a               $(RTE_SDK)/scripts $(DESTDIR)$(sdkdir)

-- 
Regards
Piotr Bartosiewicz

Re: Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

[Martinx - ジェームズ]

On 8 December 2015 at 15:01, Piotr Bartosiewicz <
piotr.bartosiewicz@atendesoftware.pl> wrote:

>
> cp: cannot stat
>> ‘/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}’: No
>> such file or directory
>> /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/
>> rte.sdkinstall.mk:137: recipe for target 'install-sdk' failed
>>
>>
> I have the same problem and it has nothing to do with XenVirt or 32-bit
> build.
> As a workaround you can change mk/rte.sdkinstall.mk as follows:
>
> -       $(Q)cp -a               $(RTE_SDK)/{mk,scripts} $(DESTDIR)$(sdkdir)
> +       $(Q)cp -a               $(RTE_SDK)/mk $(DESTDIR)$(sdkdir)
> +       $(Q)cp -a               $(RTE_SDK)/scripts $(DESTDIR)$(sdkdir)
>
> --
> Regards
> Piotr Bartosiewicz
>
>
Sure, XenVirt problem is a different issue, sorry to mix subjects on this
thread.

Re: Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

[Thomas Monjalon]

2015-12-08 18:01, Piotr Bartosiewicz:
> 
> > cp: cannot stat
> > ‘/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}’: No
> > such file or directory
> > /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/
> > rte.sdkinstall.mk:137: recipe for target 'install-sdk' failed
> >
> 
> I have the same problem and it has nothing to do with XenVirt or 32-bit 
> build.
> As a workaround you can change mk/rte.sdkinstall.mk as follows:
> 
> -       $(Q)cp -a               $(RTE_SDK)/{mk,scripts} $(DESTDIR)$(sdkdir)
> +       $(Q)cp -a               $(RTE_SDK)/mk $(DESTDIR)$(sdkdir)
> +       $(Q)cp -a               $(RTE_SDK)/scripts $(DESTDIR)$(sdkdir)

I had a doubt when writing it.
Please what is your default shell? ls -l /bin/sh

Re: Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

[Martinx - ジェームズ]

On 8 December 2015 at 17:03, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> 2015-12-08 18:01, Piotr Bartosiewicz:
> >
> > > cp: cannot stat
> > > ‘/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}’: No
> > > such file or directory
> > > /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/
> > > rte.sdkinstall.mk:137: recipe for target 'install-sdk' failed
> > >
> >
> > I have the same problem and it has nothing to do with XenVirt or 32-bit
> > build.
> > As a workaround you can change mk/rte.sdkinstall.mk as follows:
> >
> > -       $(Q)cp -a               $(RTE_SDK)/{mk,scripts}
> $(DESTDIR)$(sdkdir)
> > +       $(Q)cp -a               $(RTE_SDK)/mk $(DESTDIR)$(sdkdir)
> > +       $(Q)cp -a               $(RTE_SDK)/scripts $(DESTDIR)$(sdkdir)
>
> I had a doubt when writing it.
> Please what is your default shell? ls -l /bin/sh
>

Mine is dash (default on Debian / Ubuntu):

tmartins@xenial-1:~$ file /bin/sh
/bin/sh: symbolic link to dash

[PATCH] mk: fix install with minimal shell

[Thomas Monjalon]

Some shells like dash do not support the syntax {}:
	{mk,scripts}: No such file or directory

Reported-by: Thiago Martins <thiagocmartinsc@gmail.com>
Reported-by: Piotr Bartosiewicz <piotr.bartosiewicz@atendesoftware.pl>
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
 mk/rte.sdkinstall.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
index c611d45..c159bf7 100644
--- a/mk/rte.sdkinstall.mk
+++ b/mk/rte.sdkinstall.mk
@@ -139,7 +139,8 @@ install-sdk:
 	    tar -xf -      -C $(DESTDIR)$(includedir) --strip-components=1 \
 		--keep-newer-files --warning=no-ignore-newer
 	$(Q)$(call rte_mkdir,                            $(DESTDIR)$(sdkdir))
-	$(Q)cp -a               $(RTE_SDK)/{mk,scripts}  $(DESTDIR)$(sdkdir)
+	$(Q)cp -a               $(RTE_SDK)/mk            $(DESTDIR)$(sdkdir)
+	$(Q)cp -a               $(RTE_SDK)/scripts       $(DESTDIR)$(sdkdir)
 	$(Q)$(call rte_mkdir,                            $(DESTDIR)$(targetdir))
 	$(Q)cp -a               $O/.config               $(DESTDIR)$(targetdir)
 	$(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include)
-- 
2.5.2

Re: Problem with new "make install" of DPDK 2.2.0-rc3 + XenVirt on 32-bit build is broken

[Piotr Bartosiewicz]

W dniu 08.12.2015 o 20:07, Martinx - ジェームズ pisze:
> On 8 December 2015 at 17:03, Thomas Monjalon 
> <thomas.monjalon@6wind.com <mailto:thomas.monjalon@6wind.com>> wrote:
>
>     2015-12-08 18:01, Piotr Bartosiewicz:
>     >
>     > > cp: cannot stat
>     > >
>     ‘/home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/{mk,scripts}’:
>     No
>     > > such file or directory
>     > > /home/tmartins/sources/dpdk/2.2.0-rc3/dpdk-2.2.0-rc3/mk/
>     > > rte.sdkinstall.mk:137 <http://rte.sdkinstall.mk:137>: recipe
>     for target 'install-sdk' failed
>     > >
>     >
>     > I have the same problem and it has nothing to do with XenVirt or
>     32-bit
>     > build.
>     > As a workaround you can change mk/rte.sdkinstall.mk
>     <http://rte.sdkinstall.mk> as follows:
>     >
>     > -       $(Q)cp -a  $(RTE_SDK)/{mk,scripts} $(DESTDIR)$(sdkdir)
>     > +       $(Q)cp -a               $(RTE_SDK)/mk $(DESTDIR)$(sdkdir)
>     > +       $(Q)cp -a               $(RTE_SDK)/scripts
>     $(DESTDIR)$(sdkdir)
>
>     I had a doubt when writing it.
>     Please what is your default shell? ls -l /bin/sh
>
>
> Mine is dash (default on Debian / Ubuntu):
>
> tmartins@xenial-1:~$ file /bin/sh
> /bin/sh: symbolic link to dash
>
/bin/sh -> dash
Debian GNU/Linux 8
Ubuntu 15.10

Re: [PATCH] mk: fix install with minimal shell

[Thomas Monjalon]

2015-12-09 09:03, Thomas Monjalon:
> Some shells like dash do not support the syntax {}:
> 	{mk,scripts}: No such file or directory
> 
> Reported-by: Thiago Martins <thiagocmartinsc@gmail.com>
> Reported-by: Piotr Bartosiewicz <piotr.bartosiewicz@atendesoftware.pl>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied