All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Pavel Machek <pavel@ucw.cz>, Johannes Berg <johannes@sipsolutions.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	linuxwifi@intel.com
Subject: Re: [PATCH] fix iwlwifi on old cards in v4.19 was Re: 4.19-rc[23] iwlwifi: BUG in swiotlb
Date: Sun, 16 Sep 2018 15:27:29 -0700	[thread overview]
Message-ID: <23940459-3a95-7ccb-6ad0-dfa0790910d1@infradead.org> (raw)
In-Reply-To: <20180916095935.GA4388@amd>

On 9/16/18 2:59 AM, Pavel Machek wrote:
> 
> .max_tfd_queue_size was ommited for old cards, leading to oops in
> swiotlb.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 

Hi,
Thanks.  Works for me.

Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>


PS:  I started the b-word yesterday but my old laptop is slow...


> --- linux/drivers/net/wireless/intel/iwlwifi/cfg/1000.c	2018-09-05 13:12:40.453164067 +0200
> +++ linux-64/drivers/net/wireless/intel/iwlwifi/cfg/1000.c	2018-09-16 11:54:04.010970756 +0200
> @@ -51,6 +51,7 @@
>  
>  static const struct iwl_base_params iwl1000_base_params = {
>  	.num_of_queues = IWLAGN_NUM_QUEUES,
> +	.max_tfd_queue_size = 256,
>  	.eeprom_size = OTP_LOW_IMAGE_SIZE,
>  	.pll_cfg = true,
>  	.max_ll_items = OTP_MAX_LL_ITEMS_1000,
> 
> 


-- 
~Randy

      parent reply	other threads:[~2018-09-17  3:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11  2:17 4.19-rc[23] iwlwifi: BUG in swiotlb Randy Dunlap
2018-09-11  7:32 ` Johannes Berg
2018-09-11 20:57   ` Randy Dunlap
2018-09-11 21:02     ` Johannes Berg
2018-09-16  9:34   ` Pavel Machek
2018-09-16  9:41     ` Pavel Machek
2018-09-16  9:55       ` Pavel Machek
2018-09-16  9:59         ` [PATCH] fix iwlwifi on old cards in v4.19 was " Pavel Machek
2018-09-16 10:12           ` [linuxwifi] " Grumbach, Emmanuel
2018-09-16 10:14             ` Grumbach, Emmanuel
2018-09-16 11:06               ` Pavel Machek
2018-10-07  0:44             ` Randy Dunlap
2018-10-07  0:56               ` Randy Dunlap
2018-09-16 22:27           ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23940459-3a95-7ccb-6ad0-dfa0790910d1@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linuxwifi@intel.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.