From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v9 1/6] app/procinfo: add support for show
	port
Date: Thu, 10 Jan 2019 18:40:13 +0100
Message-ID: <2395887.NJRNHdBidz@xps>
References: <20190107153829.34047-2-vipin.varghese@intel.com>
 <20190110213645.29901-1-vipin.varghese@intel.com>
 <20190110213645.29901-2-vipin.varghese@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, konstantin.ananyev@intel.com,
 stephen@networkplumber.org, reshma.pattan@intel.com, jasvinder.singh@intel.com,
 stephen1.byrne@intel.com, amol.patel@intel.com
To: Vipin Varghese <vipin.varghese@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E01111B7E7
 for <dev@dpdk.org>; Thu, 10 Jan 2019 18:40:17 +0100 (CET)
In-Reply-To: <20190110213645.29901-2-vipin.varghese@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/01/2019 22:36, Vipin Varghese:
> Function show_port is used for displaying the port PMD information under
> primary process. The information shows basic, per queue and security.
> Also helper MACRO 'MAX_STRING_LEN, STATS_BDR_FMT and STATS_BDR_STR' and
> meson build file is updated for new functionality.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> Acked-by: Reshma  Pattan <reshma.pattan@intel.com>
> Acked-by: John McNamara <john.mcnamara@intel.com>
> ---
>  app/proc-info/main.c           | 119 ++++++++++++++++++++++++++++++++-
>  app/proc-info/meson.build      |   2 +-
>  doc/guides/tools/proc_info.rst |   9 ++-
>  3 files changed, 126 insertions(+), 4 deletions(-)
> 
> diff --git a/app/proc-info/main.c b/app/proc-info/main.c
> index c20effa4f..2108c24b0 100644
> --- a/app/proc-info/main.c
> +++ b/app/proc-info/main.c
> @@ -29,6 +29,9 @@
>  #include <rte_branch_prediction.h>
>  #include <rte_string_fns.h>
>  #include <rte_metrics.h>
> +#include <rte_cycles.h>
> +#include <rte_security.h>
> +#include <rte_cryptodev.h>

Is the crypto include really required in this patch?