From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E23C43381 for ; Wed, 23 Dec 2020 20:38:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 672CE2246B for ; Wed, 23 Dec 2020 20:38:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728895AbgLWUiG (ORCPT ); Wed, 23 Dec 2020 15:38:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbgLWUiF (ORCPT ); Wed, 23 Dec 2020 15:38:05 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14200C061794; Wed, 23 Dec 2020 12:37:25 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id 23so245997lfg.10; Wed, 23 Dec 2020 12:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wCsb7WW/M2bzd7/pDZtZYPCJvx1YT3sUxGJbbavSmFg=; b=ZvZCwqyFAc/Ql/wxh66l/3Pl+CYJdEHVkuisgepgy43WMHQBLq7lqEbSWNFjyq1ZV7 /Q8eZ//xtNKvGYwTVFKhvCqR6IX4wUEOjUuLVxma61Kdhn6mm7nF89yQA1nn43DX/U/x wbXLmPyX4MgPZeHb5ZJ7iOTMePG7hqFxLKBIKHiuOfdyP7qQ3p1EqWbGETRRjCRn0AaJ qWkN1PAfvH67YturxexyosOWCqX3ti4sO/mvJRpXPRBV1xoRkXoL/5f6CADo5wxPBb6/ gqxFM+QiZr7IeIQBHgXM66Oq+WzF9SNBaYYUtdUGbU+Ga1VkUuk5Qfwq4SfZ5OQ40AT8 Ep3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wCsb7WW/M2bzd7/pDZtZYPCJvx1YT3sUxGJbbavSmFg=; b=KbrI4dVGRgmTcSdVpVL/4/gJBaBodijZhP24kGZuC3y9oetYI6xwz1K3J0nmDjAp7G EMExuZdYy0MCk4+v6lFkJkbcLy2NxyqoVyV6UG+rsLSdhzErRzNmYAhJuygC8O/VPFNn 0zYFViJfOkZ7gFqYw9RGfvqFwXBsIAOhLnrgYZqDDp3VV30gFzddRZSRWBKXKQv3Jm26 hYdogSKT8l7V5G+b9koHq/WboIy4PIuvq5i7srHQVa52PtEPO6FzqQfIp6Hh1L6t+6Mx XD+4tFJUn8lIuYISu/SvzqXhoVSK7SqLT6yRPimaH0RNdWCj9NC4u7yWKdkHRZCqji0U wPxg== X-Gm-Message-State: AOAM533rUkNeQifKIY+81gpzlQKD1CnJKtE2OKwvHqkcpyegC1c8KDHT 369J0PKsbZKFjm9OV7CrExIZybGT95U= X-Google-Smtp-Source: ABdhPJxGiooPS8lo4Avau8/JweSYhcD8EGyLO2HFPmvlGDoqO2i9U3oI4uzk966QuJ/9xSInUThU1g== X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr10919526lfq.232.1608755843340; Wed, 23 Dec 2020 12:37:23 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id u8sm3649057ljj.1.2020.12.23.12.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:37:22 -0800 (PST) Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Mark Brown , Liam Girdwood , Ulf Hansson , Mauro Carvalho Chehab , Rob Herring , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , "Rafael J. Wysocki" , Kevin Hilman , Peter De Schrijver , Viresh Kumar , Stephen Boyd , Michael Turquette , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> From: Dmitry Osipenko Message-ID: <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Date: Wed, 23 Dec 2020 23:37:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 23.12.2020 08:57, Viresh Kumar пишет: > On 22-12-20, 22:39, Dmitry Osipenko wrote: >> 22.12.2020 22:21, Dmitry Osipenko пишет: >>>>> + if (IS_ERR(opp)) { >>>>> + dev_err(&genpd->dev, "failed to find OPP for level %u: %pe\n", >>>>> + level, opp); >>>>> + return PTR_ERR(opp); >>>>> + } >>>>> + >>>>> + err = dev_pm_opp_set_voltage(&genpd->dev, opp); >>>> IIUC, you implemented this callback because you want to use the voltage triplet >>>> present in the OPP table ? >>>> >>>> And so you are setting the regulator ("power") later in this patch ? >>> yes >>> >>>> I am not in favor of implementing this routine, as it just adds a wrapper above >>>> the regulator API. What you should be doing rather is get the regulator by >>>> yourself here (instead of depending on the OPP core). And then you can do >>>> dev_pm_opp_get_voltage() here and set the voltage yourself. You may want to >>>> implement a version supporting triplet here though for the same. >>>> >>>> And you won't require the sync version of the API as well then. >>>> >>> That's what I initially did for this driver. I don't mind to revert back >>> to the initial variant in v3, it appeared to me that it will be nicer >>> and cleaner to have OPP API managing everything here. >> >> I forgot one important detail (why the initial variant wasn't good).. >> OPP entries that have unsupportable voltages should be filtered out and >> OPP core performs the filtering only if regulator is assigned to the OPP >> table. >> >> If regulator is assigned to the OPP table, then we need to use OPP API >> for driving the regulator, hence that's why I added >> dev_pm_opp_sync_regulators() and dev_pm_opp_set_voltage(). >> >> Perhaps it should be possible to add dev_pm_opp_get_regulator() that > > What's wrong with getting the regulator in the driver as well ? Apart from the > OPP core ? The voltage syncing should be done for each consumer regulator individually [1]. Secondly, regulator core doesn't work well today if the same regulator is requested more than one time for the same device. >> will return the OPP table regulator in order to allow driver to use the >> regulator directly. But I'm not sure whether this is a much better >> option than the opp_sync_regulators() and opp_set_voltage() APIs. > > set_voltage() is still fine as there is some data that the OPP core has, but > sync_regulator() has nothing to do with OPP core. > > And this may lead to more wrapper helpers in the OPP core, which I am afraid of. > And so even if it is not the best, I would like the OPP core to provide the data > and not get into this. Ofcourse there is an exception to this, opp_set_rate. > The regulator_sync_voltage() should be invoked only if voltage was changed previously [1]. The OPP core already has the info about whether voltage was changed and it provides the necessary locking for both set_voltage() and sync_regulator(). Perhaps I'll need to duplicate that functionality in the PD driver, instead of making it all generic and re-usable by other drivers. [1] https://elixir.bootlin.com/linux/v5.10.2/source/drivers/regulator/core.c#L4107 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14352C433DB for ; Wed, 23 Dec 2020 20:37:32 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B92A9224B1 for ; Wed, 23 Dec 2020 20:37:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B92A9224B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 7EB8486960; Wed, 23 Dec 2020 20:37:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qvvuUE6vHlhw; Wed, 23 Dec 2020 20:37:27 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id A66718691C; Wed, 23 Dec 2020 20:37:27 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 67BAB1BF86B for ; Wed, 23 Dec 2020 20:37:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5A36F203E2 for ; Wed, 23 Dec 2020 20:37:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZX-eHUiKpVhE for ; Wed, 23 Dec 2020 20:37:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by silver.osuosl.org (Postfix) with ESMTPS id 49B0A203DB for ; Wed, 23 Dec 2020 20:37:25 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id m25so233875lfc.11 for ; Wed, 23 Dec 2020 12:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wCsb7WW/M2bzd7/pDZtZYPCJvx1YT3sUxGJbbavSmFg=; b=ZvZCwqyFAc/Ql/wxh66l/3Pl+CYJdEHVkuisgepgy43WMHQBLq7lqEbSWNFjyq1ZV7 /Q8eZ//xtNKvGYwTVFKhvCqR6IX4wUEOjUuLVxma61Kdhn6mm7nF89yQA1nn43DX/U/x wbXLmPyX4MgPZeHb5ZJ7iOTMePG7hqFxLKBIKHiuOfdyP7qQ3p1EqWbGETRRjCRn0AaJ qWkN1PAfvH67YturxexyosOWCqX3ti4sO/mvJRpXPRBV1xoRkXoL/5f6CADo5wxPBb6/ gqxFM+QiZr7IeIQBHgXM66Oq+WzF9SNBaYYUtdUGbU+Ga1VkUuk5Qfwq4SfZ5OQ40AT8 Ep3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wCsb7WW/M2bzd7/pDZtZYPCJvx1YT3sUxGJbbavSmFg=; b=d3FuHvMJHNeZVxP1op6euFDfrv43xXwg9Rn9PZ+RgVi9ZiTOu0bzOqkuCbJ+n9zcV+ FjhRZrCdblrmvRA7FbikOR1Pp1KRm5KQBSNomvl44O6Cr8m9Tz5+hu0mgV1Rt4Op54eF kVe0xHLku7dDyt1kc1gSxEsn5I+JvAyBOjdMRnAaddq2PcotE5x7XTHfEwCvolb6/76x AZXfJ1ZlZKo3cHPOgaz9ZB9s/HA2CAeCguDDPJrzsqwKRLMYSbT+x/drjP2KdcAQ08fZ FJdd/tiHyCN+si2cUPDnvVtniNLevVJTCfmMce/sPQiYA79HT0PB0fgjBpyMrqRPkjlf MdAQ== X-Gm-Message-State: AOAM5320ap1/PuAE49yT8CY8Zerlh/VEeoYplB42gw4W44f84t4g3BVf N++NcKzugR9fJKxvRzCKWRI= X-Google-Smtp-Source: ABdhPJxGiooPS8lo4Avau8/JweSYhcD8EGyLO2HFPmvlGDoqO2i9U3oI4uzk966QuJ/9xSInUThU1g== X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr10919526lfq.232.1608755843340; Wed, 23 Dec 2020 12:37:23 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id u8sm3649057ljj.1.2020.12.23.12.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:37:22 -0800 (PST) Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> From: Dmitry Osipenko Message-ID: <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Date: Wed, 23 Dec 2020 23:37:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> Content-Language: en-US X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" MjMuMTIuMjAyMCAwODo1NywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjItMTItMjAs IDIyOjM5LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IDIyLjEyLjIwMjAgMjI6MjEsIERtaXRy eSBPc2lwZW5rbyDQv9C40YjQtdGCOgo+Pj4+PiArCWlmIChJU19FUlIob3BwKSkgewo+Pj4+PiAr CQlkZXZfZXJyKCZnZW5wZC0+ZGV2LCAiZmFpbGVkIHRvIGZpbmQgT1BQIGZvciBsZXZlbCAldTog JXBlXG4iLAo+Pj4+PiArCQkJbGV2ZWwsIG9wcCk7Cj4+Pj4+ICsJCXJldHVybiBQVFJfRVJSKG9w cCk7Cj4+Pj4+ICsJfQo+Pj4+PiArCj4+Pj4+ICsJZXJyID0gZGV2X3BtX29wcF9zZXRfdm9sdGFn ZSgmZ2VucGQtPmRldiwgb3BwKTsKPj4+PiBJSVVDLCB5b3UgaW1wbGVtZW50ZWQgdGhpcyBjYWxs YmFjayBiZWNhdXNlIHlvdSB3YW50IHRvIHVzZSB0aGUgdm9sdGFnZSB0cmlwbGV0Cj4+Pj4gcHJl c2VudCBpbiB0aGUgT1BQIHRhYmxlID8KPj4+Pgo+Pj4+IEFuZCBzbyB5b3UgYXJlIHNldHRpbmcg dGhlIHJlZ3VsYXRvciAoInBvd2VyIikgbGF0ZXIgaW4gdGhpcyBwYXRjaCA/Cj4+PiB5ZXMKPj4+ Cj4+Pj4gSSBhbSBub3QgaW4gZmF2b3Igb2YgaW1wbGVtZW50aW5nIHRoaXMgcm91dGluZSwgYXMg aXQganVzdCBhZGRzIGEgd3JhcHBlciBhYm92ZQo+Pj4+IHRoZSByZWd1bGF0b3IgQVBJLiBXaGF0 IHlvdSBzaG91bGQgYmUgZG9pbmcgcmF0aGVyIGlzIGdldCB0aGUgcmVndWxhdG9yIGJ5Cj4+Pj4g eW91cnNlbGYgaGVyZSAoaW5zdGVhZCBvZiBkZXBlbmRpbmcgb24gdGhlIE9QUCBjb3JlKS4gQW5k IHRoZW4geW91IGNhbiBkbwo+Pj4+IGRldl9wbV9vcHBfZ2V0X3ZvbHRhZ2UoKSBoZXJlIGFuZCBz ZXQgdGhlIHZvbHRhZ2UgeW91cnNlbGYuIFlvdSBtYXkgd2FudCB0bwo+Pj4+IGltcGxlbWVudCBh IHZlcnNpb24gc3VwcG9ydGluZyB0cmlwbGV0IGhlcmUgdGhvdWdoIGZvciB0aGUgc2FtZS4KPj4+ Pgo+Pj4+IEFuZCB5b3Ugd29uJ3QgcmVxdWlyZSB0aGUgc3luYyB2ZXJzaW9uIG9mIHRoZSBBUEkg YXMgd2VsbCB0aGVuLgo+Pj4+Cj4+PiBUaGF0J3Mgd2hhdCBJIGluaXRpYWxseSBkaWQgZm9yIHRo aXMgZHJpdmVyLiBJIGRvbid0IG1pbmQgdG8gcmV2ZXJ0IGJhY2sKPj4+IHRvIHRoZSBpbml0aWFs IHZhcmlhbnQgaW4gdjMsIGl0IGFwcGVhcmVkIHRvIG1lIHRoYXQgaXQgd2lsbCBiZSBuaWNlcgo+ Pj4gYW5kIGNsZWFuZXIgdG8gaGF2ZSBPUFAgQVBJIG1hbmFnaW5nIGV2ZXJ5dGhpbmcgaGVyZS4K Pj4KPj4gSSBmb3Jnb3Qgb25lIGltcG9ydGFudCBkZXRhaWwgKHdoeSB0aGUgaW5pdGlhbCB2YXJp YW50IHdhc24ndCBnb29kKS4uCj4+IE9QUCBlbnRyaWVzIHRoYXQgaGF2ZSB1bnN1cHBvcnRhYmxl IHZvbHRhZ2VzIHNob3VsZCBiZSBmaWx0ZXJlZCBvdXQgYW5kCj4+IE9QUCBjb3JlIHBlcmZvcm1z IHRoZSBmaWx0ZXJpbmcgb25seSBpZiByZWd1bGF0b3IgaXMgYXNzaWduZWQgdG8gdGhlIE9QUAo+ PiB0YWJsZS4KPj4KPj4gSWYgcmVndWxhdG9yIGlzIGFzc2lnbmVkIHRvIHRoZSBPUFAgdGFibGUs IHRoZW4gd2UgbmVlZCB0byB1c2UgT1BQIEFQSQo+PiBmb3IgZHJpdmluZyB0aGUgcmVndWxhdG9y LCBoZW5jZSB0aGF0J3Mgd2h5IEkgYWRkZWQKPj4gZGV2X3BtX29wcF9zeW5jX3JlZ3VsYXRvcnMo KSBhbmQgZGV2X3BtX29wcF9zZXRfdm9sdGFnZSgpLgo+Pgo+PiBQZXJoYXBzIGl0IHNob3VsZCBi ZSBwb3NzaWJsZSB0byBhZGQgZGV2X3BtX29wcF9nZXRfcmVndWxhdG9yKCkgdGhhdAo+IAo+IFdo YXQncyB3cm9uZyB3aXRoIGdldHRpbmcgdGhlIHJlZ3VsYXRvciBpbiB0aGUgZHJpdmVyIGFzIHdl bGwgPyBBcGFydCBmcm9tIHRoZQo+IE9QUCBjb3JlID8KClRoZSB2b2x0YWdlIHN5bmNpbmcgc2hv dWxkIGJlIGRvbmUgZm9yIGVhY2ggY29uc3VtZXIgcmVndWxhdG9yCmluZGl2aWR1YWxseSBbMV0u CgpTZWNvbmRseSwgcmVndWxhdG9yIGNvcmUgZG9lc24ndCB3b3JrIHdlbGwgdG9kYXkgaWYgdGhl IHNhbWUgcmVndWxhdG9yCmlzIHJlcXVlc3RlZCBtb3JlIHRoYW4gb25lIHRpbWUgZm9yIHRoZSBz YW1lIGRldmljZS4KCj4+IHdpbGwgcmV0dXJuIHRoZSBPUFAgdGFibGUgcmVndWxhdG9yIGluIG9y ZGVyIHRvIGFsbG93IGRyaXZlciB0byB1c2UgdGhlCj4+IHJlZ3VsYXRvciBkaXJlY3RseS4gQnV0 IEknbSBub3Qgc3VyZSB3aGV0aGVyIHRoaXMgaXMgYSBtdWNoIGJldHRlcgo+PiBvcHRpb24gdGhh biB0aGUgb3BwX3N5bmNfcmVndWxhdG9ycygpIGFuZCBvcHBfc2V0X3ZvbHRhZ2UoKSBBUElzLgo+ IAo+IHNldF92b2x0YWdlKCkgaXMgc3RpbGwgZmluZSBhcyB0aGVyZSBpcyBzb21lIGRhdGEgdGhh dCB0aGUgT1BQIGNvcmUgaGFzLCBidXQKPiBzeW5jX3JlZ3VsYXRvcigpIGhhcyBub3RoaW5nIHRv IGRvIHdpdGggT1BQIGNvcmUuCj4gCj4gQW5kIHRoaXMgbWF5IGxlYWQgdG8gbW9yZSB3cmFwcGVy IGhlbHBlcnMgaW4gdGhlIE9QUCBjb3JlLCB3aGljaCBJIGFtIGFmcmFpZCBvZi4KPiBBbmQgc28g ZXZlbiBpZiBpdCBpcyBub3QgdGhlIGJlc3QsIEkgd291bGQgbGlrZSB0aGUgT1BQIGNvcmUgdG8g cHJvdmlkZSB0aGUgZGF0YQo+IGFuZCBub3QgZ2V0IGludG8gdGhpcy4gT2Zjb3Vyc2UgdGhlcmUg aXMgYW4gZXhjZXB0aW9uIHRvIHRoaXMsIG9wcF9zZXRfcmF0ZS4KPiAKClRoZSByZWd1bGF0b3Jf c3luY192b2x0YWdlKCkgc2hvdWxkIGJlIGludm9rZWQgb25seSBpZiB2b2x0YWdlIHdhcwpjaGFu Z2VkIHByZXZpb3VzbHkgWzFdLgoKVGhlIE9QUCBjb3JlIGFscmVhZHkgaGFzIHRoZSBpbmZvIGFi b3V0IHdoZXRoZXIgdm9sdGFnZSB3YXMgY2hhbmdlZCBhbmQKaXQgcHJvdmlkZXMgdGhlIG5lY2Vz c2FyeSBsb2NraW5nIGZvciBib3RoIHNldF92b2x0YWdlKCkgYW5kCnN5bmNfcmVndWxhdG9yKCku IFBlcmhhcHMgSSdsbCBuZWVkIHRvIGR1cGxpY2F0ZSB0aGF0IGZ1bmN0aW9uYWxpdHkgaW4KdGhl IFBEIGRyaXZlciwgaW5zdGVhZCBvZiBtYWtpbmcgaXQgYWxsIGdlbmVyaWMgYW5kIHJlLXVzYWJs ZSBieSBvdGhlcgpkcml2ZXJzLgoKWzFdCmh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4 L3Y1LjEwLjIvc291cmNlL2RyaXZlcnMvcmVndWxhdG9yL2NvcmUuYyNMNDEwNwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QK ZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVy cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 418F5C433DB for ; Fri, 25 Dec 2020 09:42:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E83C0230FF for ; Fri, 25 Dec 2020 09:42:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E83C0230FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CD5BB899D5; Fri, 25 Dec 2020 09:42:09 +0000 (UTC) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0D676E88D for ; Wed, 23 Dec 2020 20:37:24 +0000 (UTC) Received: by mail-lf1-x136.google.com with SMTP id l11so366039lfg.0 for ; Wed, 23 Dec 2020 12:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wCsb7WW/M2bzd7/pDZtZYPCJvx1YT3sUxGJbbavSmFg=; b=ZvZCwqyFAc/Ql/wxh66l/3Pl+CYJdEHVkuisgepgy43WMHQBLq7lqEbSWNFjyq1ZV7 /Q8eZ//xtNKvGYwTVFKhvCqR6IX4wUEOjUuLVxma61Kdhn6mm7nF89yQA1nn43DX/U/x wbXLmPyX4MgPZeHb5ZJ7iOTMePG7hqFxLKBIKHiuOfdyP7qQ3p1EqWbGETRRjCRn0AaJ qWkN1PAfvH67YturxexyosOWCqX3ti4sO/mvJRpXPRBV1xoRkXoL/5f6CADo5wxPBb6/ gqxFM+QiZr7IeIQBHgXM66Oq+WzF9SNBaYYUtdUGbU+Ga1VkUuk5Qfwq4SfZ5OQ40AT8 Ep3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wCsb7WW/M2bzd7/pDZtZYPCJvx1YT3sUxGJbbavSmFg=; b=uV4o711XDx+A0QeLrfthhxWr/RNIHFdmGnf5pQh/x/AopkPpF48+dAWvghu+gN17k5 xMYWRUgeaPZhvngLIHo1A9rW+7l028yc1a2lt44dOYJnJYRZQSLzmPpGilx88il1Efiw +L291u9tRZ0dpc+9oXLJ8JxxNitLB06Kee7zJFOhXz535Np+8g07Ptl3nPokS+030iuJ bM5FV58C3vA1FmRw23LWM/XjuZs1hXDf6NCKLE/HsV9uvlD+7iyDiwzmJSDw1cyG24iK C21UQrECziyVMyNc17Iv20cCsinykvlFkmjIuqwsUIf1MFUMaHI6eobjyvbziRSpVqnL LoCA== X-Gm-Message-State: AOAM533GkB7UEpHceFgkpPyPLLKXNZ2Q4t11crMFRNjrDdEocNtuT26Y RjVmpCHTsaLCQqR37laWigw= X-Google-Smtp-Source: ABdhPJxGiooPS8lo4Avau8/JweSYhcD8EGyLO2HFPmvlGDoqO2i9U3oI4uzk966QuJ/9xSInUThU1g== X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr10919526lfq.232.1608755843340; Wed, 23 Dec 2020 12:37:23 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id u8sm3649057ljj.1.2020.12.23.12.37.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Dec 2020 12:37:22 -0800 (PST) Subject: Re: [PATCH v2 28/48] soc/tegra: Introduce core power domain driver To: Viresh Kumar References: <20201217180638.22748-1-digetx@gmail.com> <20201217180638.22748-29-digetx@gmail.com> <20201222064029.duuzcsj53rt7xzvt@vireshk-i7> <3a5c00e5-2cdd-35ce-2714-d4ffbf9d516a@gmail.com> <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> From: Dmitry Osipenko Message-ID: <239642ad-d7e9-364e-80d3-1da67625e247@gmail.com> Date: Wed, 23 Dec 2020 23:37:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20201223055715.2n5eba7fohrwpgr5@vireshk-i7> Content-Language: en-US X-Mailman-Approved-At: Fri, 25 Dec 2020 09:42:09 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Michael Turquette , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thierry Reding , linux-clk@vger.kernel.org, devel@driverdev.osuosl.org, Kevin Hilman , Nicolas Chauvet , Viresh Kumar , Krzysztof Kozlowski , Jonathan Hunter , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-tegra@vger.kernel.org, Mauro Carvalho Chehab , Stephen Boyd , Peter De Schrijver , "Rafael J. Wysocki" , Liam Girdwood , Mark Brown , Peter Geis Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjMuMTIuMjAyMCAwODo1NywgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjItMTItMjAs IDIyOjM5LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IDIyLjEyLjIwMjAgMjI6MjEsIERtaXRy eSBPc2lwZW5rbyDQv9C40YjQtdGCOgo+Pj4+PiArCWlmIChJU19FUlIob3BwKSkgewo+Pj4+PiAr CQlkZXZfZXJyKCZnZW5wZC0+ZGV2LCAiZmFpbGVkIHRvIGZpbmQgT1BQIGZvciBsZXZlbCAldTog JXBlXG4iLAo+Pj4+PiArCQkJbGV2ZWwsIG9wcCk7Cj4+Pj4+ICsJCXJldHVybiBQVFJfRVJSKG9w cCk7Cj4+Pj4+ICsJfQo+Pj4+PiArCj4+Pj4+ICsJZXJyID0gZGV2X3BtX29wcF9zZXRfdm9sdGFn ZSgmZ2VucGQtPmRldiwgb3BwKTsKPj4+PiBJSVVDLCB5b3UgaW1wbGVtZW50ZWQgdGhpcyBjYWxs YmFjayBiZWNhdXNlIHlvdSB3YW50IHRvIHVzZSB0aGUgdm9sdGFnZSB0cmlwbGV0Cj4+Pj4gcHJl c2VudCBpbiB0aGUgT1BQIHRhYmxlID8KPj4+Pgo+Pj4+IEFuZCBzbyB5b3UgYXJlIHNldHRpbmcg dGhlIHJlZ3VsYXRvciAoInBvd2VyIikgbGF0ZXIgaW4gdGhpcyBwYXRjaCA/Cj4+PiB5ZXMKPj4+ Cj4+Pj4gSSBhbSBub3QgaW4gZmF2b3Igb2YgaW1wbGVtZW50aW5nIHRoaXMgcm91dGluZSwgYXMg aXQganVzdCBhZGRzIGEgd3JhcHBlciBhYm92ZQo+Pj4+IHRoZSByZWd1bGF0b3IgQVBJLiBXaGF0 IHlvdSBzaG91bGQgYmUgZG9pbmcgcmF0aGVyIGlzIGdldCB0aGUgcmVndWxhdG9yIGJ5Cj4+Pj4g eW91cnNlbGYgaGVyZSAoaW5zdGVhZCBvZiBkZXBlbmRpbmcgb24gdGhlIE9QUCBjb3JlKS4gQW5k IHRoZW4geW91IGNhbiBkbwo+Pj4+IGRldl9wbV9vcHBfZ2V0X3ZvbHRhZ2UoKSBoZXJlIGFuZCBz ZXQgdGhlIHZvbHRhZ2UgeW91cnNlbGYuIFlvdSBtYXkgd2FudCB0bwo+Pj4+IGltcGxlbWVudCBh IHZlcnNpb24gc3VwcG9ydGluZyB0cmlwbGV0IGhlcmUgdGhvdWdoIGZvciB0aGUgc2FtZS4KPj4+ Pgo+Pj4+IEFuZCB5b3Ugd29uJ3QgcmVxdWlyZSB0aGUgc3luYyB2ZXJzaW9uIG9mIHRoZSBBUEkg YXMgd2VsbCB0aGVuLgo+Pj4+Cj4+PiBUaGF0J3Mgd2hhdCBJIGluaXRpYWxseSBkaWQgZm9yIHRo aXMgZHJpdmVyLiBJIGRvbid0IG1pbmQgdG8gcmV2ZXJ0IGJhY2sKPj4+IHRvIHRoZSBpbml0aWFs IHZhcmlhbnQgaW4gdjMsIGl0IGFwcGVhcmVkIHRvIG1lIHRoYXQgaXQgd2lsbCBiZSBuaWNlcgo+ Pj4gYW5kIGNsZWFuZXIgdG8gaGF2ZSBPUFAgQVBJIG1hbmFnaW5nIGV2ZXJ5dGhpbmcgaGVyZS4K Pj4KPj4gSSBmb3Jnb3Qgb25lIGltcG9ydGFudCBkZXRhaWwgKHdoeSB0aGUgaW5pdGlhbCB2YXJp YW50IHdhc24ndCBnb29kKS4uCj4+IE9QUCBlbnRyaWVzIHRoYXQgaGF2ZSB1bnN1cHBvcnRhYmxl IHZvbHRhZ2VzIHNob3VsZCBiZSBmaWx0ZXJlZCBvdXQgYW5kCj4+IE9QUCBjb3JlIHBlcmZvcm1z IHRoZSBmaWx0ZXJpbmcgb25seSBpZiByZWd1bGF0b3IgaXMgYXNzaWduZWQgdG8gdGhlIE9QUAo+ PiB0YWJsZS4KPj4KPj4gSWYgcmVndWxhdG9yIGlzIGFzc2lnbmVkIHRvIHRoZSBPUFAgdGFibGUs IHRoZW4gd2UgbmVlZCB0byB1c2UgT1BQIEFQSQo+PiBmb3IgZHJpdmluZyB0aGUgcmVndWxhdG9y LCBoZW5jZSB0aGF0J3Mgd2h5IEkgYWRkZWQKPj4gZGV2X3BtX29wcF9zeW5jX3JlZ3VsYXRvcnMo KSBhbmQgZGV2X3BtX29wcF9zZXRfdm9sdGFnZSgpLgo+Pgo+PiBQZXJoYXBzIGl0IHNob3VsZCBi ZSBwb3NzaWJsZSB0byBhZGQgZGV2X3BtX29wcF9nZXRfcmVndWxhdG9yKCkgdGhhdAo+IAo+IFdo YXQncyB3cm9uZyB3aXRoIGdldHRpbmcgdGhlIHJlZ3VsYXRvciBpbiB0aGUgZHJpdmVyIGFzIHdl bGwgPyBBcGFydCBmcm9tIHRoZQo+IE9QUCBjb3JlID8KClRoZSB2b2x0YWdlIHN5bmNpbmcgc2hv dWxkIGJlIGRvbmUgZm9yIGVhY2ggY29uc3VtZXIgcmVndWxhdG9yCmluZGl2aWR1YWxseSBbMV0u CgpTZWNvbmRseSwgcmVndWxhdG9yIGNvcmUgZG9lc24ndCB3b3JrIHdlbGwgdG9kYXkgaWYgdGhl IHNhbWUgcmVndWxhdG9yCmlzIHJlcXVlc3RlZCBtb3JlIHRoYW4gb25lIHRpbWUgZm9yIHRoZSBz YW1lIGRldmljZS4KCj4+IHdpbGwgcmV0dXJuIHRoZSBPUFAgdGFibGUgcmVndWxhdG9yIGluIG9y ZGVyIHRvIGFsbG93IGRyaXZlciB0byB1c2UgdGhlCj4+IHJlZ3VsYXRvciBkaXJlY3RseS4gQnV0 IEknbSBub3Qgc3VyZSB3aGV0aGVyIHRoaXMgaXMgYSBtdWNoIGJldHRlcgo+PiBvcHRpb24gdGhh biB0aGUgb3BwX3N5bmNfcmVndWxhdG9ycygpIGFuZCBvcHBfc2V0X3ZvbHRhZ2UoKSBBUElzLgo+ IAo+IHNldF92b2x0YWdlKCkgaXMgc3RpbGwgZmluZSBhcyB0aGVyZSBpcyBzb21lIGRhdGEgdGhh dCB0aGUgT1BQIGNvcmUgaGFzLCBidXQKPiBzeW5jX3JlZ3VsYXRvcigpIGhhcyBub3RoaW5nIHRv IGRvIHdpdGggT1BQIGNvcmUuCj4gCj4gQW5kIHRoaXMgbWF5IGxlYWQgdG8gbW9yZSB3cmFwcGVy IGhlbHBlcnMgaW4gdGhlIE9QUCBjb3JlLCB3aGljaCBJIGFtIGFmcmFpZCBvZi4KPiBBbmQgc28g ZXZlbiBpZiBpdCBpcyBub3QgdGhlIGJlc3QsIEkgd291bGQgbGlrZSB0aGUgT1BQIGNvcmUgdG8g cHJvdmlkZSB0aGUgZGF0YQo+IGFuZCBub3QgZ2V0IGludG8gdGhpcy4gT2Zjb3Vyc2UgdGhlcmUg aXMgYW4gZXhjZXB0aW9uIHRvIHRoaXMsIG9wcF9zZXRfcmF0ZS4KPiAKClRoZSByZWd1bGF0b3Jf c3luY192b2x0YWdlKCkgc2hvdWxkIGJlIGludm9rZWQgb25seSBpZiB2b2x0YWdlIHdhcwpjaGFu Z2VkIHByZXZpb3VzbHkgWzFdLgoKVGhlIE9QUCBjb3JlIGFscmVhZHkgaGFzIHRoZSBpbmZvIGFi b3V0IHdoZXRoZXIgdm9sdGFnZSB3YXMgY2hhbmdlZCBhbmQKaXQgcHJvdmlkZXMgdGhlIG5lY2Vz c2FyeSBsb2NraW5nIGZvciBib3RoIHNldF92b2x0YWdlKCkgYW5kCnN5bmNfcmVndWxhdG9yKCku IFBlcmhhcHMgSSdsbCBuZWVkIHRvIGR1cGxpY2F0ZSB0aGF0IGZ1bmN0aW9uYWxpdHkgaW4KdGhl IFBEIGRyaXZlciwgaW5zdGVhZCBvZiBtYWtpbmcgaXQgYWxsIGdlbmVyaWMgYW5kIHJlLXVzYWJs ZSBieSBvdGhlcgpkcml2ZXJzLgoKWzFdCmh0dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4 L3Y1LjEwLjIvc291cmNlL2RyaXZlcnMvcmVndWxhdG9yL2NvcmUuYyNMNDEwNwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK