From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v3 26/40] net/dpaa: add support for MTU update Date: Fri, 22 Sep 2017 12:18:25 +0530 Message-ID: <239b59d8-14b5-ce15-5880-2d54ed0eaa3c@nxp.com> References: <1499179471-19145-1-git-send-email-shreyansh.jain@nxp.com> <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170823141213.25476-27-shreyansh.jain@nxp.com> <4032615.AoB34TpWXn@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , To: Thomas Monjalon Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0083.outbound.protection.outlook.com [104.47.36.83]) by dpdk.org (Postfix) with ESMTP id DFEA8F94 for ; Fri, 22 Sep 2017 08:37:33 +0200 (CEST) In-Reply-To: <4032615.AoB34TpWXn@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Friday 22 September 2017 03:37 AM, Thomas Monjalon wrote: > 23/08/2017 16:11, Shreyansh Jain: >> Signed-off-by: Hemant Agrawal >> Signed-off-by: Shreyansh Jain >> --- >> doc/guides/nics/features/dpaa.ini | 1 + >> drivers/net/dpaa/dpaa_ethdev.c | 21 +++++++++++++++++++++ > > It is very good to update features matrix and code in the same patch. > History tracking will be easy, thanks. > > About the title, every patches start with "add support for". > It is wasting 7 characters :) You could just say "support". > Example: > net/dpaa: support MTU update > Ok. I will do that.