All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-block@nongnu.org
Subject: Re: [PATCH v3 3/8] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c
Date: Mon, 17 May 2021 14:04:32 -0400	[thread overview]
Message-ID: <239bdcfb-1172-c27f-7cd3-2bb86c8beb3d@redhat.com> (raw)
In-Reply-To: <20210517174947.1199649-4-philmd@redhat.com>

On 5/17/21 1:49 PM, Philippe Mathieu-Daudé wrote:
> Some machines use floppy controllers via the SysBus interface,
> and don't need to pull in all the ISA code.
> Extract the ISA specific code to a new unit: fdc-isa.c, and
> add a new Kconfig symbol: "FDC_ISA".
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Sorry, I'm seeing build failures on this for patch #03:

../../configure --enable-docs; and make -j13

...

/usr/bin/ld: libcommon.fa.p/hw_isa_isa-superio.c.o: in function 
`isa_superio_realize':
/home/jsnow/src/qemu/bin/git/../../hw/isa/isa-superio.c:132: undefined 
reference to `isa_fdc_init_drives'
collect2: error: ld returned 1 exit status


--js



  reply	other threads:[~2021-05-17 18:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17 17:49 [PATCH v3 0/8] hw/block/fdc: Allow Kconfig-selecting ISA bus/SysBus floppy controllers Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 1/8] hw/block/fdc: Replace disabled fprintf() by trace event Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 2/8] hw/block/fdc: Declare shared prototypes in fdc-internal.h Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 3/8] hw/block/fdc: Extract ISA floppy controllers to fdc-isa.c Philippe Mathieu-Daudé
2021-05-17 18:04   ` John Snow [this message]
2021-05-17 18:19     ` John Snow
2021-05-17 18:40       ` Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 4/8] hw/block/fdc: Extract SysBus floppy controllers to fdc-sysbus.c Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 5/8] hw/block/fdc: Add sysbus_fdc_init_drives() method Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 6/8] hw/sparc/sun4m: Inline sun4m_fdctrl_init() Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 7/8] hw/block/fdc-sysbus: Add 'dma-channel' property Philippe Mathieu-Daudé
2021-05-17 17:49 ` [PATCH v3 8/8] hw/mips/jazz: Inline fdctrl_init_sysbus() Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=239bdcfb-1172-c27f-7cd3-2bb86c8beb3d@redhat.com \
    --to=jsnow@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=philmd@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.