[U-Boot] [PATCH 2/2] usb: kbd: implement special keys

[Heinrich Schuchardt <xypron.glpk@gmx.de>]

On 02/23/2018 09:59 PM, Simon Glass wrote:
> Hi Heinrich,
> 
> On 22 February 2018 at 05:04, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>> Correct support for arrow keys: use the standard xterm escape sequences.
>>
>> Provide support for F1-F12, Insert, Delete, Home, End, Page Up, Page Down.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>   common/usb_kbd.c | 121 +++++++++++++++++++++++++++++++++++++++++--------------
>>   1 file changed, 90 insertions(+), 31 deletions(-)
>>
> 
> Is there any way this code could be shared with input.c? It has
> translation tables.

Hello Simon,

input.c seems to be another incomplete implementation of a keyboard 
driver. Yes it would make sense to avoid duplicating code. But 
unfortunately input.c lacks any documentation.

As maintainer I hope you can answer the following:

When configuring a German keyboard and typing Right-Alt + M the output 
is 0xE6. This is mju (µ) in code page 437. Wouldn't we always use UTF-8 
in U-Boot?

The scan codes for PS/2 serial keyboards and USB keyboards differ (cf. 
"USB HID to PS/2 Scan Code Translation Table" 
http://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf). 
Is input.c meant to handle PS/2 scan codes or USB scan codes?

Regards

Heinrich