From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5884EC43381 for ; Tue, 26 Mar 2019 15:30:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 258F820823 for ; Tue, 26 Mar 2019 15:30:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WPalp1ml" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731936AbfCZPaB (ORCPT ); Tue, 26 Mar 2019 11:30:01 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34156 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbfCZPaA (ORCPT ); Tue, 26 Mar 2019 11:30:00 -0400 Received: by mail-pg1-f195.google.com with SMTP id v12so8445562pgq.1 for ; Tue, 26 Mar 2019 08:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jWvtNHzV7ZLc5AQzw9NVuMcn3oe+PozDogZVZNcLZ3k=; b=WPalp1mllea3musft0vRjumsPwXD94gbLD9nY1erVCzQvMeBYiRV7mTZY4Ygx02qYf hU79xoK8ntJDgp4KxaQLktJ5ob0+unvDtnS4Y4LXpAyOdyVl7xpaafLpC+3yyDwTbCa9 hOR0g/mxRc+nGDFexKkPvE6963dmHSViHmdpFi+aWWCFHblsLl2h2BG4Mzu/EnBYG6UJ pplVATRSNooZkL1xNMReDYX08ocqcdg2aWDc+02HlDucA0rSQXbGOEfB++88nRJNz/kv j/63fn8vBVfKsJcnB0r6enIa2xrbaDgcGJR/SMPOes0bzBRPwg9dFIBCOyxJG5VZoUXF Jw9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jWvtNHzV7ZLc5AQzw9NVuMcn3oe+PozDogZVZNcLZ3k=; b=HrsyoUiA88RrRE/7A0yOIQ1jLzog4uSh9zqpggD0lOs1cjIcLtRgCqHQ+ytluLYh6S gI+Dpw4p3Y6rl9biYE35t+mtpBrm8n8FblXrYvxmar9DX1o9iwaRvo/k1d/ntpdVhYkl GmFi6npOapttH7lOX+gNz6vwAhXep61RRSTVcHSNjdGeZRlPHk6+kcZ7oV5oofiZRMRW QagaXSi7kQG+hAdCBp3qBD7F/6zrgHHMpKc/gx0SOitD1FBk/yiF5EV/JDEqUCsgbY1k 05IIeuEH/u9M/+pa69gYYINa24e3EsPi5DtiHIt9IhgOuhSf/kHG2wFw+K0s4ElbDteV bQtg== X-Gm-Message-State: APjAAAU+MG+twjP5ZI8xOG/X1apqcbCQAJNBD655coLMHffG6KwLZIYB vEXMBhOO48ds8iwyOoiW44kUq82t X-Google-Smtp-Source: APXvYqyK5afTUCrTtlWNLIKtquXw1V8RY3w/LoyCk0kEsj76NMOkkSuhPRuIYo5d4M0v5GeMMT2kLA== X-Received: by 2002:a62:1701:: with SMTP id 1mr22686144pfx.120.1553614199845; Tue, 26 Mar 2019 08:29:59 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:68e1:6a44:f6ee:46a4? ([2601:282:800:fd80:68e1:6a44:f6ee:46a4]) by smtp.googlemail.com with ESMTPSA id j17sm18475496pfa.51.2019.03.26.08.29.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 08:29:59 -0700 (PDT) Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file To: Alexei Starovoitov Cc: David Miller , netdev@vger.kernel.org, edumazet@google.com, kafai@fb.com References: <20190322130609.11655-1-dsahern@kernel.org> <20190323.214023.610983922857554034.davem@davemloft.net> <20190324035550.b4qjyl5ccfvc3tzi@ast-mbp> <20190325032641.5xyav65phoeadgye@ast-mbp> <61520dad-939f-46ff-626b-dea91b845aa3@gmail.com> <20190326030536.kjzp2redp33y7hk6@ast-mbp> <20190326151123.uz5g72gfxj2nr7fk@ast-mbp> From: David Ahern Message-ID: <239e6141-5153-f21c-57d3-e39542477158@gmail.com> Date: Tue, 26 Mar 2019 09:29:56 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190326151123.uz5g72gfxj2nr7fk@ast-mbp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/26/19 9:11 AM, Alexei Starovoitov wrote: > On Tue, Mar 26, 2019 at 08:19:06AM -0600, David Ahern wrote: >> work needed. To be able to reach certain clear steps and still maintain >> the 20'ish patches in a set requirement, I have sent a few patches which >> are standalone and basically noise - like this one - to avoid >> distractions on the real change. > > This patch is far from noise. In the thread you said that you'll be > adding 4 more indirect calls and that rings performance alarms. > retpoline is expensive. If you want to add more indirect calls to fib lookup > it's no go. Benchmarks with retpoline=off won't show the difference. > As I stated in the email I sent ("net: Improve route scalability via support for nexthop objects"): "adding hooks to the ipv6 stubs (bump sernum, send route notifications and delete routes based on nexthop updates)." Those plus initialization and release of fib6_nh are all done in the control path.