All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 06/10] x86/microcode/AMD: Check patch size in verify_and_add_patch()
Date: Fri, 23 Mar 2018 15:40:50 +0100	[thread overview]
Message-ID: <239ed1f7-cf4a-f187-549f-ea7e08b4e765@maciej.szmigiero.name> (raw)
In-Reply-To: <20180322161130.GA11575@cz.tnic>

On 22.03.2018 17:11, Borislav Petkov wrote:
> On Fri, Mar 16, 2018 at 12:08:17AM +0100, Maciej S. Szmigiero wrote:
>> @@ -505,7 +505,7 @@ static unsigned int verify_patch_size(u8 family, u32 patch_size,
>>  		break;
>>  	}
>>  
>> -	if (patch_size > min_t(u32, size, max_size)) {
>> +	if (patch_size > min_t(size_t, size, max_size)) {
> 
> So I don't like this conversion to 8-byte-width size_t's. It is not
> necessary. I'm pretty sure we can do fine with signed and unsigned ints.

It is possible to keep verify_patch_size() unmodified (with unsigned int
and u32) but microcode container files >4GB in size then may be rejected,
even if they are technically valid (while a bit unrealistic) on 64-bit
kernels.

Thanks,
Maciej

  reply	other threads:[~2018-03-23 14:40 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1521150415.git.mail@maciej.szmigiero.name>
2018-03-15 23:07 ` [PATCH v4 01/10] x86/microcode/AMD: Subtract SECTION_HDR_SIZE from file leftover length Maciej S. Szmigiero
2018-03-18 16:12   ` Borislav Petkov
2018-04-18 12:39     ` Maciej S. Szmigiero
2018-04-18 13:53       ` Borislav Petkov
2018-04-18 13:57         ` Maciej S. Szmigiero
2018-04-18 14:59           ` Borislav Petkov
2018-03-15 23:07 ` [PATCH v4 02/10] x86/microcode/AMD: Check equivalence table length in the early loader Maciej S. Szmigiero
2018-03-20 15:41   ` Borislav Petkov
2018-03-15 23:08 ` [PATCH v4 03/10] x86/microcode/AMD: Check equivalence table length in the late loader Maciej S. Szmigiero
2018-03-20 17:53   ` Borislav Petkov
2018-03-15 23:08 ` [PATCH v4 04/10] x86/microcode/AMD: install_equiv_cpu_table() should not return a signed int Maciej S. Szmigiero
2018-03-15 23:08 ` [PATCH v4 05/10] x86/microcode/AMD: Add a reminder about PATCH_MAX_SIZE macro Maciej S. Szmigiero
2018-03-15 23:08 ` [PATCH v4 06/10] x86/microcode/AMD: Check patch size in verify_and_add_patch() Maciej S. Szmigiero
2018-03-22 16:11   ` Borislav Petkov
2018-03-23 14:40     ` Maciej S. Szmigiero [this message]
2018-03-23 16:18       ` Boris Petkov
2018-03-15 23:08 ` [PATCH v4 07/10] x86/microcode/AMD: Verify patch section type for every such section Maciej S. Szmigiero
2018-03-15 23:08 ` [PATCH v4 08/10] x86/microcode/AMD: Check microcode container file size before accessing it Maciej S. Szmigiero
2018-03-26 17:48   ` Borislav Petkov
2018-03-15 23:08 ` [PATCH v4 09/10] x86/microcode/AMD: Check the equivalence table size when scanning it Maciej S. Szmigiero
2018-03-15 23:08 ` [PATCH v4 10/10] x86/microcode/AMD: Be more tolerant of late parse failures in late loader Maciej S. Szmigiero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=239ed1f7-cf4a-f187-549f-ea7e08b4e765@maciej.szmigiero.name \
    --to=mail@maciej.szmigiero.name \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.